New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 603991 link

Starred by 1 user

Issue metadata

Status: Fixed
Merged: issue 598482
Owner:
Last visit > 30 days ago
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocked on:
issue 532652
issue 598482
issue 605944



Sign in to add a comment

"content_shell_test_apk (with patch)" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Apr 15 2016

Issue description

"content_shell_test_apk (with patch)" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyLgsSBUZsYWtlIiNjb250ZW50X3NoZWxsX3Rlc3RfYXBrICh3aXRoIHBhdGNoKQw.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Project Member

Comment 1 by chromium...@appspot.gserviceaccount.com, Apr 18 2016

Detected 4 new flakes for test/step "content_shell_test_apk (with patch)". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyLgsSBUZsYWtlIiNjb250ZW50X3NoZWxsX3Rlc3RfYXBrICh3aXRoIHBhdGNoKQw. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).

Comment 2 by perkj@chromium.org, Apr 18 2016

Labels: -Sheriff-Chromium
Owner: changwan@chromium.org
IME tests still seem to be flaky. 
changwan can you please find an owner? 
Project Member

Comment 3 by chromium...@appspot.gserviceaccount.com, Apr 19 2016

Labels: Sheriff-Chromium
Detected 14 new flakes for test/step "content_shell_test_apk (with patch)". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyLgsSBUZsYWtlIiNjb250ZW50X3NoZWxsX3Rlc3RfYXBrICh3aXRoIHBhdGNoKQw. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
Project Member

Comment 4 by chromium...@appspot.gserviceaccount.com, Apr 20 2016

Detected 4 new flakes for test/step "content_shell_test_apk (with patch)". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyLgsSBUZsYWtlIiNjb250ZW50X3NoZWxsX3Rlc3RfYXBrICh3aXRoIHBhdGNoKQw. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
Project Member

Comment 5 by chromium...@appspot.gserviceaccount.com, Apr 21 2016

Detected 3 new flakes for test/step "content_shell_test_apk (with patch)". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyLgsSBUZsYWtlIiNjb250ZW50X3NoZWxsX3Rlc3RfYXBrICh3aXRoIHBhdGNoKQw. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
Cc: miguelg@chromium.org
Labels: -Sheriff-Chromium
Status: Assigned (was: Untriaged)
CCing one of the two Android sheriffs - Chrome sheriffs can't do much here without a blamelist/culprit CL.

(jbudorick already have similar flakiness bugs, so I'm spreading the load a little).
Project Member

Comment 7 by chromium...@appspot.gserviceaccount.com, Apr 22 2016

Labels: Sheriff-Chromium
Detected 4 new flakes for test/step "content_shell_test_apk (with patch)". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyLgsSBUZsYWtlIiNjb250ZW50X3NoZWxsX3Rlc3RfYXBrICh3aXRoIHBhdGNoKQw. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
Cc: bengr@chromium.org dgn@chromium.org
Labels: -Sheriff-Chromium OS-Android
Adding new Android sheriffs.
Re-removing Chrome sheriff label.

Comment 9 by dgn@chromium.org, Apr 22 2016

Blockedon: 598482 605944 532652
Tried to follow up on some of the flakes:

598482 - ImeTest#testImeCopy
532652 - PrintingControllerTest#testPrintClosedWindow
605944 - ContentViewZoomingTest#testJoystickZoomOut
Project Member

Comment 10 by chromium...@appspot.gserviceaccount.com, Apr 23 2016

Labels: Sheriff-Chromium
Detected 7 new flakes for test/step "content_shell_test_apk (with patch)". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyLgsSBUZsYWtlIiNjb250ZW50X3NoZWxsX3Rlc3RfYXBrICh3aXRoIHBhdGNoKQw. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).

Comment 11 by treib@chromium.org, Apr 25 2016

Labels: -Sheriff-Chromium
Removing Chrome sheriff label as this already has an owner.

Comment 12 by treib@chromium.org, Apr 25 2016

 Issue 606120  has been merged into this issue.
Project Member

Comment 13 by bugdroid1@chromium.org, Apr 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/75f1acb7364bcd6faed4bb241ce0e6879910f1b4

commit 75f1acb7364bcd6faed4bb241ce0e6879910f1b4
Author: dgn <dgn@chromium.org>
Date: Mon Apr 25 13:18:15 2016

Mark ImeTest#testImeCut and ImeTest#testImeCopy flaky

Many flakes on those tests have been observed, on the
waterfall and on the trybots.

BUG= 603991 , 598482 
TBR=aelias@chromium.org

Review URL: https://codereview.chromium.org/1916783002

Cr-Commit-Position: refs/heads/master@{#389461}

[modify] https://crrev.com/75f1acb7364bcd6faed4bb241ce0e6879910f1b4/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java

Project Member

Comment 14 by bugdroid1@chromium.org, Apr 25 2016

Labels: merge-merged-2716
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/75f1acb7364bcd6faed4bb241ce0e6879910f1b4

commit 75f1acb7364bcd6faed4bb241ce0e6879910f1b4
Author: dgn <dgn@chromium.org>
Date: Mon Apr 25 13:18:15 2016

Mark ImeTest#testImeCut and ImeTest#testImeCopy flaky

Many flakes on those tests have been observed, on the
waterfall and on the trybots.

BUG= 603991 , 598482 
TBR=aelias@chromium.org

Review URL: https://codereview.chromium.org/1916783002

Cr-Commit-Position: refs/heads/master@{#389461}

[modify] https://crrev.com/75f1acb7364bcd6faed4bb241ce0e6879910f1b4/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java

Project Member

Comment 15 by chromium...@appspot.gserviceaccount.com, May 3 2016

Labels: Sheriff-Chromium
Detected 4 new flakes for test/step "content_shell_test_apk (with patch)". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyLgsSBUZsYWtlIiNjb250ZW50X3NoZWxsX3Rlc3RfYXBrICh3aXRoIHBhdGNoKQw. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
Removing Sheriff-Chromium again. Still seems flaky.
Labels: -Sheriff-Chromium
Cc: changwan@chromium.org
Owner: yabinh@chromium.org
Project Member

Comment 19 by chromium...@appspot.gserviceaccount.com, Jun 4 2016

Detected 3 new flakes for test/step "content_shell_test_apk (with patch)". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyLgsSBUZsYWtlIiNjb250ZW50X3NoZWxsX3Rlc3RfYXBrICh3aXRoIHBhdGNoKQw. This message was posted automatically by the chromium-try-flakes app.
Project Member

Comment 20 by chromium...@appspot.gserviceaccount.com, Jun 6 2016

Detected 3 new flakes for test/step "content_shell_test_apk (with patch)". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyLgsSBUZsYWtlIiNjb250ZW50X3NoZWxsX3Rlc3RfYXBrICh3aXRoIHBhdGNoKQw. This message was posted automatically by the chromium-try-flakes app.
Project Member

Comment 21 by chromium...@appspot.gserviceaccount.com, Jun 7 2016

Detected 3 new flakes for test/step "content_shell_test_apk (with patch)". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyLgsSBUZsYWtlIiNjb250ZW50X3NoZWxsX3Rlc3RfYXBrICh3aXRoIHBhdGNoKQw. This message was posted automatically by the chromium-try-flakes app.
Project Member

Comment 22 by chromium...@appspot.gserviceaccount.com, Jun 8 2016

Detected 4 new flakes for test/step "content_shell_test_apk (with patch)". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyLgsSBUZsYWtlIiNjb250ZW50X3NoZWxsX3Rlc3RfYXBrICh3aXRoIHBhdGNoKQw. This message was posted automatically by the chromium-try-flakes app.

Comment 23 by dgn@chromium.org, Jun 8 2016

Cc: -dgn@chromium.org
Mergedinto: 598482
Status: Duplicate (was: Assigned)
Status: Assigned (was: Duplicate)
Project Member

Comment 26 by bugdroid1@chromium.org, Jun 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f23392b1f1f2b91909f646bc5ddf54c2c4003a6

commit 6f23392b1f1f2b91909f646bc5ddf54c2c4003a6
Author: yabinh <yabinh@chromium.org>
Date: Thu Jun 16 07:09:45 2016

There are 6 flaky tests in ImeTest. They are flaky because when we call
InputConnection#setSelection and other methods together, the order of messages
sometimes does not get kept.

We can solve this by enabling IME thread, because when IME thead is on,
the order can be kept.

Another way is applying the following patch, which deals with the re-ordering
issue: https://codereview.chromium.org/1877073003/. Since the patch has been
landed, we can remove the @FlakyTest annotations.

BUG= 598482 ,  603991 

Review-Url: https://codereview.chromium.org/2058633004
Cr-Commit-Position: refs/heads/master@{#400099}

[modify] https://crrev.com/6f23392b1f1f2b91909f646bc5ddf54c2c4003a6/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java

Project Member

Comment 27 by bugdroid1@chromium.org, Jun 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/186c15876ee97b4d0be6302c0635814c873448f5

commit 186c15876ee97b4d0be6302c0635814c873448f5
Author: grunell <grunell@chromium.org>
Date: Thu Jun 16 14:21:14 2016

Revert of Remove  all the @FlakyTest annotations in ImeTest (patchset #2 id:20001 of https://codereview.chromium.org/2058633004/ )

Reason for revert:
Flaky failure seen in

https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/34878

Original issue's description:
> There are 6 flaky tests in ImeTest. They are flaky because when we call
> InputConnection#setSelection and other methods together, the order of messages
> sometimes does not get kept.
>
> We can solve this by enabling IME thread, because when IME thead is on,
> the order can be kept.
>
> Another way is applying the following patch, which deals with the re-ordering
> issue: https://codereview.chromium.org/1877073003/. Since the patch has been
> landed, we can remove the @FlakyTest annotations.
>
> BUG= 598482 ,  603991 
>
> Committed: https://crrev.com/6f23392b1f1f2b91909f646bc5ddf54c2c4003a6
> Cr-Commit-Position: refs/heads/master@{#400099}

TBR=changwan@chromium.org,yabinh@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 598482 ,  603991 

Review-Url: https://codereview.chromium.org/2070083003
Cr-Commit-Position: refs/heads/master@{#400151}

[modify] https://crrev.com/186c15876ee97b4d0be6302c0635814c873448f5/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java

Project Member

Comment 28 by bugdroid1@chromium.org, Jun 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f667465a379f9d74f97590399fe7aff97e7a637b

commit f667465a379f9d74f97590399fe7aff97e7a637b
Author: yabinh <yabinh@chromium.org>
Date: Fri Jun 17 07:09:16 2016

Remove all the @FlakyTest annotations in ImeTest & fix another flaky test

The CL
https://codereview.chromium.org/2058633004/
was reverted because another CL is flaky:
https://codereview.chromium.org/2033723003/

There is race condition in the latter CL. Firstly, we copy some text
(running on UI thread), then we copy other text (running on test thread).
At last we paste the text. But we are not sure which text is in the
clipboard because of race condition. We can fix this by not copying the
former text, because it is not necessary originally. After fixing it,
we can remove the @FlakyTest annotations safely.

BUG= 598482 ,  603991 

Review-Url: https://codereview.chromium.org/2076853002
Cr-Commit-Position: refs/heads/master@{#400386}

[modify] https://crrev.com/f667465a379f9d74f97590399fe7aff97e7a637b/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java

Project Member

Comment 29 by bugdroid1@chromium.org, Dec 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3fe81c87f6e16071f9b3b3ca9d57d023b58cbb6

commit c3fe81c87f6e16071f9b3b3ca9d57d023b58cbb6
Author: yabinh <yabinh@chromium.org>
Date: Wed Dec 28 07:43:12 2016

Remove @RetryOnFailure in IME test

A lot of IME tests were flaky and marked with @RetryOnFailure. Now they
are (almost) all deflaked, so we don't need @RetryOnFailure any more.

BUG= 628964 , 603991 

Review-Url: https://codereview.chromium.org/2607723002
Cr-Commit-Position: refs/heads/master@{#440836}

[modify] https://crrev.com/c3fe81c87f6e16071f9b3b3ca9d57d023b58cbb6/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java

Status: Fixed (was: Assigned)
Flaky IME tests were (nearly) all fixed. See http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&testType=content_shell_test_apk&tests=imetest

ContentViewZoomingTest#testJoystickZoomOut is not flaky anymore. See http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&testType=content_shell_test_apk&tests=testJoystickZoomOut

PrintingControllerTest#testPrintClosedWindow was disabled, but we have issue 532652 to track that.
Cc: dgn@chromium.org
cc the owner of issue 532652 

Sign in to add a comment