Limit number of snippets to 10 |
|||||||||||||
Issue descriptionChrom version Dev 51.0.2704.5 I manually turned on the about:flags experiments for both snippets and popular sites. When I go to the NTP, I see well over 20 different snippets, which means that as I scroll down I can go pretty far down indeed. Please let me know if there's any other info from the browser I can provide.
,
Apr 18 2016
Nope, they're all from within 24 hours.
,
Apr 19 2016
I don't think we restrict the number of snippets at all. Should we?
,
Apr 19 2016
The PRD (go/zine-snippets) specifies a limit of 10 snippets in total. Let's start with that.
,
Apr 19 2016
Feel free to re-assign.
,
Apr 19 2016
CCing some folks who might want to take this. Unassigning myself for now, since I won't get to it this week. We haven't really decided which snippets to keep if we get more than 10 total. (We restrict the max number to 10 per fetch, but we typically re-fetch before the snippets have expired.) Options: - Keep those with the best scores (provided by ChromeReader, but we don't store it yet). - Keep those with the newest creation dates. - Keep those we fetched last (this more or less corresponds to the proposed snippet ordering in bug 601736 , but IMO doesn't really make a lot of sense). - Some combination of the above. Whatever we do, it should probably be consistent with the snippet ordering, i.e. always keep the first 10.
,
Apr 19 2016
,
Apr 20 2016
I'll take this one, since it'll mostly boil down to bug 601736 .
,
Apr 22 2016
Agreed, irrespective of the ordering use when snippets are added, we should always make sure that we remove snippets from the end of the list to limit the number of snippets to 10.
,
Apr 22 2016
,
Apr 22 2016
,
Apr 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d3b0ca6ced3cddc24ef59a1c2702d2a846664294 commit d3b0ca6ced3cddc24ef59a1c2702d2a846664294 Author: treib <treib@chromium.org> Date: Mon Apr 25 13:35:24 2016 [NTP Snippets] Limit the number of snippets to 10 BUG= 603986 Review URL: https://codereview.chromium.org/1922463002 Cr-Commit-Position: refs/heads/master@{#389464} [modify] https://crrev.com/d3b0ca6ced3cddc24ef59a1c2702d2a846664294/components/ntp_snippets/ntp_snippets_fetcher.cc [modify] https://crrev.com/d3b0ca6ced3cddc24ef59a1c2702d2a846664294/components/ntp_snippets/ntp_snippets_fetcher.h [modify] https://crrev.com/d3b0ca6ced3cddc24ef59a1c2702d2a846664294/components/ntp_snippets/ntp_snippets_service.cc [modify] https://crrev.com/d3b0ca6ced3cddc24ef59a1c2702d2a846664294/components/ntp_snippets/ntp_snippets_service.h [modify] https://crrev.com/d3b0ca6ced3cddc24ef59a1c2702d2a846664294/components/ntp_snippets/ntp_snippets_service_unittest.cc
,
Apr 25 2016
,
Apr 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d3b0ca6ced3cddc24ef59a1c2702d2a846664294 commit d3b0ca6ced3cddc24ef59a1c2702d2a846664294 Author: treib <treib@chromium.org> Date: Mon Apr 25 13:35:24 2016 [NTP Snippets] Limit the number of snippets to 10 BUG= 603986 Review URL: https://codereview.chromium.org/1922463002 Cr-Commit-Position: refs/heads/master@{#389464} [modify] https://crrev.com/d3b0ca6ced3cddc24ef59a1c2702d2a846664294/components/ntp_snippets/ntp_snippets_fetcher.cc [modify] https://crrev.com/d3b0ca6ced3cddc24ef59a1c2702d2a846664294/components/ntp_snippets/ntp_snippets_fetcher.h [modify] https://crrev.com/d3b0ca6ced3cddc24ef59a1c2702d2a846664294/components/ntp_snippets/ntp_snippets_service.cc [modify] https://crrev.com/d3b0ca6ced3cddc24ef59a1c2702d2a846664294/components/ntp_snippets/ntp_snippets_service.h [modify] https://crrev.com/d3b0ca6ced3cddc24ef59a1c2702d2a846664294/components/ntp_snippets/ntp_snippets_service_unittest.cc
,
Jul 1 2016
,
Jul 1 2016
,
Jul 1 2016
|
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by fi...@chromium.org
, Apr 18 2016Status: Available (was: Untriaged)