New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 603984 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Apr 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature

Blocking:
issue 586317



Sign in to add a comment

Convert the writable stateful file system check to a Verifier

Reported by jrbarnette@chromium.org, Apr 15 2016

Issue description

CrosHost.verify_software() contains the following call:
        self.verify_filesystem_write_status()

That method does this:
        filename = "/mnt/stateful_partition/test.txt"
        cmd = 'touch %s && rm %s' % (filename, filename)
        rv = self.run(command=cmd, ignore_status=True)

        if rv.exit_status == 1:
            raise error.AutoservError('DUT filesystem is read-only.')

The purpose of the check is to detect cases where a Linux error
(especially, a block device hardware error) has changed the file
system status to read-only.

This code needs to be moved out of verify_software() and converted
to a standard verifier.

 
Blocking: 586317
Owner: jrbarnette@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/38d19825f897dc6201d0d68ed266fa9f5ced779e

commit 38d19825f897dc6201d0d68ed266fa9f5ced779e
Author: Richard Barnette <jrbarnette@chromium.org>
Date: Fri Apr 15 19:48:54 2016

[autotest] Convert the check for a writable stateful into a verifier.

Verification includes a check that the stateful partition is
writable, in order to detect certain file system errors.
This move that verification check from CrosHost.verify_software()
into a standalone Verifier.

BUG= chromium:603984 
TEST=Run verify against a DUT in a local instance

Change-Id: Iaa0e358d67d7c96fa2640a059a2313746630ef8d
Reviewed-on: https://chromium-review.googlesource.com/339272
Commit-Ready: Richard Barnette <jrbarnette@chromium.org>
Tested-by: Richard Barnette <jrbarnette@chromium.org>
Reviewed-by: Dan Shi <dshi@google.com>

[modify] https://crrev.com/38d19825f897dc6201d0d68ed266fa9f5ced779e/server/hosts/cros_host.py
[modify] https://crrev.com/38d19825f897dc6201d0d68ed266fa9f5ced779e/server/hosts/cros_repair.py

Status: Fixed (was: Started)

Comment 5 by benhenry@google.com, Apr 27 2016

Components: Infra>Client>ChromeOS
Labels: -Infra-ChromeOS
Bulk verified
Status: Verified (was: Fixed)
bulk verified

Sign in to add a comment