Now that the update_client is reporting roll-call data, it should report ping_freshness so that an update server can deduplicate roll calls from cloned machines. See https://github.com/google/omaha/blob/wiki/ServerProtocolV3.md#unreliable-client-storage for background
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e7dff73db0785613c1bd68c9909f6ebe6a9c07e5 commit e7dff73db0785613c1bd68c9909f6ebe6a9c07e5 Author: waffles <waffles@chromium.org> Date: Fri Apr 15 23:51:49 2016 Implement ping_freshness for update_client. BUG= 603980 Review URL: https://codereview.chromium.org/1889263002 Cr-Commit-Position: refs/heads/master@{#387754} [modify] https://crrev.com/e7dff73db0785613c1bd68c9909f6ebe6a9c07e5/components/update_client/persisted_data.cc [modify] https://crrev.com/e7dff73db0785613c1bd68c9909f6ebe6a9c07e5/components/update_client/persisted_data.h [modify] https://crrev.com/e7dff73db0785613c1bd68c9909f6ebe6a9c07e5/components/update_client/persisted_data_unittest.cc [modify] https://crrev.com/e7dff73db0785613c1bd68c9909f6ebe6a9c07e5/components/update_client/update_checker.cc [modify] https://crrev.com/e7dff73db0785613c1bd68c9909f6ebe6a9c07e5/components/update_client/update_checker.h [modify] https://crrev.com/e7dff73db0785613c1bd68c9909f6ebe6a9c07e5/components/update_client/update_checker_unittest.cc [modify] https://crrev.com/e7dff73db0785613c1bd68c9909f6ebe6a9c07e5/components/update_client/update_client_unittest.cc [modify] https://crrev.com/e7dff73db0785613c1bd68c9909f6ebe6a9c07e5/components/update_client/update_engine.cc
Requesting merge to 51; this is a follow-on change to issue 590291 to increase the reliability of the metrics in the presence of highly duplicated machine images.
Your change meets the bar and is auto-approved for M51 (branch: 2704)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c247ad4f2c31fe8ab2fd568c610eaf414243d7af commit c247ad4f2c31fe8ab2fd568c610eaf414243d7af Author: Joshua Pawlicki <waffles@google.com> Date: Mon Apr 18 23:11:30 2016 Implement ping_freshness for update_client. BUG= 603980 Review URL: https://codereview.chromium.org/1889263002 Cr-Commit-Position: refs/heads/master@{#387754} (cherry picked from commit e7dff73db0785613c1bd68c9909f6ebe6a9c07e5) Review URL: https://codereview.chromium.org/1899043002 . Cr-Commit-Position: refs/branch-heads/2704@{#116} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} [modify] https://crrev.com/c247ad4f2c31fe8ab2fd568c610eaf414243d7af/components/update_client/persisted_data.cc [modify] https://crrev.com/c247ad4f2c31fe8ab2fd568c610eaf414243d7af/components/update_client/persisted_data.h [modify] https://crrev.com/c247ad4f2c31fe8ab2fd568c610eaf414243d7af/components/update_client/persisted_data_unittest.cc [modify] https://crrev.com/c247ad4f2c31fe8ab2fd568c610eaf414243d7af/components/update_client/update_checker.cc [modify] https://crrev.com/c247ad4f2c31fe8ab2fd568c610eaf414243d7af/components/update_client/update_checker.h [modify] https://crrev.com/c247ad4f2c31fe8ab2fd568c610eaf414243d7af/components/update_client/update_checker_unittest.cc [modify] https://crrev.com/c247ad4f2c31fe8ab2fd568c610eaf414243d7af/components/update_client/update_client_unittest.cc [modify] https://crrev.com/c247ad4f2c31fe8ab2fd568c610eaf414243d7af/components/update_client/update_engine.cc
Comment 1 by bugdroid1@chromium.org
, Apr 15 2016