New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 603976 link

Starred by 5 users

Issue metadata

Status: Verified
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 602896



Sign in to add a comment

In CrOS settings, replace <paper-item> with <button class="paper-input" role="option">

Project Member Reported by michae...@chromium.org, Apr 15 2016

Issue description

Replace <paper-item>, <paper-icon-item>, and <paper-item-body> with styles buttons -- they are significantly faster with no loss of functionality.

See https://github.com/PolymerElements/paper-item/releases/tag/v1.2.0
 
I will start by doing this for chrome://md-settings.
Labels: Hotlist-MD-Settings-General
Status: Assigned (was: Started)
blocked on https://github.com/PolymerElements/paper-item/issues/85
Cc: dschuyler@chromium.org michae...@chromium.org dpa...@chromium.org
Owner: ----
Status: Available (was: Assigned)
In Settings, the remaining <paper-item> uses are:

* site settings
* CUPS printers
* bluetooth list

Should be straightforward to replace them with buttons, but may also involve dealing with <iron-dropdown>s.
Cc: scottchen@chromium.org
Owner: scottchen@chromium.org
Status: Started (was: Available)
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d273cd75ba1d15a782fd06677560bf54fade3f2

commit 6d273cd75ba1d15a782fd06677560bf54fade3f2
Author: scottchen <scottchen@chromium.org>
Date: Thu Nov 10 21:37:56 2016

change site-settings -> usb-device to use cr-action-menu instead of paper-menu

This CL is part of the effort to move off of paper-item which is known to have performance issues.
Note for future improvement: dpapad@ and I noticed that there's only a remove button in the dropdown menu, so we can probably replace it with just an "X" button.

BUG= 603976 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2480843003
Cr-Commit-Position: refs/heads/master@{#431362}

[modify] https://crrev.com/6d273cd75ba1d15a782fd06677560bf54fade3f2/chrome/browser/resources/settings/site_settings/compiled_resources2.gyp
[modify] https://crrev.com/6d273cd75ba1d15a782fd06677560bf54fade3f2/chrome/browser/resources/settings/site_settings/usb_devices.html
[modify] https://crrev.com/6d273cd75ba1d15a782fd06677560bf54fade3f2/chrome/browser/resources/settings/site_settings/usb_devices.js
[modify] https://crrev.com/6d273cd75ba1d15a782fd06677560bf54fade3f2/chrome/test/data/webui/settings/cr_settings_browsertest.js
[modify] https://crrev.com/6d273cd75ba1d15a782fd06677560bf54fade3f2/chrome/test/data/webui/settings/test_site_settings_prefs_browser_proxy.js
[add] https://crrev.com/6d273cd75ba1d15a782fd06677560bf54fade3f2/chrome/test/data/webui/settings/usb_devices_tests.js

Project Member

Comment 9 by bugdroid1@chromium.org, Nov 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dcb5fc9af2549a795edf7e67d596e261364a948b

commit dcb5fc9af2549a795edf7e67d596e261364a948b
Author: scottchen <scottchen@chromium.org>
Date: Tue Nov 15 01:46:06 2016

Make setting's protocol handler use cr-action-menu instead of paper-item.

BUG= 603976 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2500513003
Cr-Commit-Position: refs/heads/master@{#432048}

[modify] https://crrev.com/dcb5fc9af2549a795edf7e67d596e261364a948b/chrome/browser/resources/settings/site_settings/compiled_resources2.gyp
[modify] https://crrev.com/dcb5fc9af2549a795edf7e67d596e261364a948b/chrome/browser/resources/settings/site_settings/protocol_handlers.html
[modify] https://crrev.com/dcb5fc9af2549a795edf7e67d596e261364a948b/chrome/browser/resources/settings/site_settings/protocol_handlers.js
[modify] https://crrev.com/dcb5fc9af2549a795edf7e67d596e261364a948b/chrome/browser/resources/settings/site_settings/usb_devices.html
[modify] https://crrev.com/dcb5fc9af2549a795edf7e67d596e261364a948b/chrome/test/data/webui/settings/cr_settings_browsertest.js
[add] https://crrev.com/dcb5fc9af2549a795edf7e67d596e261364a948b/chrome/test/data/webui/settings/protocol_handlers_tests.js
[modify] https://crrev.com/dcb5fc9af2549a795edf7e67d596e261364a948b/chrome/test/data/webui/settings/test_site_settings_prefs_browser_proxy.js
[modify] https://crrev.com/dcb5fc9af2549a795edf7e67d596e261364a948b/chrome/test/data/webui/settings/usb_devices_tests.js

Project Member

Comment 10 by bugdroid1@chromium.org, Nov 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2507bc013bac421e3775d7119322aced956b633a

commit 2507bc013bac421e3775d7119322aced956b633a
Author: scottchen <scottchen@chromium.org>
Date: Fri Nov 18 20:11:32 2016

remove unnecessary paper-item dependency from site_details.

We're trying to remove all paper-item dependency for performance reasons, and a div with list-item class can achieve the desired visual effects and seems more suitable. I also removed the hidden attribute because its parent element has the exact same hidden condition, so seems redundant to have both.

BUG= 603976 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2512613003
Cr-Commit-Position: refs/heads/master@{#433278}

[modify] https://crrev.com/2507bc013bac421e3775d7119322aced956b633a/chrome/browser/resources/settings/site_settings/site_details.html
[modify] https://crrev.com/2507bc013bac421e3775d7119322aced956b633a/chrome/test/data/webui/settings/site_details_tests.js

Owner: ----
Status: Available (was: Started)
I've removed paper-item dependency from
- site_details
- usb_devices
- protocol_handlers

The rest of paper-item usage are in chromeos code, and I currently don't have the machine to build chromeOS yet, so anyone feel free to pick this up.
Labels: OS-Chrome
Marking as Chrome OS-only.
Summary: In CrOS settings, replace <paper-item> with <button class="paper-input" role="option"> (was: Material WebUI: replace <paper-item> with <button class="paper-input" role="option">)
Components: -UI>Browser>History
MD History doesn't use paper-item anymore, so I'm removing the History component
Labels: M-58
Owner: steve...@chromium.org
Status: Assigned (was: Available)
Owner: x...@chromium.org
xdai@ - The remaining paper-item is in cups_add_printer_dialog_util.html:

https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.html?q=paper-item+file:%5Esrc/chrome/browser/resources/settings/printing_page/&sq=package:chromium&l=31&dr=C

Could you remove this sometime during the 58 cycle? We'd like to eliminate paper-item before shipping.

Comment 17 by x...@chromium.org, Jan 24 2017

Sure
Project Member

Comment 18 by bugdroid1@chromium.org, Feb 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6477751a2c1a2c3fba3ba77917efd51f48b0e2ab

commit 6477751a2c1a2c3fba3ba77917efd51f48b0e2ab
Author: dpapad <dpapad@chromium.org>
Date: Tue Feb 07 03:18:37 2017

MD Settings: Remove last usage of paper-item.

 - Replace <paper-item> usage with a styled <button>.
 - Remove all references to paper-item shared style files.
 - Move iron-dropdown rules to cups_add_printer_dialog_util.html, since
   it has the only usage of iron-dropdown.

BUG= 603976 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2677863004
Cr-Commit-Position: refs/heads/master@{#448534}

[modify] https://crrev.com/6477751a2c1a2c3fba3ba77917efd51f48b0e2ab/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.html
[modify] https://crrev.com/6477751a2c1a2c3fba3ba77917efd51f48b0e2ab/chrome/browser/resources/settings/settings_shared_css.html
[modify] https://crrev.com/6477751a2c1a2c3fba3ba77917efd51f48b0e2ab/chrome/browser/resources/settings/settings_vars_css.html

Comment 19 by x...@chromium.org, Feb 15 2017

Status: Fixed (was: Assigned)
Close this since the last usage of paper-item was removed in #18.
Status: Verified (was: Fixed)

Sign in to add a comment