New issue
Advanced search Search tips

Issue 603972 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

git cl diff broken?

Project Member Reported by martiniss@chromium.org, Apr 15 2016

Issue description

When I run git cl diff, I see the following:

$ g cl diff                                                                                                 [±test_internal_changes_cl ✓▴]
Traceback (most recent call last):
  File "/usr/local/google/home/martiniss/depot_tools/git_cl.py", line 4626, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/usr/local/google/home/martiniss/depot_tools/git_cl.py", line 4608, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/usr/local/google/home/martiniss/depot_tools/subcommand.py", line 252, in execute
    return command(parser, args[1:])
  File "/usr/local/google/home/martiniss/depot_tools/git_cl.py", line 4320, in CMDdiff
    rtn = cl.CMDPatchIssue(issue, reject=False, nocommit=False, directory=None)
  File "/usr/local/google/home/martiniss/depot_tools/git_cl.py", line 1300, in CMDPatchIssue
    if issue_arg.isdigit():
AttributeError: 'int' object has no attribute 'isdigit'


This is only for branches with an issue associated with it.
 
Labels: -Infra Infra-SDK
Owner: tandrii@chromium.org
Gerrit or Reitveld? Assigning to tandrii@ who's done some work on git_cl recently.
Rietveld.
Status: WontFix (was: Untriaged)
since depot_tools isn't pinned, tell me you revision.
  cd $(dirname `which gclient`); git rev-parse HEAD

However, I'm 99% sure that it was a bug I fixed 1 week ago. So, after that do:
  gclient

and then retry
  git cl diff

Comment 4 by aga...@chromium.org, Apr 26 2016

Components: Infra>SDK
Labels: -Infra-SDK

Sign in to add a comment