New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 603970 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug

Blocking:
issue 429053



Sign in to add a comment

Emulate TEXTURE_IMMUTABLE_LEVELS on MacOSX

Project Member Reported by zmo@chromium.org, Apr 15 2016

Issue description

Even with ARB_texture_storage extension, the enum TEXTURE_IMMUTABLE_LEVELS for GetTexParameter{i|f}v is still missing and needs to be emulated.

Also, on MacOSX, if TEXTURE_MAX_LEVEL or TEXTURE_BASE_LEVEL is set >= 32768 (2^15), then when queried through GetTexParameter, it returns negative values.
 

Comment 1 by zmo@chromium.org, Apr 15 2016

Per offline discussion with kbr, we are going to add a limit in WebGL for TEXTURE_BASE_LEVEL and TEXTURE_MAX_LEVEL to be < 32768.
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ae9c1908988efd11714c852206d7f0b772888363

commit ae9c1908988efd11714c852206d7f0b772888363
Author: zmo <zmo@chromium.org>
Date: Fri Apr 15 19:56:19 2016

Emulate TEXTURE_IMMUTABLE_LEVELS on GL lower than 4.2

BUG= 603970 
TEST=webgl2 conformance, gpu_unittests
R=piman@chromium.org,kbr@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review URL: https://codereview.chromium.org/1883273004

Cr-Commit-Position: refs/heads/master@{#387680}

[modify] https://crrev.com/ae9c1908988efd11714c852206d7f0b772888363/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
[modify] https://crrev.com/ae9c1908988efd11714c852206d7f0b772888363/gpu/command_buffer/service/gles2_cmd_decoder.cc
[modify] https://crrev.com/ae9c1908988efd11714c852206d7f0b772888363/gpu/command_buffer/service/texture_manager.cc
[modify] https://crrev.com/ae9c1908988efd11714c852206d7f0b772888363/gpu/command_buffer/service/texture_manager.h

Comment 3 by zmo@chromium.org, Apr 15 2016

Blocking: 429053
Labels: OS-Mac

Comment 4 by zmo@chromium.org, Apr 15 2016

Components: Internals>GPU>VendorSpecific

Comment 5 by zmo@chromium.org, Nov 8 2016

Status: Fixed (was: Assigned)

Sign in to add a comment