Provide currently_committed_url to PageLoadMetricsObservers |
|||||
Issue descriptionProvide currently_committed_url to PageLoadMetricsObservers This allows us to track metrics based on where the user is navigating from. A referer can be used to accomplish this in some cases, though referers are not always available or may be sanitized to include only the origin in some cases. This is needed to improve our existing FromGWS metrics.
,
Apr 16 2016
,
Apr 16 2016
,
Apr 16 2016
Your change meets the bar and is auto-approved for M51 (branch: 2704)
,
Apr 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0c2396d866a38f3f3a25f46c332d56cf4c69d67e commit 0c2396d866a38f3f3a25f46c332d56cf4c69d67e Author: Josh Karlin <jkarlin@chromium.org> Date: Wed Apr 20 13:38:34 2016 Provide currently_committed_url to PageLoadMetricsObservers This allows us to track metrics based on where the user is navigating from. A referer can be used to accomplish this in some cases, though referers are not always available or may be sanitized to include only the origin in some cases. BUG= 603948 Review URL: https://codereview.chromium.org/1879413002 Cr-Commit-Position: refs/heads/master@{#387649} (cherry picked from commit 003fade38f4d89100f517a6469abeb84cd9db165) Review URL: https://codereview.chromium.org/1900343003 . Cr-Commit-Position: refs/branch-heads/2704@{#144} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} [modify] https://crrev.com/0c2396d866a38f3f3a25f46c332d56cf4c69d67e/components/page_load_metrics/browser/metrics_web_contents_observer.cc [modify] https://crrev.com/0c2396d866a38f3f3a25f46c332d56cf4c69d67e/components/page_load_metrics/browser/metrics_web_contents_observer.h [modify] https://crrev.com/0c2396d866a38f3f3a25f46c332d56cf4c69d67e/components/page_load_metrics/browser/metrics_web_contents_observer_unittest.cc [modify] https://crrev.com/0c2396d866a38f3f3a25f46c332d56cf4c69d67e/components/page_load_metrics/browser/page_load_metrics_observer.h |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Apr 15 2016