New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 603948 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Provide currently_committed_url to PageLoadMetricsObservers

Project Member Reported by bmcquade@chromium.org, Apr 15 2016

Issue description

Provide currently_committed_url to PageLoadMetricsObservers

This allows us to track metrics based on where the user is navigating from.
A referer can be used to accomplish this in some cases, though referers
are not always available or may be sanitized to include only the origin
in some cases.

This is needed to improve our existing FromGWS metrics.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/003fade38f4d89100f517a6469abeb84cd9db165

commit 003fade38f4d89100f517a6469abeb84cd9db165
Author: bmcquade <bmcquade@chromium.org>
Date: Fri Apr 15 18:21:43 2016

Provide currently_committed_url to PageLoadMetricsObservers

This allows us to track metrics based on where the user is navigating from.
A referer can be used to accomplish this in some cases, though referers
are not always available or may be sanitized to include only the origin
in some cases.

BUG= 603948 

Review URL: https://codereview.chromium.org/1879413002

Cr-Commit-Position: refs/heads/master@{#387649}

[modify] https://crrev.com/003fade38f4d89100f517a6469abeb84cd9db165/components/page_load_metrics/browser/metrics_web_contents_observer.cc
[modify] https://crrev.com/003fade38f4d89100f517a6469abeb84cd9db165/components/page_load_metrics/browser/metrics_web_contents_observer.h
[modify] https://crrev.com/003fade38f4d89100f517a6469abeb84cd9db165/components/page_load_metrics/browser/metrics_web_contents_observer_unittest.cc
[modify] https://crrev.com/003fade38f4d89100f517a6469abeb84cd9db165/components/page_load_metrics/browser/page_load_metrics_observer.h

Status: Fixed (was: Assigned)
Labels: Merge-Request-51

Comment 4 by tin...@google.com, Apr 16 2016

Labels: -Merge-Request-51 Merge-Approved-51 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M51 (branch: 2704)
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 20 2016

Labels: -merge-approved-51 merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c2396d866a38f3f3a25f46c332d56cf4c69d67e

commit 0c2396d866a38f3f3a25f46c332d56cf4c69d67e
Author: Josh Karlin <jkarlin@chromium.org>
Date: Wed Apr 20 13:38:34 2016

Provide currently_committed_url to PageLoadMetricsObservers

This allows us to track metrics based on where the user is navigating from.
A referer can be used to accomplish this in some cases, though referers
are not always available or may be sanitized to include only the origin
in some cases.

BUG= 603948 

Review URL: https://codereview.chromium.org/1879413002

Cr-Commit-Position: refs/heads/master@{#387649}
(cherry picked from commit 003fade38f4d89100f517a6469abeb84cd9db165)

Review URL: https://codereview.chromium.org/1900343003 .

Cr-Commit-Position: refs/branch-heads/2704@{#144}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/0c2396d866a38f3f3a25f46c332d56cf4c69d67e/components/page_load_metrics/browser/metrics_web_contents_observer.cc
[modify] https://crrev.com/0c2396d866a38f3f3a25f46c332d56cf4c69d67e/components/page_load_metrics/browser/metrics_web_contents_observer.h
[modify] https://crrev.com/0c2396d866a38f3f3a25f46c332d56cf4c69d67e/components/page_load_metrics/browser/metrics_web_contents_observer_unittest.cc
[modify] https://crrev.com/0c2396d866a38f3f3a25f46c332d56cf4c69d67e/components/page_load_metrics/browser/page_load_metrics_observer.h

Sign in to add a comment