New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 603944 link

Starred by 3 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 602151



Sign in to add a comment

chromite/third_party/requests license check failures

Project Member Reported by steve...@chromium.org, Apr 15 2016

Issue description

chromite is included in chrome/src/third_party

When running:

src/tools/checklicenses/checklicenses.py

The following errors occur:

'third_party/chromite/third_party/requests/structures.py' has non-whitelisted license 'UNKNOWN'
'third_party/chromite/third_party/requests/status_codes.py' has non-whitelisted license 'UNKNOWN'
'third_party/chromite/third_party/requests/cookies.py' has non-whitelisted license 'UNKNOWN'
'third_party/chromite/third_party/requests/models.py' has non-whitelisted license 'UNKNOWN'
'third_party/chromite/third_party/requests/compat.py' has non-whitelisted license 'UNKNOWN'
'third_party/chromite/third_party/requests/auth.py' has non-whitelisted license 'UNKNOWN'
'third_party/chromite/third_party/requests/exceptions.py' has non-whitelisted license 'UNKNOWN'
'third_party/chromite/third_party/requests/utils.py' has non-whitelisted license 'UNKNOWN'
'third_party/chromite/third_party/requests/certs.py' has non-whitelisted license 'UNKNOWN'
'third_party/chromite/third_party/requests/packages/urllib3/contrib/pyopenssl.py' has non-whitelisted license 'UNKNOWN'
'third_party/chromite/third_party/requests/packages/urllib3/contrib/appengine.py' has non-whitelisted license 'UNKNOWN'
'third_party/chromite/third_party/requests/packages/urllib3/contrib/ntlmpool.py' has non-whitelisted license 'UNKNOWN'
'third_party/chromite/third_party/requests/packages/urllib3/request.py' has non-whitelisted license 'UNKNOWN'
'third_party/chromite/third_party/requests/packages/urllib3/fields.py' has non-whitelisted license 'UNKNOWN'
'third_party/chromite/third_party/requests/packages/urllib3/filepost.py' has non-whitelisted license 'UNKNOWN'
'third_party/chromite/third_party/requests/packages/urllib3/_collections.py' has non-whitelisted license 'UNKNOWN'
'third_party/chromite/third_party/requests/packages/urllib3/exceptions.py' has non-whitelisted license 'UNKNOWN'
'third_party/chromite/third_party/requests/packages/urllib3/poolmanager.py' has non-whitelisted license 'UNKNOWN'
'third_party/chromite/third_party/requests/packages/urllib3/connectionpool.py' has non-whitelisted license 'UNKNOWN'
'third_party/chromite/third_party/requests/packages/urllib3/connection.py' has non-whitelisted license 'UNKNOWN'
'third_party/chromite/third_party/requests/packages/urllib3/util/retry.py' has non-whitelisted license 'UNKNOWN'
'third_party/chromite/third_party/requests/packages/urllib3/util/request.py' has non-whitelisted license 'UNKNOWN'
'third_party/chromite/third_party/requests/packages/urllib3/util/response.py' has non-whitelisted license 'UNKNOWN'
'third_party/chromite/third_party/requests/packages/urllib3/util/ssl_.py' has non-whitelisted license 'UNKNOWN'
'third_party/chromite/third_party/requests/packages/urllib3/util/connection.py' has non-whitelisted license 'UNKNOWN'
'third_party/chromite/third_party/requests/packages/urllib3/util/__init__.py' has non-whitelisted license 'UNKNOWN'
'third_party/chromite/third_party/requests/packages/urllib3/util/timeout.py' has non-whitelisted license 'UNKNOWN'
'third_party/chromite/third_party/requests/packages/urllib3/util/url.py' has non-whitelisted license 'UNKNOWN'
'third_party/chromite/third_party/requests/packages/urllib3/packages/ssl_match_hostname/_implementation.py' has non-whitelisted license 'UNKNOWN'
'third_party/chromite/third_party/requests/packages/urllib3/packages/ssl_match_hostname/__init__.py' has non-whitelisted license 'UNKNOWN'
'third_party/chromite/third_party/requests/packages/urllib3/packages/ordered_dict.py' has non-whitelisted license 'UNKNOWN'
'third_party/chromite/third_party/requests/packages/urllib3/packages/__init__.py' has non-whitelisted license 'UNKNOWN'
'third_party/chromite/third_party/requests/packages/urllib3/__init__.py' has non-whitelisted license 'UNKNOWN'
'third_party/chromite/third_party/requests/packages/chardet/chardetect.py' has non-whitelisted license 'UNKNOWN'
'third_party/chromite/third_party/requests/packages/__init__.py' has non-whitelisted license 'UNKNOWN'
'third_party/chromite/third_party/requests/__init__.py' has non-whitelisted license 'UNKNOWN'
'third_party/chromite/third_party/requests/sessions.py' has non-whitelisted license 'UNKNOWN'
'third_party/chromite/third_party/requests/api.py' has non-whitelisted license 'UNKNOWN'

This directory is also missing a README.chromium file.

We need to fix these or file an upstream bug.
 
maruel@ already filed https://github.com/kennethreitz/requests/issues/1610 a couple years ago.
Labels: -Pri-2 Pri-3

Comment 3 by pho...@chromium.org, Mar 29 2018

Owner: akes...@chromium.org
Is this bug still relevant?
Components: Infra>Client>ChromeOS>CI
Owner: ----
not a major priority
Cc: akes...@chromium.org
 Issue 603946  has been merged into this issue.
Labels: -Pri-3 Pri-2
Status: Available (was: Untriaged)
Yep, we need to fix this. Is this currently affecting Chrome source builds negatively?
As far as I am aware this just adds noise to checklicenses.py.

Sign in to add a comment