New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 603943 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Delete all amp-related recipe code when it's safe to do so

Project Member Reported by bpastene@chromium.org, Apr 15 2016

Issue description

Once nothing is using amp support code, we can cleanup our recipes a bit.
 
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 18 2016

The following revision refers to this bug:
  http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=86735

------------------------------------------------------------------
r86735 | recipe-roller@chromium.org | 2016-04-18T20:43:03.894122Z

-----------------------------------------------------------------

Comment 3 by benhenry@google.com, Apr 27 2016

Components: Infra>Client>Android
Labels: -Infra-Android
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/cd2a044ea7051c5e26c557a3588a67a45f609387

commit cd2a044ea7051c5e26c557a3588a67a45f609387
Author: phajdan.jr <phajdan.jr@chromium.org>
Date: Tue Jul 12 13:58:27 2016

Remove amp recipe module and related code (unused)

BUG= 603943 , 584079,  593999 

Review-Url: https://codereview.chromium.org/2142923002

[delete] https://crrev.com/1d694b052f50c4629da38958581890295c6e8a8d/scripts/slave/recipe_modules/amp/__init__.py
[delete] https://crrev.com/1d694b052f50c4629da38958581890295c6e8a8d/scripts/slave/recipe_modules/amp/api.py
[delete] https://crrev.com/1d694b052f50c4629da38958581890295c6e8a8d/scripts/slave/recipe_modules/amp/config.py
[delete] https://crrev.com/1d694b052f50c4629da38958581890295c6e8a8d/scripts/slave/recipe_modules/amp/example.expected/bad_device_data_for_collect.json
[delete] https://crrev.com/1d694b052f50c4629da38958581890295c6e8a8d/scripts/slave/recipe_modules/amp/example.expected/bad_device_data_from_trigger.json
[delete] https://crrev.com/1d694b052f50c4629da38958581890295c6e8a8d/scripts/slave/recipe_modules/amp/example.expected/bad_test_id_data_for_upload.json
[delete] https://crrev.com/1d694b052f50c4629da38958581890295c6e8a8d/scripts/slave/recipe_modules/amp/example.expected/device_oem_basic.json
[delete] https://crrev.com/1d694b052f50c4629da38958581890295c6e8a8d/scripts/slave/recipe_modules/amp/example.expected/minimum_device_os_basic.json
[delete] https://crrev.com/1d694b052f50c4629da38958581890295c6e8a8d/scripts/slave/recipe_modules/amp/example.expected/multiple_device_oses_basic.json
[delete] https://crrev.com/1d694b052f50c4629da38958581890295c6e8a8d/scripts/slave/recipe_modules/amp/example.expected/multiple_devices_basic.json
[delete] https://crrev.com/1d694b052f50c4629da38958581890295c6e8a8d/scripts/slave/recipe_modules/amp/example.expected/network_config_set_basic.json
[delete] https://crrev.com/1d694b052f50c4629da38958581890295c6e8a8d/scripts/slave/recipe_modules/amp/example.expected/no_device_name_basic.json
[delete] https://crrev.com/1d694b052f50c4629da38958581890295c6e8a8d/scripts/slave/recipe_modules/amp/example.expected/no_device_os_basic.json
[delete] https://crrev.com/1d694b052f50c4629da38958581890295c6e8a8d/scripts/slave/recipe_modules/amp/example.expected/normal_example_basic.json
[delete] https://crrev.com/1d694b052f50c4629da38958581890295c6e8a8d/scripts/slave/recipe_modules/amp/example.expected/slow_tests_basic.json
[delete] https://crrev.com/1d694b052f50c4629da38958581890295c6e8a8d/scripts/slave/recipe_modules/amp/example.expected/split_example_basic.json
[delete] https://crrev.com/1d694b052f50c4629da38958581890295c6e8a8d/scripts/slave/recipe_modules/amp/example.expected/underspecified_with_timeout_basic.json
[delete] https://crrev.com/1d694b052f50c4629da38958581890295c6e8a8d/scripts/slave/recipe_modules/amp/example.py
[modify] https://crrev.com/cd2a044ea7051c5e26c557a3588a67a45f609387/scripts/slave/recipe_modules/chromium_tests/__init__.py
[modify] https://crrev.com/cd2a044ea7051c5e26c557a3588a67a45f609387/scripts/slave/recipe_modules/chromium_tests/api.py
[modify] https://crrev.com/cd2a044ea7051c5e26c557a3588a67a45f609387/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py
[modify] https://crrev.com/cd2a044ea7051c5e26c557a3588a67a45f609387/scripts/slave/recipe_modules/chromium_tests/steps.py
[delete] https://crrev.com/1d694b052f50c4629da38958581890295c6e8a8d/scripts/slave/recipes/chromium.expected/amp_split_recipe_collect_failure.json
[delete] https://crrev.com/1d694b052f50c4629da38958581890295c6e8a8d/scripts/slave/recipes/chromium.expected/amp_split_recipe_instrumentation_trigger_failure.json
[delete] https://crrev.com/1d694b052f50c4629da38958581890295c6e8a8d/scripts/slave/recipes/chromium.expected/amp_split_recipe_trigger_failure.json
[modify] https://crrev.com/cd2a044ea7051c5e26c557a3588a67a45f609387/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Android_Builder__dbg_.json
[delete] https://crrev.com/1d694b052f50c4629da38958581890295c6e8a8d/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Android_Tests__amp_instrumentation_test_split_.json
[delete] https://crrev.com/1d694b052f50c4629da38958581890295c6e8a8d/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Android_Tests__amp_split_.json
[modify] https://crrev.com/cd2a044ea7051c5e26c557a3588a67a45f609387/scripts/slave/recipes/chromium.py

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 12 2016

Project Member

Comment 6 by bugdroid1@chromium.org, Jul 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/06f5234b1560350a97e5347436b8c08ba822ec88

commit 06f5234b1560350a97e5347436b8c08ba822ec88
Author: recipe-roller <recipe-roller@chromium.org>
Date: Tue Jul 12 14:19:54 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/1d694b052f50c4629da38958581890295c6e8a8d V8: Prevent v8 rolls while chromium checkout is inconsistent (machenbach@chromium.org)
  https://crrev.com/cd2a044ea7051c5e26c557a3588a67a45f609387 Remove amp recipe module and related code (unused) (phajdan.jr@chromium.org)

R=phajdan.jr@chromium.org,machenbach@chromium.org
BUG= 593999 ,584079, 603943 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2142933002

[modify] https://crrev.com/06f5234b1560350a97e5347436b8c08ba822ec88/infra/config/recipes.cfg

Project Member

Comment 7 by bugdroid1@chromium.org, Jul 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/653a039ac2dc466eb9cfe4c8e955f7bd5c30679f

commit 653a039ac2dc466eb9cfe4c8e955f7bd5c30679f
Author: recipe-roller <recipe-roller@chromium.org>
Date: Tue Jul 12 14:38:42 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/1d694b052f50c4629da38958581890295c6e8a8d V8: Prevent v8 rolls while chromium checkout is inconsistent (machenbach@chromium.org)
  https://crrev.com/cd2a044ea7051c5e26c557a3588a67a45f609387 Remove amp recipe module and related code (unused) (phajdan.jr@chromium.org)
  https://crrev.com/da2c8e114ce61e09721f2ffd07c1065626d51d54 Add 8 new Dart VM builders (whesse@google.com)

R=whesse@google.com,phajdan.jr@chromium.org,machenbach@chromium.org
BUG= 593999 ,584079, 603943 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2147523002

[modify] https://crrev.com/653a039ac2dc466eb9cfe4c8e955f7bd5c30679f/infra/config/recipes.cfg

Cc: bpastene@chromium.org
Owner: phajdan.jr@chromium.org
Status: Fixed (was: Assigned)

Sign in to add a comment