New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 603942 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

recipe_engine failures are confusing to debug

Project Member Reported by thakis@chromium.org, Apr 15 2016

Issue description

I'm writing some change (https://codereview.chromium.org/1892903002 ps1). The change is currently incorrect.

When I run `scripts/slave/unittests/recipe_simulation_tests.py train`, things fail like so:

thakis@thakis:~/src/chrome/build$ scripts/slave/unittests/recipe_simulation_test.py train
Traceback (most recent call last):
  File "/usr/local/google/home/thakis/src/chrome/build/scripts/slave/.recipe_deps/recipe_engine/recipe_engine/third_party/expect_tests/pipeline.py", line 114, in gen_loop_process
    result_queue.put_nowait)
  File "/usr/local/google/home/thakis/src/chrome/build/scripts/slave/.recipe_deps/recipe_engine/recipe_engine/third_party/expect_tests/handle_train.py", line 34, in gen_stage_loop
    for test in tests:
  File "/usr/local/google/home/thakis/src/chrome/build/scripts/slave/.recipe_deps/recipe_engine/recipe_engine/third_party/expect_tests/pipeline.py", line 70, in generate_tests
    root_test = next(gen_inst)
  File "/usr/local/google/home/thakis/src/chrome/build/scripts/slave/.recipe_deps/recipe_engine/recipe_engine/simulation_test.py", line 78, in GenerateTests
    for test_data in recipe.GenTests(test_api):
  File "/usr/local/google/home/thakis/src/chrome/build/scripts/slave/recipes/chromium_trybot.py", line 291, in GenTests
    suppress_analyze() +
  File "/usr/local/google/home/thakis/src/chrome/build/scripts/slave/recipe_modules/chromium_tests/test_api.py", line 27, in platform
    'chromium_config_kwargs', {}).get('TARGET_BITS', 64))
  File "/usr/local/google/home/thakis/src/chrome/build/scripts/slave/.recipe_deps/recipe_engine/recipe_modules/platform/test_api.py", line 21, in __call__
    return self.name(name) + self.bits(bits)
  File "/usr/local/google/home/thakis/src/chrome/build/scripts/slave/.recipe_deps/recipe_engine/recipe_engine/recipe_test_api.py", line 283, in inner
    data = static_call(self, func, *args, **kwargs)
  File "/usr/local/google/home/thakis/src/chrome/build/scripts/slave/.recipe_deps/recipe_engine/recipe_engine/util.py", line 104, in static_call
    return func.__get__(obj)(*args, **kwargs)
  File "/usr/local/google/home/thakis/src/chrome/build/scripts/slave/.recipe_deps/recipe_engine/recipe_modules/platform/test_api.py", line 11, in name
    assert name in ('win', 'linux', 'mac')
AssertionError


That's not informative enough for me to see exactly what's going on, so I added a `print name` in test_api.py above the assert. When I run the train command again, I discover that my change has been undone -- looks like something overwrote test_api.py (looks like it's mirrored in? but from where?)

How am I supposed to debug this?

(iannucci, maruel: no idea if you know either, but I saw "luci" scroll by somewhere, and I thought I saw both of you use that word in the past.)
 

Comment 1 by thakis@chromium.org, Apr 15 2016

This was my problem: https://codereview.chromium.org/1892903002/diff2/1:20001/scripts/slave/recipe_modules/chromium_tests/chromium_win.py

I found this by looking at my diff; I couldn't figure out how to change test_api.py for debugging.

Comment 2 by aga...@chromium.org, Apr 26 2016

Components: Infra>Platform>Recipes
Labels: -Infra-Recipes
Status: Available (was: Unconfirmed)
Going through old bugs....

Yeah, debugging this stuff can be hard :(

The reason your print statement disappeared is that the .recipe_deps folder is managed by the recipe_engine, and is checked out every time we run, so all your changes disappear. You can change the code that runs there (-O flag), but that's not very discoverable. The output from the simulation test should explain this more...


Owner: iannucci@chromium.org
Status: Started (was: Available)
going through all bugs. Although this is filed as a rather large-scope bug (the conditions of which have improved since it was filed), there's a small-scope fix here, which is to improve these assertions.  CL: https://codereview.chromium.org/2887543002
Status: Fixed (was: Started)

Sign in to add a comment