OS: Android Given the changes in planned user experience surrounding offline content we need to decouple offline content from the bookmarks UI. Details in go/paquete-automagic-bookmarks
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ec75aaa6e8794e2d8e0ecc67b99912af227529d2 commit ec75aaa6e8794e2d8e0ecc67b99912af227529d2 Author: fgorski <fgorski@chromium.org> Date: Tue Apr 19 21:29:17 2016 [Offline pages] Removing offline pages from Bookmarks UI * Removing all Offline page UI from Bookmarks UI * Removing all offline page code from bookmarks, except page snapshotting * Removing alternative offline page strings * Removing bookmarks filtering options * Relevant UMA will be marked obsolete separately BUG= 603940 R=jianli@chromiu.org,ianwen@chromium.org Review URL: https://codereview.chromium.org/1894703002 Cr-Commit-Position: refs/heads/master@{#388316} [modify] https://crrev.com/ec75aaa6e8794e2d8e0ecc67b99912af227529d2/chrome/android/BUILD.gn [modify] https://crrev.com/ec75aaa6e8794e2d8e0ecc67b99912af227529d2/chrome/android/java/AndroidManifest.xml [modify] https://crrev.com/ec75aaa6e8794e2d8e0ecc67b99912af227529d2/chrome/android/java/res/layout/bookmark_edit.xml [delete] https://crrev.com/440b117bb10d5c7e195a26cf974ccbd5886948b0/chrome/android/java/res/layout/bookmark_offline_pages_storage_space_header.xml [modify] https://crrev.com/ec75aaa6e8794e2d8e0ecc67b99912af227529d2/chrome/android/java/res/layout/bookmark_row_content.xml [modify] https://crrev.com/ec75aaa6e8794e2d8e0ecc67b99912af227529d2/chrome/android/java/res/values/dimens.xml [modify] https://crrev.com/ec75aaa6e8794e2d8e0ecc67b99912af227529d2/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java [modify] https://crrev.com/ec75aaa6e8794e2d8e0ecc67b99912af227529d2/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java [modify] https://crrev.com/ec75aaa6e8794e2d8e0ecc67b99912af227529d2/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkActionBar.java [modify] https://crrev.com/ec75aaa6e8794e2d8e0ecc67b99912af227529d2/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkActivity.java [modify] https://crrev.com/ec75aaa6e8794e2d8e0ecc67b99912af227529d2/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkAddActivity.java [modify] https://crrev.com/ec75aaa6e8794e2d8e0ecc67b99912af227529d2/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkBridge.java [modify] https://crrev.com/ec75aaa6e8794e2d8e0ecc67b99912af227529d2/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkContentView.java [modify] https://crrev.com/ec75aaa6e8794e2d8e0ecc67b99912af227529d2/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkDelegate.java [modify] https://crrev.com/ec75aaa6e8794e2d8e0ecc67b99912af227529d2/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkDrawerListView.java [modify] https://crrev.com/ec75aaa6e8794e2d8e0ecc67b99912af227529d2/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkDrawerListViewAdapter.java [modify] https://crrev.com/ec75aaa6e8794e2d8e0ecc67b99912af227529d2/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkEditActivity.java [delete] https://crrev.com/440b117bb10d5c7e195a26cf974ccbd5886948b0/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkFilter.java [modify] https://crrev.com/ec75aaa6e8794e2d8e0ecc67b99912af227529d2/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkItemRow.java [modify] https://crrev.com/ec75aaa6e8794e2d8e0ecc67b99912af227529d2/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkItemsAdapter.java [modify] https://crrev.com/ec75aaa6e8794e2d8e0ecc67b99912af227529d2/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkManager.java [modify] https://crrev.com/ec75aaa6e8794e2d8e0ecc67b99912af227529d2/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkModel.java [modify] https://crrev.com/ec75aaa6e8794e2d8e0ecc67b99912af227529d2/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkPage.java [modify] https://crrev.com/ec75aaa6e8794e2d8e0ecc67b99912af227529d2/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkRecyclerView.java [modify] https://crrev.com/ec75aaa6e8794e2d8e0ecc67b99912af227529d2/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkRow.java [modify] https://crrev.com/ec75aaa6e8794e2d8e0ecc67b99912af227529d2/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkSearchView.java [modify] https://crrev.com/ec75aaa6e8794e2d8e0ecc67b99912af227529d2/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUIObserver.java [modify] https://crrev.com/ec75aaa6e8794e2d8e0ecc67b99912af227529d2/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUIState.java [modify] https://crrev.com/ec75aaa6e8794e2d8e0ecc67b99912af227529d2/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUtils.java [modify] https://crrev.com/ec75aaa6e8794e2d8e0ecc67b99912af227529d2/chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPage.java [modify] https://crrev.com/ec75aaa6e8794e2d8e0ecc67b99912af227529d2/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageToolbar.java [modify] https://crrev.com/ec75aaa6e8794e2d8e0ecc67b99912af227529d2/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java [delete] https://crrev.com/440b117bb10d5c7e195a26cf974ccbd5886948b0/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageFreeUpSpaceCallback.java [delete] https://crrev.com/440b117bb10d5c7e195a26cf974ccbd5886948b0/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageFreeUpSpaceDialog.java [modify] https://crrev.com/ec75aaa6e8794e2d8e0ecc67b99912af227529d2/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageItem.java [delete] https://crrev.com/440b117bb10d5c7e195a26cf974ccbd5886948b0/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageOpenStorageSettingsDialog.java [delete] https://crrev.com/440b117bb10d5c7e195a26cf974ccbd5886948b0/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageStorageSpaceHeader.java [delete] https://crrev.com/440b117bb10d5c7e195a26cf974ccbd5886948b0/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageStorageSpacePolicy.java [modify] https://crrev.com/ec75aaa6e8794e2d8e0ecc67b99912af227529d2/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java [modify] https://crrev.com/ec75aaa6e8794e2d8e0ecc67b99912af227529d2/chrome/android/java/strings/android_chrome_strings.grd [modify] https://crrev.com/ec75aaa6e8794e2d8e0ecc67b99912af227529d2/chrome/android/java_sources.gni [modify] https://crrev.com/ec75aaa6e8794e2d8e0ecc67b99912af227529d2/chrome/android/javatests/src/org/chromium/chrome/browser/bookmarks/BookmarkModelTest.java [modify] https://crrev.com/ec75aaa6e8794e2d8e0ecc67b99912af227529d2/chrome/android/javatests/src/org/chromium/chrome/browser/bookmarks/BookmarkTest.java [delete] https://crrev.com/440b117bb10d5c7e195a26cf974ccbd5886948b0/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageFeatureTest.java [delete] https://crrev.com/440b117bb10d5c7e195a26cf974ccbd5886948b0/chrome/android/junit/src/org/chromium/chrome/browser/bookmarks/BookmarkModelUnitTest.java [delete] https://crrev.com/440b117bb10d5c7e195a26cf974ccbd5886948b0/chrome/android/junit/src/org/chromium/chrome/browser/bookmarks/BookmarkUtilsTest.java [modify] https://crrev.com/ec75aaa6e8794e2d8e0ecc67b99912af227529d2/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtilsTest.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5e9585c1f10b97051840ffc0532922089b39877c commit 5e9585c1f10b97051840ffc0532922089b39877c Author: jianli <jianli@chromium.org> Date: Thu Apr 21 22:13:30 2016 Update flags used by offline pages and bookmarks Offline pages have been removed from bookmarks UI. We're updating flags used by various offline page features. For capability to save offline copy automatically for bookmarked pages, "OfflineBookmarks" is introduced. The old flag "OfflinePages" is removed. We keep IsOfflinePagesEnabled() as a way to tell if any of offline features is enabled. BUG= 603940 Review URL: https://codereview.chromium.org/1899433002 Cr-Commit-Position: refs/heads/master@{#388920} [modify] https://crrev.com/5e9585c1f10b97051840ffc0532922089b39877c/chrome/android/BUILD.gn [modify] https://crrev.com/5e9585c1f10b97051840ffc0532922089b39877c/chrome/android/chrome_apk.gyp [modify] https://crrev.com/5e9585c1f10b97051840ffc0532922089b39877c/chrome/android/java/src/org/chromium/chrome/browser/ChromeSwitches.java [modify] https://crrev.com/5e9585c1f10b97051840ffc0532922089b39877c/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java [modify] https://crrev.com/5e9585c1f10b97051840ffc0532922089b39877c/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java [modify] https://crrev.com/5e9585c1f10b97051840ffc0532922089b39877c/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java [modify] https://crrev.com/5e9585c1f10b97051840ffc0532922089b39877c/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java [modify] https://crrev.com/5e9585c1f10b97051840ffc0532922089b39877c/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtilsTest.java [modify] https://crrev.com/5e9585c1f10b97051840ffc0532922089b39877c/chrome/app/generated_resources.grd [modify] https://crrev.com/5e9585c1f10b97051840ffc0532922089b39877c/chrome/browser/about_flags.cc [modify] https://crrev.com/5e9585c1f10b97051840ffc0532922089b39877c/chrome/browser/android/offline_pages/offline_page_bridge.cc [modify] https://crrev.com/5e9585c1f10b97051840ffc0532922089b39877c/chrome/browser/android/offline_pages/offline_page_tab_helper_unittest.cc [modify] https://crrev.com/5e9585c1f10b97051840ffc0532922089b39877c/chrome/browser/android/offline_pages/offline_page_utils_unittest.cc [modify] https://crrev.com/5e9585c1f10b97051840ffc0532922089b39877c/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/5e9585c1f10b97051840ffc0532922089b39877c/chrome/chrome.gyp [modify] https://crrev.com/5e9585c1f10b97051840ffc0532922089b39877c/components/error_page/common/localized_error.cc [modify] https://crrev.com/5e9585c1f10b97051840ffc0532922089b39877c/components/error_page_strings.grdp [modify] https://crrev.com/5e9585c1f10b97051840ffc0532922089b39877c/components/offline_pages.gypi [modify] https://crrev.com/5e9585c1f10b97051840ffc0532922089b39877c/components/offline_pages/BUILD.gn [modify] https://crrev.com/5e9585c1f10b97051840ffc0532922089b39877c/components/offline_pages/offline_page_feature.cc [modify] https://crrev.com/5e9585c1f10b97051840ffc0532922089b39877c/components/offline_pages/offline_page_feature.h [modify] https://crrev.com/5e9585c1f10b97051840ffc0532922089b39877c/components/offline_pages/offline_page_model_unittest.cc [delete] https://crrev.com/8a9783e4c8d986f835f8cc2760267d6c1c7b0b57/components/offline_pages/offline_page_switches.cc [delete] https://crrev.com/8a9783e4c8d986f835f8cc2760267d6c1c7b0b57/components/offline_pages/offline_page_switches.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0b9ea192c1b2b54fededc722305892d1c2fcb2b9 commit 0b9ea192c1b2b54fededc722305892d1c2fcb2b9 Author: fgorski <fgorski@chromium.org> Date: Fri Apr 22 01:18:19 2016 [Offline pages] Removing bookmarks dependency from offline pages component * Removing offline_page_bookmark_bridge and related tests * Updating constants' names * Updating constants' names in tests * Removing bookmarks from build files and DEPS Given that we no longer are bound to bookmarks or bookmarks UI there is no point in tracking existence thereof. When bookmark is deleted the offline copy is still around, until it expires. Once it does we clean it up. BUG= 603940 Review URL: https://codereview.chromium.org/1904613005 Cr-Commit-Position: refs/heads/master@{#388995} [modify] https://crrev.com/0b9ea192c1b2b54fededc722305892d1c2fcb2b9/chrome/browser/android/offline_pages/offline_page_tab_helper_unittest.cc [modify] https://crrev.com/0b9ea192c1b2b54fededc722305892d1c2fcb2b9/chrome/browser/android/offline_pages/offline_page_utils.cc [modify] https://crrev.com/0b9ea192c1b2b54fededc722305892d1c2fcb2b9/chrome/browser/android/offline_pages/offline_page_utils_unittest.cc [modify] https://crrev.com/0b9ea192c1b2b54fededc722305892d1c2fcb2b9/chrome/browser/bookmarks/bookmark_model_factory.cc [modify] https://crrev.com/0b9ea192c1b2b54fededc722305892d1c2fcb2b9/chrome/browser/net/net_error_tab_helper.cc [modify] https://crrev.com/0b9ea192c1b2b54fededc722305892d1c2fcb2b9/components/offline_pages.gypi [modify] https://crrev.com/0b9ea192c1b2b54fededc722305892d1c2fcb2b9/components/offline_pages/BUILD.gn [modify] https://crrev.com/0b9ea192c1b2b54fededc722305892d1c2fcb2b9/components/offline_pages/DEPS [delete] https://crrev.com/fda8f6e80af3e5c08905624f356a75b05d27dd39/components/offline_pages/offline_page_bookmark_bridge.cc [delete] https://crrev.com/fda8f6e80af3e5c08905624f356a75b05d27dd39/components/offline_pages/offline_page_bookmark_bridge.h [modify] https://crrev.com/0b9ea192c1b2b54fededc722305892d1c2fcb2b9/components/offline_pages/offline_page_metadata_store_impl.cc [modify] https://crrev.com/0b9ea192c1b2b54fededc722305892d1c2fcb2b9/components/offline_pages/offline_page_metadata_store_impl_unittest.cc [modify] https://crrev.com/0b9ea192c1b2b54fededc722305892d1c2fcb2b9/components/offline_pages/offline_page_model.cc [modify] https://crrev.com/0b9ea192c1b2b54fededc722305892d1c2fcb2b9/components/offline_pages/offline_page_model.h [modify] https://crrev.com/0b9ea192c1b2b54fededc722305892d1c2fcb2b9/components/offline_pages/offline_page_model_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/702d9d9c0afcc82a3f212a54082b373204baf711 commit 702d9d9c0afcc82a3f212a54082b373204baf711 Author: fgorski <fgorski@chromium.org> Date: Fri Apr 22 04:23:16 2016 [Offline pages] Removing undoing of deleting offline pages * Removing Undo capability from offline page model * Removing marking pages for deletion * Removing relevant tests. Given that we no longer are bound to bookmarks or bookmarks UI there is no point in tracking existence thereof. When bookmark is deleted the offline copy is still around, until it expires. Once it does we clean it up. BUG= 603940 R=jianli@chromium.org Review URL: https://codereview.chromium.org/1902593006 Cr-Commit-Position: refs/heads/master@{#389032} [modify] https://crrev.com/702d9d9c0afcc82a3f212a54082b373204baf711/components/offline_pages/offline_page_item.cc [modify] https://crrev.com/702d9d9c0afcc82a3f212a54082b373204baf711/components/offline_pages/offline_page_item.h [modify] https://crrev.com/702d9d9c0afcc82a3f212a54082b373204baf711/components/offline_pages/offline_page_model.cc [modify] https://crrev.com/702d9d9c0afcc82a3f212a54082b373204baf711/components/offline_pages/offline_page_model.h [modify] https://crrev.com/702d9d9c0afcc82a3f212a54082b373204baf711/components/offline_pages/offline_page_model_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/732834fe7d24a687d481f09e2c88cb22219ceb6b commit 732834fe7d24a687d481f09e2c88cb22219ceb6b Author: jianli <jianli@chromium.org> Date: Fri May 06 22:06:44 2016 Redirect immediately to offline copy on no network Also mark the offline page as accessed when this occurs. BUG= 603940 , 605951 Review-Url: https://codereview.chromium.org/1902443003 Cr-Commit-Position: refs/heads/master@{#392170} [modify] https://crrev.com/732834fe7d24a687d481f09e2c88cb22219ceb6b/chrome/browser/android/offline_pages/offline_page_tab_helper.cc [modify] https://crrev.com/732834fe7d24a687d481f09e2c88cb22219ceb6b/chrome/browser/android/offline_pages/offline_page_tab_helper_unittest.cc [modify] https://crrev.com/732834fe7d24a687d481f09e2c88cb22219ceb6b/chrome/browser/android/offline_pages/offline_page_utils.cc [modify] https://crrev.com/732834fe7d24a687d481f09e2c88cb22219ceb6b/chrome/browser/android/offline_pages/offline_page_utils.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4727ab67dde1088bdb5da8c63c51ee91e929e6e9 commit 4727ab67dde1088bdb5da8c63c51ee91e929e6e9 Author: fgorski <fgorski@chromium.org> Date: Tue May 10 20:54:33 2016 [Offline pages] Disabling offline pages in incognito This patch simply makes sure that offline page model is no longer avaialbe in incognito mode. BUG= 603940 ,606313 R=dewittj@chromium.org Review-Url: https://codereview.chromium.org/1966723002 Cr-Commit-Position: refs/heads/master@{#392710} [modify] https://crrev.com/4727ab67dde1088bdb5da8c63c51ee91e929e6e9/chrome/browser/android/offline_pages/offline_page_model_factory.cc [modify] https://crrev.com/4727ab67dde1088bdb5da8c63c51ee91e929e6e9/chrome/browser/android/offline_pages/offline_page_model_factory.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/28b4b671d156128aa26839393983d960149abf57 commit 28b4b671d156128aa26839393983d960149abf57 Author: fgorski <fgorski@chromium.org> Date: Thu May 12 17:54:14 2016 [Offline pages] Lighting up the bookmark star for saved recent pages This patch replaces a lookup for bookmark ID, based on offline URL with a lookup of original online URL based on offline URL, and then looks up a bookmark ID based on that, the way it is done when starting with original URL. BUG= 603940 Review-Url: https://codereview.chromium.org/1973033002 Cr-Commit-Position: refs/heads/master@{#393296} [modify] https://crrev.com/28b4b671d156128aa26839393983d960149abf57/chrome/browser/android/tab_android.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/517c5ffb2369cfc7253fd43982ab3b9f1f51049f commit 517c5ffb2369cfc7253fd43982ab3b9f1f51049f Author: fgorski <fgorski@chromium.org> Date: Thu May 12 18:38:19 2016 [Offline pages] Removes the functionality to get bookmark ID from offline URL BUG= 603940 Review-Url: https://codereview.chromium.org/1977503003 Cr-Commit-Position: refs/heads/master@{#393314} [modify] https://crrev.com/517c5ffb2369cfc7253fd43982ab3b9f1f51049f/chrome/browser/android/offline_pages/offline_page_utils.cc [modify] https://crrev.com/517c5ffb2369cfc7253fd43982ab3b9f1f51049f/chrome/browser/android/offline_pages/offline_page_utils.h [modify] https://crrev.com/517c5ffb2369cfc7253fd43982ab3b9f1f51049f/chrome/browser/android/offline_pages/offline_page_utils_unittest.cc
Comment 1 by bugdroid1@chromium.org
, Apr 19 2016