New issue
Advanced search Search tips

Issue 603935 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug

Blocked on:
issue 588518
issue 603586

Blocking:
issue 82385



Sign in to add a comment

Move WinClang bot to main waterfall

Project Member Reported by thakis@chromium.org, Apr 15 2016

Issue description

Now that win_clang is a default-on try bot ( bug 588518 ), its corresponding continuous builder WinClang should move from the FYI to the main waterfall.

I filed bug 603586 for getting a slave, but until then we can reuse one of our FYI slaves.
 

Comment 1 by thakis@chromium.org, Apr 15 2016

Cc: dpranke@chromium.org
https://codereview.chromium.org/1892903002/ is the full change. Now that I look at it, I think this needs to be done in several phases:

1. Free up build29-m1 by reshuffling bots on the FYI waterfall, restart FYI master
2. Add WinClang bot to main waterfall on main waterfall, restart main master
3. Edit try config to point win_clang bot from FYI to main WinClang bot
4. Remove WinClang bot from FYI waterfall, restart FYI master

dpranke, does that sound right to you? (win8 gn probably went through something similar?)

Comment 2 by thakis@chromium.org, Apr 15 2016

Dirk suggests a better plan: Remove 1 and use vm817-m1 instead (and the swap the slave later if necessary).
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 15 2016

Comment 4 by thakis@chromium.org, Apr 15 2016

Further modified plan: The cl in comment 3 also update the trybot already. dpranke pointed out that the .win bot doesn't have to be live for that to work, and the presubmit enforces that main waterfall bots have a matching try slave. (I missed to update the Cl description after changing that).

Left to do:
* restart main waterfall win master
* remove bot from FYI waterfall
* restart FYI waterfall
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 15 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/master-manager.git/+/90ef356a4c1ce0d8cc32d2d800decad38fd26a1e

commit 90ef356a4c1ce0d8cc32d2d800decad38fd26a1e
Author: thakis <thakis@google.com>
Date: Fri Apr 15 21:38:50 2016

Project Member

Comment 6 by bugdroid1@chromium.org, Apr 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45ba5ad730feb6e9caecb02226817fb077190d45

commit 45ba5ad730feb6e9caecb02226817fb077190d45
Author: Nico Weber <thakis@chromium.org>
Date: Fri Apr 15 22:19:18 2016

Add mb config for new WinClang64 (dbg) main waterfall bot.

BUG= 603935 
TBR=dpranke@chromium.org

Review URL: https://codereview.chromium.org/1886813006 .

Cr-Commit-Position: refs/heads/master@{#387721}

[modify] https://crrev.com/45ba5ad730feb6e9caecb02226817fb077190d45/tools/mb/mb_config.pyl

Project Member

Comment 7 by bugdroid1@chromium.org, Apr 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/13165c5bd323cc94b9ba938ddfd8bcb8e0bf52d3

commit 13165c5bd323cc94b9ba938ddfd8bcb8e0bf52d3
Author: Nico Weber <thakis@chromium.org>
Date: Fri Apr 15 22:32:48 2016

Move mb config for new WinClang64 (dbg) main waterfall bot to right place.

BUG= 603935 
TBR=dpranke

Review URL: https://codereview.chromium.org/1895533003 .

Cr-Commit-Position: refs/heads/master@{#387729}

[modify] https://crrev.com/13165c5bd323cc94b9ba938ddfd8bcb8e0bf52d3/tools/mb/mb_config.pyl

Project Member

Comment 9 by bugdroid1@chromium.org, Apr 17 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/master-manager.git/+/a55a32268b420a91fe575bd0e5fb7b98956b657d

commit a55a32268b420a91fe575bd0e5fb7b98956b657d
Author: thakis <thakis@google.com>
Date: Sun Apr 17 02:33:56 2016

Project Member

Comment 10 by bugdroid1@chromium.org, Apr 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1622a7bcfabc18669b4828cd510d47db784eb662

commit 1622a7bcfabc18669b4828cd510d47db784eb662
Author: Nico Weber <thakis@chromium.org>
Date: Sun Apr 17 03:49:51 2016

Remove WinClang bot from FYI waterfall, src/ part.

BUG= 603935 
TBR=dpranke@chromium.org

Review URL: https://codereview.chromium.org/1901473002 .

Cr-Commit-Position: refs/heads/master@{#387829}

[modify] https://crrev.com/1622a7bcfabc18669b4828cd510d47db784eb662/tools/mb/mb_config.pyl

Status: Fixed (was: Assigned)

Sign in to add a comment