New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 603934 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove used of ScopedDisposal on class ImageData

Project Member Reported by junov@chromium.org, Apr 15 2016

Issue description

Now that DOMUint8ClampedArray is always a GarbageCollected type, ImageBitmap::dispose() does not actually achieve anything useful.  It should be removed.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df8336d8c14172e886bcb2cfb49828e9ab92e33c

commit df8336d8c14172e886bcb2cfb49828e9ab92e33c
Author: junov <junov@chromium.org>
Date: Fri Apr 22 21:30:44 2016

Remove ImageData::dispose()

Now that DOMUint8ClampedArray is always a GarbageCollected type,
ImageData::dispose() does not actually achieve anything useful. Since
The m_data field always becomes unreachable at the same time as its
parent ImageBitmapObject, scoped disposal is pointless.

Since this was the only use of the ScopedDisposal template, we can
remove that too.

BUG= 603934 

Review URL: https://codereview.chromium.org/1889153003

Cr-Commit-Position: refs/heads/master@{#389247}

[modify] https://crrev.com/df8336d8c14172e886bcb2cfb49828e9ab92e33c/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp
[modify] https://crrev.com/df8336d8c14172e886bcb2cfb49828e9ab92e33c/third_party/WebKit/Source/core/html/ImageData.cpp
[modify] https://crrev.com/df8336d8c14172e886bcb2cfb49828e9ab92e33c/third_party/WebKit/Source/core/html/ImageData.h

Status: Fixed (was: Assigned)

Sign in to add a comment