New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 603926 link

Starred by 1 user
Status: Fixed
Owner:
csharrison@chromium.org
Closed: Apr 2016
Cc:
█ bmcquade@chromium.org
jkarlin@chromium.org
skare@chromium.org
isherman@chromium.org
asvitk...@chromium.org
█ rkaplow@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

PageLoad.Clients.DocWrite.Evaluator histograms are mis-named

Project Member Reported by csharrison@chromium.org, Apr 15 2016 
All the histogram variants should start with "PageLoad.Clients.DocWrite.Evaluator.Timing2", but they are missing "Timing2" in the Chrome code.

This should be a simple fix that I'll merge into 51.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f82333dc7fe6904d345fef725e967bae36daaaf8

commit f82333dc7fe6904d345fef725e967bae36daaaf8
Author: csharrison <csharrison@chromium.org>
Date: Fri Apr 15 18:28:19 2016

Fix histogram names for document_write_page_load_metrics_observer

BUG= 603926 

Review URL: https://codereview.chromium.org/1885043010

Cr-Commit-Position: refs/heads/master@{#387653}

[modify] https://crrev.com/f82333dc7fe6904d345fef725e967bae36daaaf8/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc

Comment 2 by csharrison@chromium.org, Apr 15 2016

Labels: Merge-Request-51

Comment 3 by csharrison@chromium.org, Apr 15 2016

Status: Fixed (was: Started)

Comment 4 by tin...@google.com, Apr 16 2016

Labels: -Merge-Request-51 Merge-Approved-51 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M51 (branch: 2704)
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 17 2016

Labels: -merge-approved-51 merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/420eecfe09a6f57417c14721620693b8a27c84e0

commit 420eecfe09a6f57417c14721620693b8a27c84e0
Author: Charles Harrison <csharrison@chromium.org>
Date: Sun Apr 17 15:24:39 2016

Fix histogram names for document_write_page_load_metrics_observer

BUG= 603926 

Review URL: https://codereview.chromium.org/1885043010

(cherry picked from commit f82333dc7fe6904d345fef725e967bae36daaaf8)

Cr-Original-Commit-Position: refs/heads/master@{#387653}
Cr-Commit-Position: refs/branch-heads/2704@{#84}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/420eecfe09a6f57417c14721620693b8a27c84e0/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc

Comment 6 by lafo...@chromium.org, Sep 17 2016

Components: -Metrics Internals>Metrics
►

Sign in to add a comment