New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 603922 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

7.5%-14.4% regression in startup.warm.blank_page at 386739:386788

Project Member Reported by rsch...@chromium.org, Apr 15 2016

Issue description

See the link to graphs below.
 
Trying some more bisects.
Cc: ashej...@chromium.org
Labels: TE-Triaged
Bisect re-kicked with wider revision range.

Details on the below link:
-------------------------------
https://chromeperf.appspot.com/group_report?bug_id=603922

Thank you!
Cc: rsch...@chromium.org
Owner: wangxianzhu@chromium.org
Based on the current bisect results, the most likely patch looks like:
https://chromium.googlesource.com/chromium/src/+/8c0c32361a933e23ed11c206413c381588fe44d8

I'm not particularly convinced though, so I've kicked off another bisect here. https://chromeperf.appspot.com/buildbucket_job_status/9013038191656258560
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, May 10 2016


===== BISECT JOB RESULTS =====
Status: completed


=== Bisection aborted ===
The bisect was aborted because The metric values for the initial "good" and "bad" revisions do not represent a clear regression.
Please contact the the team (see below) if you believe this is in error.

=== Warnings ===
The following warnings were raised by the bisect job:

 * Bisect failed to reproduce the regression with enough confidence.

===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N   Good?
chromium@386738  2275.33  2.28198  18  good
chromium@386788  2274.31  3.59232  18  bad

Bisect job ran on: win_perf_bisect
Bug ID: 603922

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests startup.warm.blank_page
Test Metric: first_non_empty_paint_time/first_non_empty_paint_time
Relative Change: 0.04%
Score: 0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/win_perf_bisect/builds/6507
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9013038191656258560


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5876798223548416

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Cc: wangxianzhu@chromium.org
Owner: ----
Status: Available (was: Assigned)
My change just changed

  invalidate(oldRect);
  invalidate(newRect);

to

  if (oldRect.contains(newRect)) {
    invalidate(oldRect);
  } else if (newRect.contains(oldRect)) {
    invalidate(newRect);
  } else {
    invalidate(oldRect);
    invalidate(newRect);
  }

which has nothing to do with the benchmarks.

Cc: bashi@chromium.org
Kicked another bisect on "startup.warm.blank_page / window_display_time" 
https://chromeperf.appspot.com/buildbucket_job_status/9012208734595531216


Project Member

Comment 8 by 42576172...@developer.gserviceaccount.com, May 19 2016


===== BISECT JOB RESULTS =====
Status: completed


=== Bisection aborted ===
The bisect was aborted because The metric values for the initial "good" and "bad" revisions do not represent a clear regression.
Please contact the the team (see below) if you believe this is in error.

=== Warnings ===
The following warnings were raised by the bisect job:

 * Bisect failed to reproduce the regression with enough confidence.

===== TESTED REVISIONS =====
Revision         Mean     Std Dev   N   Good?
chromium@386738  97.655   0.452114  18  good
chromium@386788  99.8012  7.43873   18  bad

Bisect job ran on: win_perf_bisect
Bug ID: 603922

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests startup.warm.blank_page
Test Metric: window_display_time/window_display_time
Relative Change: 5.90%
Score: 0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/win_perf_bisect/builds/6527
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9012208734595531216


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5897260974473216

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Project Member

Comment 9 by sheriffbot@chromium.org, Jun 1 2016

Labels: -M-52 M-53 MovedFrom-52
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -performance-sheriff Performance-Sheriff
Most of these metrics seem to have recovered.  I kicked off a bisect on ChromiumPerf/chromium-rel-win7-dual/startup.warm.blank_page / window_display_time / ref  since that only just recently recovered and its not too noisy.
Owner: wangxianzhu@chromium.org
Status: Fixed (was: Available)
It has really recovered. The regression was temporary due to my diagnosing code which has been disabled. Sorry for overlooking this bug.
Owner: ----
Status: Available (was: Fixed)
Never mind #11. It's totally unrelated.
Project Member

Comment 13 by sheriffbot@chromium.org, Jul 13 2016

Labels: -M-53 MovedFrom-53
This issue has been moved once and is lower than Pri-1. Removing the milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Owner: rsch...@chromium.org
Status: Assigned (was: Available)

===== BISECT JOB RESULTS =====
Status: completed


=== Bisection aborted ===
The bisect was aborted because The metric values for the initial "good" and "bad" revisions do not represent a clear regression.
Please contact the the team (see below) if you believe this is in error.

=== Warnings ===
The following warnings were raised by the bisect job:

 * Bisect failed to reproduce the regression with enough confidence.

===== TESTED REVISIONS =====
Revision         Mean     Std Dev   N   Good?
chromium@386738  136.298  0.667454  18  good
chromium@386788  136.477  0.533228  18  bad

Bisect job ran on: win_perf_bisect
Bug ID: 603922

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests startup.warm.blank_page
Test Metric: first_main_frame_load_time/first_main_frame_load_time
Relative Change: 0.14%
Score: 0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/win_perf_bisect/builds/6978
Job details: https://chromeperf.appspot.com/buildbucket_job_status/8999606336149631248


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5238125314441216

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Status: Fixed (was: Assigned)
The main regressions in this bug are recovered. 

Sign in to add a comment