Floated <input> inside <label style="position:relative"> does not render
Reported by
adam.ro...@gmail.com,
Apr 15 2016
|
||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2709.0 Safari/537.36 Example URL: https://software.hixie.ch/utilities/js/live-dom-viewer/?saved=4073 Steps to reproduce the problem: 1. Go to https://software.hixie.ch/utilities/js/live-dom-viewer/?saved=4073 What is the expected behavior? A text field should be displayed. What went wrong? No text field is displayed. Removing position:relative on the label, or removing float:left on the input makes the bug go away. The bug occurs regardless of input type (text, radio, checkbox, etc.) Does it occur on multiple sites: Yes Is it a problem with a plugin? No Did this work before? Yes Chrome 49 and below Does this work in other browsers? Yes Chrome version: 52.0.2709.0 Channel: canary OS Version: OS X 10.11.4 Flash Version: Shockwave Flash 21.0 r0 This is affecting many form elements on github.com. We're working on a workaround but I suspect other websites will be affected as well.
,
Apr 18 2016
,
Apr 18 2016
Thanks for the report. CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/17257534a482124490589598423d0178977c63ea..eabd1eb5f20a95331917ddc13fdaece8ccfe477c suspecting https://chromium.googlesource.com/chromium/src/+/48ae591062e4c764d6f064e93956d1ae1a0e88fa pkasting@,Could you please check the above issue & help us in finding an owner it its not yours. 1. Issue broken in M50 Good Build : 50.0.2633.0 Bad Build : 50.0.2634.0 (for 50.0.2634.0 showing message: Unable to load DEPS for revision '50.0.2634.0'; considered 50.0.2635.0 as bad build) 2. Able to reproduce the issue on Win7, Mac OS X 10.11.4, Ubuntu 14.04 using Chrome Stable 50.0.2661.75, Beta 50.0.2661.75, Dev 51.0.2704.7 and Canary 52.0.2710.0
,
Apr 18 2016
https://chromium.googlesource.com/chromium/src/+/6b616c49773e7b878799342251519195f3b32067 looks suspicious.
,
Apr 18 2016
Issue 604055 has been merged into this issue.
,
Apr 18 2016
,
Apr 18 2016
Please try to get this fix ASAP as we're cutting M50 Stable candidate tomorrow @ 5:00 PM PST. It would be great if the fix is landed in trunk and baked in tonight's Canary, then please request a merge to M50. Thank you.
,
Apr 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e7f53da593a30c18884a215115a99e276c3f73bd commit e7f53da593a30c18884a215115a99e276c3f73bd Author: wangxianzhu <wangxianzhu@chromium.org> Date: Tue Apr 19 00:55:44 2016 Temporarily disable float empty-phase optimization BUG= 603910 Review URL: https://codereview.chromium.org/1897823004 Cr-Commit-Position: refs/heads/master@{#388102} [modify] https://crrev.com/e7f53da593a30c18884a215115a99e276c3f73bd/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp
,
Apr 19 2016
,
Apr 19 2016
Pls confirm the change has baked in canary and verified safe. Thanks.
,
Apr 19 2016
The bug still reproduces for me in Canary 52.0.2712.0.
,
Apr 19 2016
Yes, it is reproducible on Canary version 52.0.2712.0 (Branch base position - 388092). This should be fixed in next available canary as per comment#8. So, kindly wait till that time. Appreciate your patience. Thank you!
,
Apr 19 2016
Issue 604368 has been merged into this issue.
,
Apr 19 2016
As per wangxianzhu@, this is a safe merge so approving merge to M50 branch 2661. Please go ahead and merge.
,
Apr 19 2016
Approving for M51 branch 2704 as well based on Comment #14.
,
Apr 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/74d75c02f2e2fa9afc8efa44c91ce35be53d5e90 commit 74d75c02f2e2fa9afc8efa44c91ce35be53d5e90 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Tue Apr 19 18:02:41 2016 Temporarily disable float empty-phase optimization BUG= 603910 Review URL: https://codereview.chromium.org/1897823004 Cr-Commit-Position: refs/heads/master@{#388102} Review URL: https://codereview.chromium.org/1897343002 . Cr-Commit-Position: refs/branch-heads/2661@{#607} Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081} [modify] https://crrev.com/74d75c02f2e2fa9afc8efa44c91ce35be53d5e90/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp
,
Apr 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eaf1e75a4a42b207bde305a89bcb3ab64ed12c5d commit eaf1e75a4a42b207bde305a89bcb3ab64ed12c5d Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Tue Apr 19 18:06:22 2016 Temporarily disable float empty-phase optimization BUG= 603910 Review URL: https://codereview.chromium.org/1897823004 Cr-Commit-Position: refs/heads/master@{#388102} Review URL: https://codereview.chromium.org/1897153004 . Cr-Commit-Position: refs/branch-heads/2704@{#126} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} [modify] https://crrev.com/eaf1e75a4a42b207bde305a89bcb3ab64ed12c5d/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp
,
Apr 19 2016
,
Apr 19 2016
,
Apr 19 2016
Tested this fix on Latest M50#50.0.2661.84 for Win7 64-bit OS, Mac OS X 10.11.4 & Linux Ubuntu 14.04 - Working as intended. Thank you!
,
Apr 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0f04dfab4e324972733e1707476c034f52467037 commit 0f04dfab4e324972733e1707476c034f52467037 Author: wangxianzhu <wangxianzhu@chromium.org> Date: Thu Apr 21 00:45:22 2016 Mark layer needsPaintPhaseFloat if a LayoutBlockFlow contains float This ensures that the flag is set on the correct layer that will paint the floats. BUG= 603910 TEST=PaintLayerPainterTest.PaintPhaseFloatUnderInlineLayer Review URL: https://codereview.chromium.org/1899063002 Cr-Commit-Position: refs/heads/master@{#388644} [modify] https://crrev.com/0f04dfab4e324972733e1707476c034f52467037/third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp [modify] https://crrev.com/0f04dfab4e324972733e1707476c034f52467037/third_party/WebKit/Source/core/layout/LayoutBox.cpp [modify] https://crrev.com/0f04dfab4e324972733e1707476c034f52467037/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp [modify] https://crrev.com/0f04dfab4e324972733e1707476c034f52467037/third_party/WebKit/Source/core/paint/PaintLayerPainterTest.cpp
,
Apr 21 2016
|
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by manoranj...@chromium.org
, Apr 15 2016