I hope to start early next week.

Feel lucky - this is a P0.9 ;) (mostly because we expect significant impact on suggestions quality).

Oh, BTW: if you find that turning on personalization for HOST_RESTRICTed queries can be enabled without specifying locales, please do exactly that and file a separate P2 bug for the locale support.


Thanks!

What's the rational behind "host restricting" personalized results? So far I heard from a lot of people that they don't get snippets at all. I have the gut feeling that there are mostly two reasons for that:
1. they don't have ML tiles (because of pass phrase etc.) 
2. their ML tiles only includes sites for which ChromeReader doesn't have any suggestions.

Mikel is now working on issue 605522 to measure how often we don't have tiles.

Not getting any snippets at all is different from this, no? This would hopefully increase the quality for cases where we do get snippets.

You're right - filed issue 605876 for that.

Issue 605231 has been merged into this issue.

I have the basic functionality implemented. 
It is currently blocked on discussion with raghu about providing gaia_id to ChromeReader.

Have we already defined how this should be launched? Via a separate finch experiment or will we just replace the current behavior?  

Ideally, this should be a separate experiment, because we don't know, yet, if the experience is going to be worse or better than without personalization.

Almost there, hope to land it early this week.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33a244f68391a327cde16a006150f862ae641aab

commit 33a244f68391a327cde16a006150f862ae641aab
Author: jkrcal <jkrcal@chromium.org>
Date: Wed May 11 09:28:37 2016

Allow fetching personalized snippets from ChromeReader.

This amounts to:
 - adding singin_manager and token_service to the fetcher;
 - adding a variation parameter to determine the type of fetching (see bug 606320);
 - changes to the request strings sent to ChromeReader;
 - getting the snippets ordered by their score (see  bug 608713 );

Additionally, this CL adds a score member to NTPSnippet and exposes it in snippets-internals.
(Loading and storing of NTPSnippet needed to be changed a bit as the score entry is stored in the top level suggestion node and not in the contentInfo subnode as everything else that we loaded so far).

BUG= 603907 ,  608713 , 606320
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/1922083004
Cr-Commit-Position: refs/heads/master@{#392886}

[modify] https://crrev.com/33a244f68391a327cde16a006150f862ae641aab/chrome/browser/ntp_snippets/ntp_snippets_service_factory.cc
[modify] https://crrev.com/33a244f68391a327cde16a006150f862ae641aab/chrome/browser/resources/snippets_internals.css
[modify] https://crrev.com/33a244f68391a327cde16a006150f862ae641aab/chrome/browser/resources/snippets_internals.html
[modify] https://crrev.com/33a244f68391a327cde16a006150f862ae641aab/chrome/browser/ui/webui/snippets_internals_message_handler.cc
[modify] https://crrev.com/33a244f68391a327cde16a006150f862ae641aab/components/ntp_snippets.gypi
[modify] https://crrev.com/33a244f68391a327cde16a006150f862ae641aab/components/ntp_snippets/BUILD.gn
[modify] https://crrev.com/33a244f68391a327cde16a006150f862ae641aab/components/ntp_snippets/DEPS
[modify] https://crrev.com/33a244f68391a327cde16a006150f862ae641aab/components/ntp_snippets/ntp_snippet.cc
[modify] https://crrev.com/33a244f68391a327cde16a006150f862ae641aab/components/ntp_snippets/ntp_snippet.h
[add] https://crrev.com/33a244f68391a327cde16a006150f862ae641aab/components/ntp_snippets/ntp_snippets_constants.cc
[add] https://crrev.com/33a244f68391a327cde16a006150f862ae641aab/components/ntp_snippets/ntp_snippets_constants.h
[modify] https://crrev.com/33a244f68391a327cde16a006150f862ae641aab/components/ntp_snippets/ntp_snippets_fetcher.cc
[modify] https://crrev.com/33a244f68391a327cde16a006150f862ae641aab/components/ntp_snippets/ntp_snippets_fetcher.h
[modify] https://crrev.com/33a244f68391a327cde16a006150f862ae641aab/components/ntp_snippets/ntp_snippets_fetcher_unittest.cc
[modify] https://crrev.com/33a244f68391a327cde16a006150f862ae641aab/components/ntp_snippets/ntp_snippets_service.cc
[modify] https://crrev.com/33a244f68391a327cde16a006150f862ae641aab/components/ntp_snippets/ntp_snippets_service_unittest.cc
[modify] https://crrev.com/33a244f68391a327cde16a006150f862ae641aab/ios/chrome/browser/ntp_snippets/ios_chrome_ntp_snippets_service_factory.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ffbe609f40c9df9523fc872d2fd1a71f22317064

commit ffbe609f40c9df9523fc872d2fd1a71f22317064
Author: jkrcal <jkrcal@chromium.org>
Date: Wed May 11 14:40:56 2016

Fix a memory error introduced by issue 1922083004, revealed by the
chromium.memory.fyi buildbot.

BUG= 603907 

Review-Url: https://codereview.chromium.org/1965333002
Cr-Commit-Position: refs/heads/master@{#392921}

[modify] https://crrev.com/ffbe609f40c9df9523fc872d2fd1a71f22317064/components/ntp_snippets/ntp_snippets_fetcher.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4df8ada22f3d15ad7153a369c780795797dfa1d

commit a4df8ada22f3d15ad7153a369c780795797dfa1d
Author: jkrcal <jkrcal@chromium.org>
Date: Thu May 19 16:41:07 2016

Getting the personalization settings in chrome://snippets-internals display correctly.

The personalization settings have been changed by recent CLs, this CL keeps snippets-internals up-to-date.

BUG= 603907 ,606320
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/1978513002
Cr-Commit-Position: refs/heads/master@{#394794}

[modify] https://crrev.com/a4df8ada22f3d15ad7153a369c780795797dfa1d/chrome/browser/resources/snippets_internals.html
[modify] https://crrev.com/a4df8ada22f3d15ad7153a369c780795797dfa1d/chrome/browser/resources/snippets_internals.js
[modify] https://crrev.com/a4df8ada22f3d15ad7153a369c780795797dfa1d/chrome/browser/ui/webui/snippets_internals_message_handler.cc
[modify] https://crrev.com/a4df8ada22f3d15ad7153a369c780795797dfa1d/components/ntp_snippets/ntp_snippets_fetcher.cc
[modify] https://crrev.com/a4df8ada22f3d15ad7153a369c780795797dfa1d/components/ntp_snippets/ntp_snippets_fetcher.h
[modify] https://crrev.com/a4df8ada22f3d15ad7153a369c780795797dfa1d/components/ntp_snippets/ntp_snippets_service.cc
[modify] https://crrev.com/a4df8ada22f3d15ad7153a369c780795797dfa1d/components/ntp_snippets/ntp_snippets_service.h
[modify] https://crrev.com/a4df8ada22f3d15ad7153a369c780795797dfa1d/components/ntp_snippets/ntp_snippets_service_unittest.cc