gn uses posix-style object names for Windows pch objects |
|||
Issue descriptionWith https://codereview.chromium.org/1183633003/, I can kind-of build Chrome/Windows on OS X. base/ builds fine, but it gn uses a posix-style filename for pch files. Here's a build edge for a pch file: /Users/thakis/src/llvm-build/bin/clang-cl /nologo /FC @obj/win8/test_registrar_constants/precompile.cc.o.rsp /c ../../build/precompile.cc /Foobj/win8/test_registrar_constants/precompile.cc.o /Fd"obj/win8/test_registrar_constants_cc.pdb" Note how this uses .cc.o for the output name, not .obj. There are probably a few places in gn that currently say `if defined(OS_WIN)` that should check for is_win in the gn sense instead (i.e. look at the current toolchain). This is similar to bug 600223 .
,
Apr 17 2016
https://codereview.chromium.org/1893933002/
,
Apr 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c065bd83a55626de81db52aca9bf88dbb425e904 commit c065bd83a55626de81db52aca9bf88dbb425e904 Author: thakis <thakis@chromium.org> Date: Mon Apr 18 12:07:46 2016 gn: Use .obj extension for pch objects on Windows. Fixes a cosmetic regression from https://codereview.chromium.org/1292983004 BUG= 603902 Review URL: https://codereview.chromium.org/1893933002 Cr-Commit-Position: refs/heads/master@{#387893} [modify] https://crrev.com/c065bd83a55626de81db52aca9bf88dbb425e904/tools/gn/ninja_binary_target_writer.cc
,
Apr 19 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by thakis@chromium.org
, Apr 17 2016