New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 603900 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Audio latency for getUserMedia has increased

Project Member Reported by henrika@chromium.org, Apr 15 2016

Issue description

The audio latency measured by https://sound.io/latency/ has increased from about 30ms to 60ms somewhere. I tracked it down on Mac to the range below:

https://chromium.googlesource.com/chromium/src/+log/50.0.2657.0..50.0.2658.0?pretty=fuller&n=10000

where your CL is included. 

It seems like they call

Caller origin: https://sound.io
Caller process id: 10913
Audio Constraints
{advanced: [{echoCancellation: {exact: false}}]}
Video Constraints

and most likely your CL breaks how they use constraints to disable all audio processing and that adds latency.

Could you figure out a way to resolve this?

 

Comment 1 by hta@chromium.org, Apr 15 2016

Another case of checking for mandatory constraints only. Fix in queue.

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4867880e77f4f8896a781740fff32f379df28b1

commit d4867880e77f4f8896a781740fff32f379df28b1
Author: hta <hta@chromium.org>
Date: Fri Apr 15 14:32:37 2016

Fix selection of "no audio processing" mode.

It was only possible to turn it off with a basic (mandatory)
constraint. It should also be possible to turn it off with an
advanced (optional) constraint.

BUG= 603900 

Review URL: https://codereview.chromium.org/1891953003

Cr-Commit-Position: refs/heads/master@{#387597}

[modify] https://crrev.com/d4867880e77f4f8896a781740fff32f379df28b1/content/renderer/media/media_stream_audio_processor_options.cc
[modify] https://crrev.com/d4867880e77f4f8896a781740fff32f379df28b1/content/renderer/media/media_stream_audio_processor_options.h
[modify] https://crrev.com/d4867880e77f4f8896a781740fff32f379df28b1/content/renderer/media/media_stream_audio_processor_unittest.cc

Comment 3 by hta@chromium.org, Apr 18 2016

Labels: Merge-Request-51

Comment 4 by tin...@google.com, Apr 18 2016

Labels: -Merge-Request-51 Merge-Approved-51 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M51 (branch: 2704)
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 18 2016

Labels: -merge-approved-51 merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c23fd07b662dac46924f60da3c4b1cf45a0536c

commit 5c23fd07b662dac46924f60da3c4b1cf45a0536c
Author: Harald Alvestrand <hta@google.com>
Date: Mon Apr 18 14:48:29 2016

Fix selection of "no audio processing" mode.

It was only possible to turn it off with a basic (mandatory)
constraint. It should also be possible to turn it off with an
advanced (optional) constraint.

BUG= 603900 

Review URL: https://codereview.chromium.org/1891953003

Cr-Commit-Position: refs/heads/master@{#387597}
(cherry picked from commit d4867880e77f4f8896a781740fff32f379df28b1)

Review URL: https://codereview.chromium.org/1893363002 .

Cr-Commit-Position: refs/branch-heads/2704@{#91}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/5c23fd07b662dac46924f60da3c4b1cf45a0536c/content/renderer/media/media_stream_audio_processor_options.cc
[modify] https://crrev.com/5c23fd07b662dac46924f60da3c4b1cf45a0536c/content/renderer/media/media_stream_audio_processor_options.h
[modify] https://crrev.com/5c23fd07b662dac46924f60da3c4b1cf45a0536c/content/renderer/media/media_stream_audio_processor_unittest.cc

Components: Blink>GetUserMedia
Labels: M-51

Comment 7 by hta@chromium.org, Apr 26 2016

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Verified in M51 Beta 51.0.2704.29
Measured audio latency by https://sound.io/latency/ and the round-trip latency is 36 ms 

Just FYI

I just tried 51.0.2700.0 (Official Build) dev (64-bit) and there the latency is 65 ms.
But in 52.0.2734.0 (Official Build) canary (64-bit) it is 30ms.
Seems like my Dev build was in a bad state. Forced an update and can now measure 30ms again. Correct version is 52.0.2729.3 (Official Build) dev (64-bit)

Sign in to add a comment