New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 603888 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 568151



Sign in to add a comment

Disable Android device discovery when testing CrOS

Project Member Reported by bccheng@chromium.org, Apr 15 2016

Issue description

Version: Multiple versions including ToT
OS: Remote testing CrOS device from Linux host

What steps will reproduce the problem?
Non-deterministic. Occasionally cannot find adb even after it is claimed to be properly installed. 

What is the expected output?
"adb devices" is executed, finds nothing, then test continues.

What do you see instead?
(WARNING) 2016-02-20 07:25:30,161 android_device.FindAllAvailableDevices:197  adb reported as present, but NoAdbError thrown: [Errno 2] No such file or directory

https://bugs.chromium.org/p/chromium/issues/detail?id=567797 is probably not root caused as adb still can get installed but is not executable, but we can totally workaround this for CrOS testing by disabling the Android device discovery.
 
Cc: aiolos@chromium.org
If you specify a non-android browser, shouldn't this check be skipped? 

Comment 3 by aiolos@chromium.org, Apr 16 2016

Cc: eakuefner@chromium.org
That's not quite how specifying browsers works. ie, "reference" could be an Android browser or a desktop one. But I agree that if the platform is specified as something non-android, we shouldn't be looking for Android devices.

Unfortunately, the browser finder code is a bit of a mess and should be refactored to help avoid issues like this, but no one has had the time to do it afaik. I'd be super happy to advice/review a fix for that if someone wants to take it on.

+eakuefner@ since he was talking about browser finder code recently.
Blocking: 568151
Ben, thanks for this fix but it also needs to be put in the the M-51 branch. 
Cc: -mshe...@chromium.org

Sign in to add a comment