New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 603882 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Headless shell: window.open causes shell to close

Project Member Reported by altimin@chromium.org, Apr 15 2016

Issue description

Using window.open from JS console causes headless shell to close.
 
Cc: skyos...@chromium.org alexclarke@chromium.org
Status: Available (was: Unconfirmed)
Problem is that we don't create aura::client::WindowTreeClient (and we need to).

Example can be seen in content/shell: https://code.google.com/p/chromium/codesearch#search/&q=WindowTreeClient%20file:%5Esrc/content/shell/&sq=package:chromium&type=cs
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b6d2d1fcb63abb91d74feb9e0de731e39d83ce55

commit b6d2d1fcb63abb91d74feb9e0de731e39d83ce55
Author: altimin <altimin@chromium.org>
Date: Thu Apr 21 15:23:22 2016

[headless] Fix crashing during window.open.

* Add WindowTreeClient.
* Register new WebContents in Embedder API.

BUG= 603882 
R=skyostil@chromium.org

Review URL: https://codereview.chromium.org/1891843004

Cr-Commit-Position: refs/heads/master@{#388775}

[modify] https://crrev.com/b6d2d1fcb63abb91d74feb9e0de731e39d83ce55/headless/BUILD.gn
[modify] https://crrev.com/b6d2d1fcb63abb91d74feb9e0de731e39d83ce55/headless/app/headless_shell.cc
[modify] https://crrev.com/b6d2d1fcb63abb91d74feb9e0de731e39d83ce55/headless/lib/browser/headless_browser_impl.cc
[modify] https://crrev.com/b6d2d1fcb63abb91d74feb9e0de731e39d83ce55/headless/lib/browser/headless_browser_impl.h
[modify] https://crrev.com/b6d2d1fcb63abb91d74feb9e0de731e39d83ce55/headless/lib/browser/headless_screen.h
[modify] https://crrev.com/b6d2d1fcb63abb91d74feb9e0de731e39d83ce55/headless/lib/browser/headless_web_contents_impl.cc
[modify] https://crrev.com/b6d2d1fcb63abb91d74feb9e0de731e39d83ce55/headless/lib/browser/headless_web_contents_impl.h
[add] https://crrev.com/b6d2d1fcb63abb91d74feb9e0de731e39d83ce55/headless/lib/browser/headless_window_tree_client.cc
[add] https://crrev.com/b6d2d1fcb63abb91d74feb9e0de731e39d83ce55/headless/lib/browser/headless_window_tree_client.h
[modify] https://crrev.com/b6d2d1fcb63abb91d74feb9e0de731e39d83ce55/headless/lib/headless_browser_browsertest.cc
[modify] https://crrev.com/b6d2d1fcb63abb91d74feb9e0de731e39d83ce55/headless/lib/headless_devtools_client_browsertest.cc
[modify] https://crrev.com/b6d2d1fcb63abb91d74feb9e0de731e39d83ce55/headless/lib/headless_web_contents_browsertest.cc
[modify] https://crrev.com/b6d2d1fcb63abb91d74feb9e0de731e39d83ce55/headless/public/headless_browser.h
[modify] https://crrev.com/b6d2d1fcb63abb91d74feb9e0de731e39d83ce55/headless/public/headless_web_contents.h
[add] https://crrev.com/b6d2d1fcb63abb91d74feb9e0de731e39d83ce55/headless/test/data/window_open.html

Status: Fixed (was: Available)

Sign in to add a comment