Regression: Unnecessary focus move to 'Search' icon after clicking on 'More actions' menu of chrome://downloads.
Reported by
jshan...@etouch.net,
Apr 15 2016
|
||||||||||
Issue descriptionChrome Version: 51.0.2704.7 (Official Build) a8bebc2b0cd3e3018b7c9f6ac698f04dd226abba-refs/branch-heads/2704@{#48} 32/64 Bit. OS : Win, Linux (Windows 7 aero enabled) Steps: 1. Launch Chrome, navigate to chrome://downloads and open Dev-tool. 2. Click on Toggle device toolbar icon and then select Reset to default from 'More options' menu. 3. Now click on 'More actions' menu of chrome://download page and observe. Actual: More actions menu does not open after clicking on it instead the focus is seen on Search icon. Expected: More actions menu should open after clicking on it and focus should not be seen on Search icon. This is a regression issue broken in M-50, below is bisect info Good build: 50.0.2632.0 Bad build: 50.02633.0 Narrow bisect: https://chromium.googlesource.com/chromium/src/+log/5222683d752d8b2c5b78380a9c9eaae3ed1971b1..5a35917b538a7b749ea9da4571f8ed6e4402b70d?pretty=fuller&n=100 Suspecting: r371567 ? Please help to re-assign if your change is not the cause.
,
Apr 15 2016
Seems like the right solution is to not reset scale factor to 1, but instead rely on setNeedsUpdate to calculate correct one later.
,
Apr 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/12ded61087cbef96393f56a6c01c8efcb386e4ef commit 12ded61087cbef96393f56a6c01c8efcb386e4ef Author: dgozman <dgozman@chromium.org> Date: Fri Apr 15 23:17:19 2016 [DevTools] Do not reset page scale to 1.0, rely on setNeedsReset. Testing this would be nice, but the only idea I can come up with is to call resetScaleStateImmediately() and check the page scale, which is no good. BUG= 603877 Review URL: https://codereview.chromium.org/1885043011 Cr-Commit-Position: refs/heads/master@{#387741} [modify] https://crrev.com/12ded61087cbef96393f56a6c01c8efcb386e4ef/third_party/WebKit/Source/web/WebViewImpl.cpp
,
May 11 2016
Verified on mac canary 52.0.2730.0. Requesting merge to M51.
,
May 11 2016
Your change meets the bar and is auto-approved for M51 (branch: 2704)
,
May 12 2016
Please merge your change to M51 branch 2704 before 5:00 PM PST, Monday (05/16/16), so we can take it in for next week LAST M51 beta release. Thank you.
,
May 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1696148d976483a50ae1eb422511703b0a8462e2 commit 1696148d976483a50ae1eb422511703b0a8462e2 Author: Dmitry Gozman <dgozman@chromium.org> Date: Thu May 12 18:55:29 2016 Merge to 2704 "[DevTools] Do not reset page scale to 1.0, rely on setNeedsReset." > [DevTools] Do not reset page scale to 1.0, rely on setNeedsReset. > > Testing this would be nice, but the only idea I can come up with is > to call resetScaleStateImmediately() and check the page scale, > which is no good. > > BUG= 603877 > > Review URL: https://codereview.chromium.org/1885043011 > > Cr-Commit-Position: refs/heads/master@{#387741} (cherry picked from commit 12ded61087cbef96393f56a6c01c8efcb386e4ef) TBR=pfeldman Review URL: https://codereview.chromium.org/1976693002 . Cr-Commit-Position: refs/branch-heads/2704@{#525} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} [modify] https://crrev.com/1696148d976483a50ae1eb422511703b0a8462e2/third_party/WebKit/Source/web/WebViewImpl.cpp
,
May 12 2016
,
May 18 2016
Verified the issue on Windows 7, Ubuntu 14.04 and Mac OS 10.11.4 using chrome latest Beta M51-51.0.2704.54 by following steps mentioned in the comment #0 and observed the fix is working fine as expected. Attaching screen-cast for the same. Hence adding TE-Verified label. Thanks!
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by dgozman@chromium.org
, Apr 15 2016