Regression: Toolbar buttons are not visible on applying theme in material design.
Reported by
adha...@etouch.net,
Apr 15 2016
|
||||
Issue descriptionVersion: 51.0.2704.7 (Official Build) a8bebc2b0cd3e3018b7c9f6ac698f04dd226abba-refs/branch-heads/2704@{#48} 32/64 Bit. OS : Win, Linux (Windows 7 aero enabled) Url : https://chrome.google.com/webstore/detail/ts18/hnhhmlalomhpoaelhcgmaeobmbbhfnkf?utm_source=chrome-ntp-icon Pre condition: Make sure Material design flag is enabled. What steps will reproduce the problem? (1) Launch Chrome and navigate to above url. (2) Add the theme to chrome. (3) Now try to hover the mouse cursor over the navigation and refresh buttons and observe. Actual : The navigation and refresh buttons disappear when the theme install is completed. Expected : The navigation and refresh buttons should be visible when the theme install is completed. This is a Regression issue broken in 'M-48' and below is the manual regression and Narrow bisect info: Good build : 47.0.2526.49 Bad build : 48.0.2528.0 Note: There are no builds available between this range. Narrow bisect info: https://chromium.googlesource.com/chromium/src/+log/daa0f9659f98ef279472dcf27d513c9c250dc2bb..9b638144d513b9622f08c8298e3815075fe1ec0b?pretty=fuller&n=100\ Suspecting : r352444 Note: Issue is not seen in Mac OS.
,
Apr 15 2016
Is this a case of the theme author needing to update an incorrect color (similar to https://bugs.chromium.org/p/chromium/issues/detail?id=585470#c28)?
,
Apr 15 2016
looks like it
,
Apr 16 2016
(Evan, did you check into what the actual color issue is with this theme?)
,
Apr 18 2016
I did not. You can see the buttons against the bg, they are just very faint without the bevel we used to add. It appears to me this is working as intended, because the theme author tried to make the buttons and the toolbar bg the same color. Unfortunately this doesn't work well in the land of MD and I think the only solution is for the theme to change.
,
Apr 18 2016
I think we're going to break a number of themes this way :/ The old UI had an outline around each button icon which helped to delineate the glyphs. We removed this outline, so now themes simply have to provide active and inactive colors that contrast sufficiently with the toolbar image/color. Interestingly, for this theme, the toolbar color given in the theme is significantly different than the toolbar image that's actually used; if the toolbar were actually the specified color, the icons would be fairly visible. +CC Sebastien -- should we do anything to re-add an outline around the images inside the buttons, maybe just for custom themes? Or is this something we're OK living with?
,
Apr 18 2016
This was bound to happen when we want from edges icons to flat ones. It is working as intended. This will require theme authors to give a different value for the icons.
,
Apr 19 2016
imo the theme looked pretty bad beforehand anyway. Almost impossible to distinguish enabled/disabled, and generally just extremely low contrast. |
||||
►
Sign in to add a comment |
||||
Comment 1 by tkent@chromium.org
, Apr 15 2016