New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 603852 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

WebRTC peerconnection telemetry tests don't get calls up on flight mode phones

Project Member Reported by phoglund@chromium.org, Apr 15 2016

Issue description

Version: 
OS: Android

What steps will reproduce the problem?
(1) ninja -C out/Release chrome_public_apk
(2) tools/perf/run_benchmark -v --browser=android-chromium --also-run-disabled-tests webrtc.peerconnection
(3) Run on rooted phone in flight mode

What is the expected output?
Expect call to get up after ~5s.

What do you see instead?
The remote view stays black == call doesn't get up.

Please use labels and text to provide additional information.
Spun off from  https://crbug.com/594434 .
 
Labels: Test-Performance Infra-Client-WebRTC OS-Android
The consequence is that we don't measure actual WebRTC calls but rather telemetry for failed WebRTC calls. This is better than nothing but it's obviously more interesting to measure real calls.
Note to posterity: I tried the following for perf/benchmarks/webrtc.py:

    options.AppendExtraBrowserArgs('--allow-loopback-in-peer-connection')
    options.AppendExtraBrowserArgs('--enforce-webrtc-ip-permission-check')

Neither of the flags makes a difference. I'm sure we need the topmost one, but it's apparently not enough.

Comment 3 by benhenry@google.com, Apr 27 2016

Components: Infra>Client>WebRTC
Labels: -Infra-Client-WebRTC
Status: Archived (was: Available)
Pri-3 with no updates in 180+ days that are available and have no owner == Archived. Feel free to update status, add context as to why and move this along.
Owner: ehmaldonado@chromium.org
Status: Assigned (was: Archived)
Edward can you look into if this is the case, since the reproduction steps are so easy to perform?
Status: Started (was: Assigned)
Cc: -tnakamura@chromium.org
Did you get any result from this?
Just confirmed. 
Cc: ehmaldonado@chromium.org
Components: -Infra>Client>WebRTC Blink>WebRTC>PeerConnection
Labels: -Pri-3 Pri-2
Owner: ----
Status: Untriaged (was: Started)
Thanks. moving to Blink>WebRTC>PeerConnection for triage.
Cc: nednguyen@chromium.org
Ned: Do you think this is an issue with WebRTC or with telemetry?
Likely telemetry (see  issue 704782 ). I am swarmed with stuffs right now, so if you can help with that issue, I will really appreciate it. 
How much effort do you think it'll take?
Probably few days for people who are familiar with Telemetry. The tasks would include validate whether chrome flag matches with what shown in the trace, work with perezju@ to fix it, and add test to prevent it from regressing again.
I'll be away for the first two weeks of April, let's talk about this after I come back if that is still an issue :)
Owner: ehmaldonado@chromium.org
Status: Assigned (was: Untriaged)
Assigning to ehmaldonado@, since he seems to have a plan. Please reassign if necessary.
Status: Fixed (was: Assigned)

Sign in to add a comment