Add UI treatment to indicate the user has reached the end of the list of zine articles |
||||||||||||||||||
Issue descriptionCurrently there's no overscroll or other UI treatment to indicate the user has reached the end of the list. Sync up with UX to define what this should be.
,
Apr 20 2016
Thanks for pinging this up to me Michael! Adding Alan on CC to comment on the proposal. Proposal: - leave 40dp (vertical) space after the bottom of the last card - if there aren't enough articles so that the above>below transition can be completed, add additional height to the background (until it can) - use an overscroll treatment if the user continues to scroll 'past' the bottom. I'd propose using one consistent with what's shown in Inbox (black with a low opacity, ~5%). Alan - any concerns with that approach?
,
Apr 26 2016
ping - any concerns Alan?
,
Apr 28 2016
Issue 603308 has been merged into this issue.
,
May 3 2016
ping
,
May 4 2016
Thanks Michael. I've sent Alan an email.
,
May 4 2016
No concerns. LGTM
,
May 4 2016
,
May 5 2016
Nicole, IIUC this is in the set of things you plan to get to (or re-assign).
,
May 10 2016
,
May 10 2016
,
May 12 2016
Nicole, please have a look at the comment left by Alan on the merged bug, Issue 603308
,
May 14 2016
,
May 19 2016
This is already there by default android bit appears very lightly. Will explore darkening the moon
,
Jun 7 2016
Adding Alan's comment for clarity: "If we can, it'd be nice to allow for 32dp of padding between last snippet and bottom of screen when snippet list is full So to summarize - allow a single snippet to scroll to the top of the canvas - when list is full, allow for a 32dp padding at the bottom"
,
Jul 1 2016
,
Jul 1 2016
,
Jul 1 2016
,
Jul 5 2016
,
Jul 6 2016
,
Jul 8 2016
,
Jul 8 2016
,
Jul 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/485959bbdae82273c7308d0f49099dad00c1cd6c commit 485959bbdae82273c7308d0f49099dad00c1cd6c Author: mcwilliams <mcwilliams@chromium.org> Date: Fri Jul 08 14:17:14 2016 Ntp, darken the color of the overScroll for the RecyclerView The background is currently grey so the overScroll colorEdgeEffect to a slightly too light, darken this so users can see when reaching the bottom of the page. Add a 32dp at the bottom of the RecyclerView. videos: https://drive.google.com/corp/drive/u/0/folders/0B1IgAIJ9cgizbkRtbmFyQThaQzQ BUG= 603851 Review-Url: https://codereview.chromium.org/2127083002 Cr-Commit-Position: refs/heads/master@{#404364} [modify] https://crrev.com/485959bbdae82273c7308d0f49099dad00c1cd6c/chrome/android/java/res/layout/new_tab_page_recycler_view.xml [modify] https://crrev.com/485959bbdae82273c7308d0f49099dad00c1cd6c/chrome/android/java/res/values-v17/styles.xml [modify] https://crrev.com/485959bbdae82273c7308d0f49099dad00c1cd6c/chrome/android/java/res/values/dimens.xml [modify] https://crrev.com/485959bbdae82273c7308d0f49099dad00c1cd6c/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java
,
Jul 8 2016
|
||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||
Comment 1 by fi...@chromium.org
, Apr 20 2016Status: Assigned (was: Untriaged)