Debug version of chrome crash on certain URL. |
||||
Issue descriptionVersion: 50.0.2661.75 Debug version only OS: All, tested on Linux What steps will reproduce the problem? (1) Compile chrome with debug. (2) Start the browser. (3) Go to a http link with schema included and a space in host name, for example "http://ab cd" What is the expected output? Browser process the link What do you see instead? Browser crash at a DCHECK in the code. This doesn't reproduce on Release versions because of that. The DCHECK in file history_url_provider.cc fails on the line: Check failed: !trim_http || !AutocompleteInput::HasHTTPScheme(input.text()). Seems like the problem is caused by the fact that function SuggestExactInput is called from file components/omnibox/browser/omnibox_edit_model.cc (line 655) with wrong argument for bool trim_http.
,
Apr 15 2016
You are exactly correct.
,
Apr 17 2016
Does it do this on "Dev" and "Canary" versions as well?
,
Apr 18 2016
No it doesn't because those are compiled without DCHECK().
,
Jun 1 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/25a43970447cb8760dde96b9ec6875371dbd07f8 commit 25a43970447cb8760dde96b9ec6875371dbd07f8 Author: pkasting <pkasting@chromium.org> Date: Thu Jun 09 21:11:22 2016 Fix DCHECK. SuggestExactInput() was being called with the wrong value for |trim_http|. We want to trim HTTP only when the user hasn't explicitly typed it, but instead we were trying to trim it only _if_ the user explicitly typed it. This has been wrong since this code was introduced in https://codereview.chromium.org/58553003/ . BUG= 603839 TEST=In a debug build, use the omnibox to navigate to "http://ab cd" (no quotes). This should not DCHECK. Review-Url: https://codereview.chromium.org/2046263002 Cr-Commit-Position: refs/heads/master@{#399014} [modify] https://crrev.com/25a43970447cb8760dde96b9ec6875371dbd07f8/components/omnibox/browser/omnibox_controller.cc [modify] https://crrev.com/25a43970447cb8760dde96b9ec6875371dbd07f8/components/omnibox/browser/omnibox_edit_model.cc [modify] https://crrev.com/25a43970447cb8760dde96b9ec6875371dbd07f8/components/omnibox/browser/omnibox_edit_unittest.cc
,
Jun 10 2016
,
Jun 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/25a43970447cb8760dde96b9ec6875371dbd07f8 commit 25a43970447cb8760dde96b9ec6875371dbd07f8 Author: pkasting <pkasting@chromium.org> Date: Thu Jun 09 21:11:22 2016 Fix DCHECK. SuggestExactInput() was being called with the wrong value for |trim_http|. We want to trim HTTP only when the user hasn't explicitly typed it, but instead we were trying to trim it only _if_ the user explicitly typed it. This has been wrong since this code was introduced in https://codereview.chromium.org/58553003/ . BUG= 603839 TEST=In a debug build, use the omnibox to navigate to "http://ab cd" (no quotes). This should not DCHECK. Review-Url: https://codereview.chromium.org/2046263002 Cr-Commit-Position: refs/heads/master@{#399014} [modify] https://crrev.com/25a43970447cb8760dde96b9ec6875371dbd07f8/components/omnibox/browser/omnibox_controller.cc [modify] https://crrev.com/25a43970447cb8760dde96b9ec6875371dbd07f8/components/omnibox/browser/omnibox_edit_model.cc [modify] https://crrev.com/25a43970447cb8760dde96b9ec6875371dbd07f8/components/omnibox/browser/omnibox_edit_unittest.cc |
||||
►
Sign in to add a comment |
||||
Comment 1 by tnagel@chromium.org
, Apr 15 2016