Issue metadata
Sign in to add a comment
|
[Regression]: Ripple effect is not fully seen in download bar |
|||||||||||||||||||||||
Issue descriptionVersion: 51.0.2704.14 dev OS: Ubuntu 14.04,windows test Url: https://www.google.co.in/intl/en/chrome/browser/desktop/ What steps will reproduce the problem? (1) Launch chrome and go to above url >> Click Download chrome >> Accept and install or Try Downloading any large file (2) Now right click on extreme ends of downloading file for context menu on download shelf >> Hit esc/select cancel option and observe ripple on download shelf Expected: Even on interrupting ripple should fully spread Actual: Instead ripple is not fully spread and weird behaviour is seen on clicking at different parts of downloading file. This is a regression issue broken in M51. Good Build: 51.0.2699.0 dev Bad Build: 51.0.2700.0 dev CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/411ea14c10f64b67a25985619583a5331e724d57..031aebddd2c595f9bcbf9c11457b5b23ced055fa Suspecting https://codereview.chromium.org/1832963002 from changelog @estade: Please help in re-assigning if it is not related to your change.
,
Apr 19 2016
,
Apr 19 2016
Checked the issue on 51.0.2704.19 dev ,Ubuntu 14.04 and able to reproduce the issue. i.e ripple effect is not fully applied to downloading items in downloads shelf when interrupted. Note: While some file is downloading right click on that download shelf and observe. Attaching screencast of same.
,
Apr 19 2016
,
Apr 20 2016
Something doesn't make sense here, since this issue is reported as being seen in M51, but Ben's CL mentioned in #4 landed in M52 and has not been merged back yet.
,
Apr 25 2016
Just to update: Able to repro this issue on Windows 7 for Latest Canary Version - 52.0.2715.0
,
Apr 27 2016
,
Apr 27 2016
,
Apr 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5bb27fbab45e1534e353ec3e8e9ab7a57c7a35d4 commit 5bb27fbab45e1534e353ec3e8e9ab7a57c7a35d4 Author: bruthig <bruthig@chromium.org> Date: Thu Apr 28 11:39:13 2016 Fixed material design ink drop location for the MD download shelf buttons. A recent regression caused the clip bounds for the FloodFillInkDropAnimation to incorrectly be centered on the click point for the DownloadItemViewMd buttons. This change fixes that and suppresses the ripple for right clicks on the DownloadItemViewMd as well. BUG= 603818 TEST=manual Review-Url: https://codereview.chromium.org/1915983009 Cr-Commit-Position: refs/heads/master@{#390347} [modify] https://crrev.com/5bb27fbab45e1534e353ec3e8e9ab7a57c7a35d4/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc [modify] https://crrev.com/5bb27fbab45e1534e353ec3e8e9ab7a57c7a35d4/chrome/browser/ui/views/download/download_item_view_md.cc [modify] https://crrev.com/5bb27fbab45e1534e353ec3e8e9ab7a57c7a35d4/ui/views/animation/flood_fill_ink_drop_animation.cc [modify] https://crrev.com/5bb27fbab45e1534e353ec3e8e9ab7a57c7a35d4/ui/views/animation/flood_fill_ink_drop_animation.h [modify] https://crrev.com/5bb27fbab45e1534e353ec3e8e9ab7a57c7a35d4/ui/views/animation/ink_drop_animation_unittest.cc [modify] https://crrev.com/5bb27fbab45e1534e353ec3e8e9ab7a57c7a35d4/ui/views/controls/button/label_button.cc
,
May 2 2016
Fix is working as intended on the latest canary(52.0.2722.0) on Windows-7 and Linux Ubuntu 14.04. Attached is the screenshot of the same. bruthig@: If there is no further work to be done on this, could you please get this merged to M-51 as well. Thank you!
,
May 2 2016
,
May 2 2016
Your change meets the bar and is auto-approved for M51 (branch: 2704)
,
May 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/570179660e444a49a8c973eadd3da1f6cd9880df commit 570179660e444a49a8c973eadd3da1f6cd9880df Author: Ben Ruthig <bruthig@chromium.org> Date: Mon May 02 15:13:30 2016 Fixed material design ink drop location for the MD download shelf buttons. A recent regression caused the clip bounds for the FloodFillInkDropAnimation to incorrectly be centered on the click point for the DownloadItemViewMd buttons. This change fixes that and suppresses the ripple for right clicks on the DownloadItemViewMd as well. BUG= 603818 TEST=manual Review-Url: https://codereview.chromium.org/1915983009 Cr-Commit-Position: refs/heads/master@{#390347} (cherry picked from commit 5bb27fbab45e1534e353ec3e8e9ab7a57c7a35d4) R=jonross@chromium.org Review URL: https://codereview.chromium.org/1942843002 . Cr-Commit-Position: refs/branch-heads/2704@{#332} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} [modify] https://crrev.com/570179660e444a49a8c973eadd3da1f6cd9880df/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc [modify] https://crrev.com/570179660e444a49a8c973eadd3da1f6cd9880df/chrome/browser/ui/views/download/download_item_view_md.cc [modify] https://crrev.com/570179660e444a49a8c973eadd3da1f6cd9880df/ui/views/animation/flood_fill_ink_drop_animation.cc [modify] https://crrev.com/570179660e444a49a8c973eadd3da1f6cd9880df/ui/views/animation/flood_fill_ink_drop_animation.h [modify] https://crrev.com/570179660e444a49a8c973eadd3da1f6cd9880df/ui/views/animation/ink_drop_animation_unittest.cc [modify] https://crrev.com/570179660e444a49a8c973eadd3da1f6cd9880df/ui/views/controls/button/label_button.cc
,
May 2 2016
,
May 3 2016
Verified the merge on the latest M-51(51.0.2704.35(2704@{#345}) on Windows-7 and Linux Ubuntu 14.04.
Merge is successful, hence adding the Verified label for M-51.
,
May 5 2016
Verified the fix on Windows 7 & Ubuntu Trusty (14.04) for Google Chrome Beta Version - 51.0.2704.36 Screen-recording is attached. TE-Verified Labels are added.
,
May 5 2016
Verified the fix on Windows 7 & Ubuntu Trusty (14.04) for Google Chrome Dev Version - 52.0.2723.4 Screen-recording is attached. TE-Verified Labels are added.
|
||||||||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||||||||
Comment 1 by rnimmagadda@chromium.org
, Apr 19 20161.7 MB
1.7 MB Download
150 KB
150 KB View Download