Http2PriorityWriteScheduler is overtemplated and underused |
|||
Issue descriptionRight now, we have Http2PriorityWriteScheduler ( https://chromium.googlesource.com/chromium/src/+/master/net/spdy/http2_write_scheduler.h ) , which is presently templated to take arbitrary types, but only ever instantiated with one type. The only instantiation that codesearch can find (internal or external) is in the unit test. It seems like, at best, this is overly complicated code that's largely been untouched for nearly 2 years except for occasional bulk imports, and worst, it's dead code. In either event, it shows up in code cleanups and refactorings, and that seems like a good candidate to remove.
,
Apr 15 2016
rch: I do not see any reason not to remove this class.
,
Apr 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/36f94b12a7b06b77480b1d1563c47c20ae60c91e commit 36f94b12a7b06b77480b1d1563c47c20ae60c91e Author: bnc <bnc@chromium.org> Date: Tue Apr 04 13:01:25 2017 Remove Http2PriorityWriteScheduler. This class has been checked in but not used for over a year. BUG= 603810 Review-Url: https://codereview.chromium.org/2791883003 Cr-Commit-Position: refs/heads/master@{#461689} [modify] https://crrev.com/36f94b12a7b06b77480b1d1563c47c20ae60c91e/net/BUILD.gn [delete] https://crrev.com/f670a4bb1851e14d8a58046bb39f31cb7cd2bd6c/net/spdy/http2_write_scheduler.h [delete] https://crrev.com/f670a4bb1851e14d8a58046bb39f31cb7cd2bd6c/net/spdy/http2_write_scheduler_test.cc
,
Apr 4 2017
OP: Thank you for reporting this issue. I removed class Http2PriorityWriteScheduler. |
|||
►
Sign in to add a comment |
|||
Comment 1 by b...@chromium.org
, Apr 15 2016Owner: b...@chromium.org
Status: Assigned (was: Untriaged)