New issue
Advanced search Search tips

Issue 603797 link

Starred by 1 user
Status: Fixed
Owner:
shaktisahu@chromium.org
Closed: May 2016
Cc:
klo...@chromium.org
dtrainor@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature

Blocking:
issue 597789



Sign in to add a comment

Blimp client should not start with black

Project Member Reported by klo...@chromium.org, Apr 15 2016 
Start Blimp.

Observe black before seeing the content.

We should set white as window background, probably through getWindow().setBackgroundDrawable().

In the future, we should remove this after SurfaceView has content.

Comment 1 by shaktisahu@chromium.org, Apr 20 2016 

The window background should be set to white in the beginning of the application.
After the first frame is drawn, the background should be set to null.
src/chrome/android/..../CompositorView.java --> onSwapBuffersCompleted

BlimpOutputSurface: SwapBuffers() seems like the right place to reset the background.

Comment 3 by shaktisahu@chromium.org, Apr 28 2016

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, May 4 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a14676fc06d51ce9382217801882dae19e2c792a

commit a14676fc06d51ce9382217801882dae19e2c792a
Author: shaktisahu <shaktisahu@chromium.org>
Date: Wed May 04 20:10:57 2016

Changed Blimp client to start with white screen before drawing contents

Currently Blimp client starts with a black screen before having any
contents. In this patch, this behavior was fixed by two steps:
1 - BlimpView background color is set to white on initialization.
2 - Later after the first frame is received, the background is reset to
null.
For this to happen, we rely on the callback DidCompleteSwapBuffers of
RemoteChannelImpl and hook it all the way to BlimpView.

BUG= 603797 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/1925863003
Cr-Commit-Position: refs/heads/master@{#391619}

[modify] https://crrev.com/a14676fc06d51ce9382217801882dae19e2c792a/blimp/client/app/android/blimp_compositor_manager_android.cc
[modify] https://crrev.com/a14676fc06d51ce9382217801882dae19e2c792a/blimp/client/app/android/blimp_compositor_manager_android.h
[modify] https://crrev.com/a14676fc06d51ce9382217801882dae19e2c792a/blimp/client/app/android/blimp_view.cc
[modify] https://crrev.com/a14676fc06d51ce9382217801882dae19e2c792a/blimp/client/app/android/blimp_view.h
[modify] https://crrev.com/a14676fc06d51ce9382217801882dae19e2c792a/blimp/client/app/android/java/src/org/chromium/blimp/BlimpView.java
[modify] https://crrev.com/a14676fc06d51ce9382217801882dae19e2c792a/blimp/client/app/linux/blimp_display_manager.cc
[modify] https://crrev.com/a14676fc06d51ce9382217801882dae19e2c792a/blimp/client/app/linux/blimp_display_manager.h
[modify] https://crrev.com/a14676fc06d51ce9382217801882dae19e2c792a/blimp/client/feature/compositor/blimp_compositor.cc
[modify] https://crrev.com/a14676fc06d51ce9382217801882dae19e2c792a/blimp/client/feature/compositor/blimp_compositor.h
[modify] https://crrev.com/a14676fc06d51ce9382217801882dae19e2c792a/blimp/client/feature/compositor/blimp_compositor_manager.cc
[modify] https://crrev.com/a14676fc06d51ce9382217801882dae19e2c792a/blimp/client/feature/compositor/blimp_compositor_manager.h
[modify] https://crrev.com/a14676fc06d51ce9382217801882dae19e2c792a/blimp/client/feature/compositor/blimp_compositor_manager_unittest.cc
[modify] https://crrev.com/a14676fc06d51ce9382217801882dae19e2c792a/blimp/client/feature/compositor/blimp_compositor_unittest.cc
[modify] https://crrev.com/a14676fc06d51ce9382217801882dae19e2c792a/cc/trees/remote_channel_impl.cc
[modify] https://crrev.com/a14676fc06d51ce9382217801882dae19e2c792a/cc/trees/remote_channel_impl.h

Comment 5 by shaktisahu@chromium.org, May 4 2016

Status: Fixed (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, May 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a00dfc9a4c82fece6036ccbf1c9664234a6a586

commit 8a00dfc9a4c82fece6036ccbf1c9664234a6a586
Author: shaktisahu <shaktisahu@chromium.org>
Date: Tue May 10 22:32:25 2016

Fixed a cc unittest for swap buffer change

BUG= 603797 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/1954293002
Cr-Commit-Position: refs/heads/master@{#392749}

[modify] https://crrev.com/8a00dfc9a4c82fece6036ccbf1c9664234a6a586/cc/trees/remote_channel_unittest.cc
►

Sign in to add a comment