New issue
Advanced search Search tips

Issue 603795 link

Starred by 3 users
Status: Duplicate
Merged: issue 712963
Owner: ----
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 561879



Sign in to add a comment

Break the blink web layer apart

Project Member Reported by esprehn@chromium.org, Apr 15 2016 
We should move the code from web/ into modules/, core/ or platform/ per the Onion Soup plan. The web layer is painful and messy, lets get rid of it.

This may involve introducing the new public/ API per onion soup where we have a bunch of pure virtual interfaces that we implement in core/modules or platform to expose services out of blink.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fbba129b9e1ebe8b5174fddbfe8c3b86f5337198

commit fbba129b9e1ebe8b5174fddbfe8c3b86f5337198
Author: esprehn <esprehn@chromium.org>
Date: Fri Apr 15 17:59:56 2016

Merge DragClientImpl into core.

This adds ChromeClient methods so core can call the WebViewClient methods for
dragging removing the need for DragClient. It also merges all the code from
DragClient down into core so the drag logic lives in one places. To do this I
also had to move the WebDragOperation.h header into platform so both web/ and
core/ could depend on it.

This also exposed some dead code in web/, like tracking the last mouse position
for dragging, but nothing actually used that value.

BUG= 603795 

Review URL: https://codereview.chromium.org/1888773003

Cr-Commit-Position: refs/heads/master@{#387639}

[modify] https://crrev.com/fbba129b9e1ebe8b5174fddbfe8c3b86f5337198/components/test_runner/event_sender.h
[modify] https://crrev.com/fbba129b9e1ebe8b5174fddbfe8c3b86f5337198/components/test_runner/web_test_proxy.h
[modify] https://crrev.com/fbba129b9e1ebe8b5174fddbfe8c3b86f5337198/content/browser/DEPS
[modify] https://crrev.com/fbba129b9e1ebe8b5174fddbfe8c3b86f5337198/content/browser/browser_plugin/browser_plugin_embedder.h
[modify] https://crrev.com/fbba129b9e1ebe8b5174fddbfe8c3b86f5337198/content/browser/browser_plugin/browser_plugin_guest.h
[modify] https://crrev.com/fbba129b9e1ebe8b5174fddbfe8c3b86f5337198/content/browser/renderer_host/render_view_host_delegate_view.h
[modify] https://crrev.com/fbba129b9e1ebe8b5174fddbfe8c3b86f5337198/content/browser/renderer_host/render_view_host_unittest.cc
[modify] https://crrev.com/fbba129b9e1ebe8b5174fddbfe8c3b86f5337198/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/fbba129b9e1ebe8b5174fddbfe8c3b86f5337198/content/browser/web_contents/web_contents_view_mus.cc
[modify] https://crrev.com/fbba129b9e1ebe8b5174fddbfe8c3b86f5337198/content/browser/web_contents/web_drag_utils_win.h
[modify] https://crrev.com/fbba129b9e1ebe8b5174fddbfe8c3b86f5337198/content/common/DEPS
[modify] https://crrev.com/fbba129b9e1ebe8b5174fddbfe8c3b86f5337198/content/common/browser_plugin/browser_plugin_messages.h
[modify] https://crrev.com/fbba129b9e1ebe8b5174fddbfe8c3b86f5337198/content/common/drag_messages.h
[modify] https://crrev.com/fbba129b9e1ebe8b5174fddbfe8c3b86f5337198/content/common/drag_traits.h
[modify] https://crrev.com/fbba129b9e1ebe8b5174fddbfe8c3b86f5337198/content/public/browser/render_view_host.h
[modify] https://crrev.com/fbba129b9e1ebe8b5174fddbfe8c3b86f5337198/content/public/browser/web_contents_delegate.h
[modify] https://crrev.com/fbba129b9e1ebe8b5174fddbfe8c3b86f5337198/third_party/WebKit/Source/core/loader/EmptyClients.cpp
[modify] https://crrev.com/fbba129b9e1ebe8b5174fddbfe8c3b86f5337198/third_party/WebKit/Source/core/loader/EmptyClients.h
[modify] https://crrev.com/fbba129b9e1ebe8b5174fddbfe8c3b86f5337198/third_party/WebKit/Source/core/page/ChromeClient.h
[delete] https://crrev.com/f3d3cabe0aac002c29bf4614a602e4cdde713370/third_party/WebKit/Source/core/page/DragClient.h
[modify] https://crrev.com/fbba129b9e1ebe8b5174fddbfe8c3b86f5337198/third_party/WebKit/Source/core/page/DragController.cpp
[modify] https://crrev.com/fbba129b9e1ebe8b5174fddbfe8c3b86f5337198/third_party/WebKit/Source/core/page/DragController.h
[modify] https://crrev.com/fbba129b9e1ebe8b5174fddbfe8c3b86f5337198/third_party/WebKit/Source/core/page/Page.cpp
[modify] https://crrev.com/fbba129b9e1ebe8b5174fddbfe8c3b86f5337198/third_party/WebKit/Source/core/page/Page.h
[modify] https://crrev.com/fbba129b9e1ebe8b5174fddbfe8c3b86f5337198/third_party/WebKit/Source/core/testing/DummyPageHolder.cpp
[modify] https://crrev.com/fbba129b9e1ebe8b5174fddbfe8c3b86f5337198/third_party/WebKit/Source/web/ChromeClientImpl.cpp
[modify] https://crrev.com/fbba129b9e1ebe8b5174fddbfe8c3b86f5337198/third_party/WebKit/Source/web/ChromeClientImpl.h
[delete] https://crrev.com/f3d3cabe0aac002c29bf4614a602e4cdde713370/third_party/WebKit/Source/web/DragClientImpl.cpp
[delete] https://crrev.com/f3d3cabe0aac002c29bf4614a602e4cdde713370/third_party/WebKit/Source/web/DragClientImpl.h
[modify] https://crrev.com/fbba129b9e1ebe8b5174fddbfe8c3b86f5337198/third_party/WebKit/Source/web/WebViewImpl.cpp
[modify] https://crrev.com/fbba129b9e1ebe8b5174fddbfe8c3b86f5337198/third_party/WebKit/Source/web/WebViewImpl.h
[modify] https://crrev.com/fbba129b9e1ebe8b5174fddbfe8c3b86f5337198/third_party/WebKit/Source/web/tests/WebViewTest.cpp
[modify] https://crrev.com/fbba129b9e1ebe8b5174fddbfe8c3b86f5337198/third_party/WebKit/Source/web/web.gypi
[modify] https://crrev.com/fbba129b9e1ebe8b5174fddbfe8c3b86f5337198/third_party/WebKit/public/blink_headers.gypi
[rename] https://crrev.com/fbba129b9e1ebe8b5174fddbfe8c3b86f5337198/third_party/WebKit/public/platform/WebDragOperation.h
[modify] https://crrev.com/fbba129b9e1ebe8b5174fddbfe8c3b86f5337198/third_party/WebKit/public/web/WebPlugin.h
[modify] https://crrev.com/fbba129b9e1ebe8b5174fddbfe8c3b86f5337198/third_party/WebKit/public/web/WebView.h
[modify] https://crrev.com/fbba129b9e1ebe8b5174fddbfe8c3b86f5337198/third_party/WebKit/public/web/WebViewClient.h

Comment 2 by cbiesin...@chromium.org, Jul 6 2016

Components: Blink>Internals
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8889114b8767fda91d4fc4c5f49eb5034395ee5d

commit 8889114b8767fda91d4fc4c5f49eb5034395ee5d
Author: dglazkov <dglazkov@chromium.org>
Date: Tue Sep 20 01:57:02 2016

Split Jinja-related CodeGeneratorV8 guts into a separate class.

* Introduces CodeGeneratorBase, which contains most of the
  Jinja-related plumbing.
* Shifts some common functions along with it into a new file.

R=yukishiino,bashi
BUG= 603795 
TEST=Tools/Scripts/run-bindings-tests

Review-Url: https://codereview.chromium.org/2345083004
Cr-Commit-Position: refs/heads/master@{#419643}

[modify] https://crrev.com/8889114b8767fda91d4fc4c5f49eb5034395ee5d/third_party/WebKit/Source/bindings/scripts/BUILD.gn
[add] https://crrev.com/8889114b8767fda91d4fc4c5f49eb5034395ee5d/third_party/WebKit/Source/bindings/scripts/code_generator.py
[modify] https://crrev.com/8889114b8767fda91d4fc4c5f49eb5034395ee5d/third_party/WebKit/Source/bindings/scripts/code_generator_v8.py
[modify] https://crrev.com/8889114b8767fda91d4fc4c5f49eb5034395ee5d/third_party/WebKit/Source/bindings/scripts/scripts.gni

Comment 4 by jbroman@chromium.org, Apr 25 2017

Mergedinto: 712963
Status: Duplicate (was: Untriaged)
►

Sign in to add a comment