New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 603792 link

Starred by 1 user
Status: Fixed
Owner:
█ kozyatinskiy@chromium.org
Last visit > 30 days ago
Closed: Apr 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 0
Type: Bug-Regression



Sign in to add a comment

DevTools: pause in random place when DOM breakpoint is set

Project Member Reported by kozyatinskiy@chromium.org, Apr 15 2016 
What steps will reproduce the problem?
1. Open about:blank
2. Set DOM breakpoint on mouse click.
3. Add empty event listener:
document.addEventListener("click", {});
4. Click somewhere in page.
5. Start typing in console.

Or

1. Set DOM breakpoint on timer fired
2. run setTimeout({}, 0) in console
3. Start typing in console.

What is the expected output?
No pause.

What do you see instead?
Execution is paused
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f447ebc494e1c3c0296689ca978831044fef623

commit 3f447ebc494e1c3c0296689ca978831044fef623
Author: kozyatinskiy <kozyatinskiy@chromium.org>
Date: Fri Apr 15 18:51:03 2016

[DevTools] Bring back InspectorInstrumenetation::didHandleEvent

We should clear scheduled pause if event listener doesn't execute JavaScript or setTimeout expression contains syntax error otherwise JS execution will be paused in random place.

R=dgozman@chromium.org,pfeldman@chromium.org
BUG= 603792 

Review URL: https://codereview.chromium.org/1891113002

Cr-Commit-Position: refs/heads/master@{#387660}

[add] https://crrev.com/3f447ebc494e1c3c0296689ca978831044fef623/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/break-on-empty-event-listener-expected.txt
[add] https://crrev.com/3f447ebc494e1c3c0296689ca978831044fef623/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/break-on-empty-event-listener.html
[add] https://crrev.com/3f447ebc494e1c3c0296689ca978831044fef623/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/break-on-set-timeout-with-syntax-error-expected.txt
[add] https://crrev.com/3f447ebc494e1c3c0296689ca978831044fef623/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/break-on-set-timeout-with-syntax-error.html
[modify] https://crrev.com/3f447ebc494e1c3c0296689ca978831044fef623/third_party/WebKit/Source/core/events/EventTarget.cpp
[modify] https://crrev.com/3f447ebc494e1c3c0296689ca978831044fef623/third_party/WebKit/Source/core/frame/DOMTimer.cpp
[modify] https://crrev.com/3f447ebc494e1c3c0296689ca978831044fef623/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp
[modify] https://crrev.com/3f447ebc494e1c3c0296689ca978831044fef623/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.h
[modify] https://crrev.com/3f447ebc494e1c3c0296689ca978831044fef623/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl

Comment 2 by kozyatinskiy@chromium.org, Apr 15 2016

Labels: Merge-Request-51

Comment 3 by tin...@google.com, Apr 16 2016

Labels: -Merge-Request-51 Merge-Approved-51 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M51 (branch: 2704)

Comment 4 Deleted

Comment 5 by gov...@chromium.org, Apr 18 2016 

Please merge your change to M51 branch 2704 ASAP (before 5:00 PM PST, today) so we can take it in for M51 last Dev release tomorrow.
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 18 2016

Labels: -merge-approved-51 merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1bc15aa1a2471e07a5ea74080fd871ee9926d339

commit 1bc15aa1a2471e07a5ea74080fd871ee9926d339
Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org>
Date: Mon Apr 18 18:39:00 2016

[DevTools] Bring back InspectorInstrumenetation::didHandleEvent

We should clear scheduled pause if event listener doesn't execute JavaScript or setTimeout expression contains syntax error otherwise JS execution will be paused in random place.

R=dgozman@chromium.org,pfeldman@chromium.org
BUG= 603792 

Review URL: https://codereview.chromium.org/1891113002

Cr-Commit-Position: refs/heads/master@{#387660}
(cherry picked from commit 3f447ebc494e1c3c0296689ca978831044fef623)

Review URL: https://codereview.chromium.org/1893333004 .

Cr-Commit-Position: refs/branch-heads/2704@{#99}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[add] https://crrev.com/1bc15aa1a2471e07a5ea74080fd871ee9926d339/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/break-on-empty-event-listener-expected.txt
[add] https://crrev.com/1bc15aa1a2471e07a5ea74080fd871ee9926d339/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/break-on-empty-event-listener.html
[add] https://crrev.com/1bc15aa1a2471e07a5ea74080fd871ee9926d339/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/break-on-set-timeout-with-syntax-error-expected.txt
[add] https://crrev.com/1bc15aa1a2471e07a5ea74080fd871ee9926d339/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/break-on-set-timeout-with-syntax-error.html
[modify] https://crrev.com/1bc15aa1a2471e07a5ea74080fd871ee9926d339/third_party/WebKit/Source/core/events/EventTarget.cpp
[modify] https://crrev.com/1bc15aa1a2471e07a5ea74080fd871ee9926d339/third_party/WebKit/Source/core/frame/DOMTimer.cpp
[modify] https://crrev.com/1bc15aa1a2471e07a5ea74080fd871ee9926d339/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp
[modify] https://crrev.com/1bc15aa1a2471e07a5ea74080fd871ee9926d339/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.h
[modify] https://crrev.com/1bc15aa1a2471e07a5ea74080fd871ee9926d339/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl

Comment 7 by kozyatinskiy@chromium.org, Apr 18 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment