Issue metadata
Sign in to add a comment
|
Remote inspecting of Chrome 49 on Android crashes DevTools |
||||||||||||||||||||||
Issue descriptionVersion: 49 OS: Android + Linux What steps will reproduce the problem? (1) Open Chrome 49 (stable) on Android (2) Connect USB debugging (3) Open about:inspect on desktop Chrome (using v52) (4) Inspect Chrome on mobile (any page will do) What is the expected output? DevTools opens remote inspector. What do you see instead? Remote inspector crashes during load. Message is seen in terminal: [16094:16094:0415/112831:ERROR:bad_message.cc(18)] Terminating renderer for bad IPC message, reason 18
,
Apr 15 2016
Comment
,
Apr 15 2016
This is due to fix for 584795 not being merged into 49. I'll see what we can do now.
,
Apr 16 2016
,
Apr 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/92efcfdf8fdbdb17af835a889ed6ee5bed729bca commit 92efcfdf8fdbdb17af835a889ed6ee5bed729bca Author: dgozman <dgozman@chromium.org> Date: Sat Apr 16 02:22:54 2016 [DevTools] Support broken UMA metric from M49 frontend. This patch mitigates bad message crash due to wrong UMA metric introduced in https://codereview.chromium.org/1520403004. It was reverted later, but was not merged to M49. BUG= 603789 Review URL: https://codereview.chromium.org/1892743005 Cr-Commit-Position: refs/heads/master@{#387793} [modify] https://crrev.com/92efcfdf8fdbdb17af835a889ed6ee5bed729bca/third_party/WebKit/Source/devtools/front_end/devtools.js
,
Apr 18 2016
Verified in mac canary 52.0.2711.0. Requesting merge to M50 if possible.
,
Apr 18 2016
[Automated comment] Less than a week to go before stable on M50, we might already have a stable candidate build. Manual review required.
,
Apr 18 2016
Merge approved for M50 branch 2661.
,
Apr 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2309aa35759fd1aaca9ab2d0f3e43ef000049bec commit 2309aa35759fd1aaca9ab2d0f3e43ef000049bec Author: Dmitry Gozman <dgozman@chromium.org> Date: Mon Apr 18 22:08:32 2016 Merge to 2661 "[DevTools] Support broken UMA metric from M49 frontend." > [DevTools] Support broken UMA metric from M49 frontend. > > This patch mitigates bad message crash due to wrong UMA metric > introduced in https://codereview.chromium.org/1520403004. > It was reverted later, but was not merged to M49. > > BUG= 603789 > > Review URL: https://codereview.chromium.org/1892743005 > > Cr-Commit-Position: refs/heads/master@{#387793} (cherry picked from commit 92efcfdf8fdbdb17af835a889ed6ee5bed729bca) TBR=caseq@chromium.org Review URL: https://codereview.chromium.org/1899963002 . Cr-Commit-Position: refs/branch-heads/2661@{#604} Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081} [modify] https://crrev.com/2309aa35759fd1aaca9ab2d0f3e43ef000049bec/third_party/WebKit/Source/devtools/front_end/devtools.js
,
Apr 18 2016
Looks fixed to me, reopen if more work is pending.
,
Apr 19 2016
Thanks for the quick resolution.
,
Apr 19 2016
Oh, do we need this in M51? Looks like the change landed after after branch, but didn't get merged to 2704? If so, merge approved, have fun! If not, just remove the merge approval tag.
,
Apr 19 2016
Yeah, this should be merged to M51 as well. But you have approved for 50, not for 51. Requesting merge approval for 51.
,
Apr 19 2016
Your change meets the bar and is auto-approved for M51 (branch: 2704)
,
Apr 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d6fee9b77b1a25fb9a0f0248d7b39a336063bcc3 commit d6fee9b77b1a25fb9a0f0248d7b39a336063bcc3 Author: Dmitry Gozman <dgozman@chromium.org> Date: Tue Apr 19 17:31:20 2016 Merge to 2704 "[DevTools] Support broken UMA metric from M49 frontend." > [DevTools] Support broken UMA metric from M49 frontend. > > This patch mitigates bad message crash due to wrong UMA metric > introduced in https://codereview.chromium.org/1520403004. > It was reverted later, but was not merged to M49. > > BUG= 603789 > > Review URL: https://codereview.chromium.org/1892743005 > > Cr-Commit-Position: refs/heads/master@{#387793} (cherry picked from commit 92efcfdf8fdbdb17af835a889ed6ee5bed729bca) TBR=caseq@chromium.org Review URL: https://codereview.chromium.org/1898253002 . Cr-Commit-Position: refs/branch-heads/2704@{#125} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} [modify] https://crrev.com/d6fee9b77b1a25fb9a0f0248d7b39a336063bcc3/third_party/WebKit/Source/devtools/front_end/devtools.js
,
Apr 19 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by samli@chromium.org
, Apr 15 2016Owner: dgozman@chromium.org