New issue
Advanced search Search tips

Issue 603785 link

Starred by 1 user
Status: Fixed
Owner:
nhiroki@chromium.org
Closed: Apr 2016
Cc:
yhirano@chromium.org
kinuko@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Rename worker classes with a more consistent naming convention

Project Member Reported by nhiroki@chromium.org, Apr 15 2016 
For historical reasons, names of worker classes are not well-consistent. We should rename them with a more consistent naming convention like this:

  1.) "Worker" prefix for classes used by all worker types
  2.) "DedicatedWorker" prefix for DedicatedWorker classes
  3.) "SharedWorker" prefix for SharedWorker classes
  4.) "ServiceWorker" (or "EmbeddedWorker") prefix for ServiceWorker classes
  5.) "CompositorWorker" prefix for CompositorWorker classes
  6.) "InProcessWorker" prefix for classes used by DedicatedWorker and
CompositorWorker
  7.) "Worklet" prefix for Worklet classes
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4334f65977df7d8c44f14b7cf2ecc2f32772a2a

commit c4334f65977df7d8c44f14b7cf2ecc2f32772a2a
Author: nhiroki <nhiroki@chromium.org>
Date: Tue Apr 19 08:16:40 2016

Worker: Rename worker components to clarify what they work for

(1) It sounds like WorkerGlobalScopeProxy is the base class of
ServiceWorkerGlobalScopeProxy, but it is not true. WorkerGlobalScopeProxy works
for in-process workers, namely, DedicatedWorker and CompositorWorker.
This patch renames them as follows:

  WorkerGlobalScopeProxy => InProcessWorkerGlobalScopeProxy
  WorkerMessagingProxy => InProcessWorkerMessagingProxy

(2) WorkerGlobalScopeProxyProvider provides a proxy for DedicatedWorker, so it
should be prefixed with "Dedicated":

  WorkerGlobalScopeProxyProvider => DedicatedWorkerGlobalScopeProxyProvider
  WorkerGlobalScopeProxyProviderImpl => DedicatedWorkerGlobalScopeProxyProviderImpl

BUG= 603785 

Review URL: https://codereview.chromium.org/1888703002

Cr-Commit-Position: refs/heads/master@{#388166}

[modify] https://crrev.com/c4334f65977df7d8c44f14b7cf2ecc2f32772a2a/third_party/WebKit/Source/core/core.gypi
[modify] https://crrev.com/c4334f65977df7d8c44f14b7cf2ecc2f32772a2a/third_party/WebKit/Source/core/frame/FrameConsole.cpp
[rename] https://crrev.com/c4334f65977df7d8c44f14b7cf2ecc2f32772a2a/third_party/WebKit/Source/core/workers/DedicatedWorkerGlobalScopeProxyProvider.cpp
[rename] https://crrev.com/c4334f65977df7d8c44f14b7cf2ecc2f32772a2a/third_party/WebKit/Source/core/workers/DedicatedWorkerGlobalScopeProxyProvider.h
[modify] https://crrev.com/c4334f65977df7d8c44f14b7cf2ecc2f32772a2a/third_party/WebKit/Source/core/workers/DedicatedWorkerMessagingProxy.cpp
[modify] https://crrev.com/c4334f65977df7d8c44f14b7cf2ecc2f32772a2a/third_party/WebKit/Source/core/workers/DedicatedWorkerMessagingProxy.h
[modify] https://crrev.com/c4334f65977df7d8c44f14b7cf2ecc2f32772a2a/third_party/WebKit/Source/core/workers/InProcessWorkerBase.cpp
[modify] https://crrev.com/c4334f65977df7d8c44f14b7cf2ecc2f32772a2a/third_party/WebKit/Source/core/workers/InProcessWorkerBase.h
[rename] https://crrev.com/c4334f65977df7d8c44f14b7cf2ecc2f32772a2a/third_party/WebKit/Source/core/workers/InProcessWorkerGlobalScopeProxy.h
[rename] https://crrev.com/c4334f65977df7d8c44f14b7cf2ecc2f32772a2a/third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp
[rename] https://crrev.com/c4334f65977df7d8c44f14b7cf2ecc2f32772a2a/third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.h
[modify] https://crrev.com/c4334f65977df7d8c44f14b7cf2ecc2f32772a2a/third_party/WebKit/Source/core/workers/Worker.cpp
[modify] https://crrev.com/c4334f65977df7d8c44f14b7cf2ecc2f32772a2a/third_party/WebKit/Source/core/workers/Worker.h
[modify] https://crrev.com/c4334f65977df7d8c44f14b7cf2ecc2f32772a2a/third_party/WebKit/Source/core/workers/WorkerObjectProxy.cpp
[modify] https://crrev.com/c4334f65977df7d8c44f14b7cf2ecc2f32772a2a/third_party/WebKit/Source/core/workers/WorkerObjectProxy.h
[modify] https://crrev.com/c4334f65977df7d8c44f14b7cf2ecc2f32772a2a/third_party/WebKit/Source/modules/compositorworker/CompositorWorker.cpp
[modify] https://crrev.com/c4334f65977df7d8c44f14b7cf2ecc2f32772a2a/third_party/WebKit/Source/modules/compositorworker/CompositorWorker.h
[modify] https://crrev.com/c4334f65977df7d8c44f14b7cf2ecc2f32772a2a/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerMessagingProxy.cpp
[modify] https://crrev.com/c4334f65977df7d8c44f14b7cf2ecc2f32772a2a/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerMessagingProxy.h
[rename] https://crrev.com/c4334f65977df7d8c44f14b7cf2ecc2f32772a2a/third_party/WebKit/Source/web/DedicatedWorkerGlobalScopeProxyProviderImpl.cpp
[rename] https://crrev.com/c4334f65977df7d8c44f14b7cf2ecc2f32772a2a/third_party/WebKit/Source/web/DedicatedWorkerGlobalScopeProxyProviderImpl.h
[modify] https://crrev.com/c4334f65977df7d8c44f14b7cf2ecc2f32772a2a/third_party/WebKit/Source/web/WebViewImpl.cpp
[modify] https://crrev.com/c4334f65977df7d8c44f14b7cf2ecc2f32772a2a/third_party/WebKit/Source/web/web.gypi
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/948cc542f74cad07c6d755222bab8063e5e649f2

commit 948cc542f74cad07c6d755222bab8063e5e649f2
Author: nhiroki <nhiroki@chromium.org>
Date: Tue Apr 19 12:57:09 2016

Worker: Rename worker components to clarify what they work for (part 2)

This CL renames WorkerObjectProxy to InProcessWorkerObjectProxy because
WorkerObjectProxy works only for in-process workers (DedicatedWorker and
CompositorWorker). In addition, this removes unnecessary header inclusions.

Part 1: https://codereview.chromium.org/1888703002/

BUG= 603785 

Review URL: https://codereview.chromium.org/1897193002

Cr-Commit-Position: refs/heads/master@{#388194}

[modify] https://crrev.com/948cc542f74cad07c6d755222bab8063e5e649f2/third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp
[modify] https://crrev.com/948cc542f74cad07c6d755222bab8063e5e649f2/third_party/WebKit/Source/core/core.gypi
[modify] https://crrev.com/948cc542f74cad07c6d755222bab8063e5e649f2/third_party/WebKit/Source/core/workers/DedicatedWorkerGlobalScope.cpp
[modify] https://crrev.com/948cc542f74cad07c6d755222bab8063e5e649f2/third_party/WebKit/Source/core/workers/DedicatedWorkerGlobalScope.h
[modify] https://crrev.com/948cc542f74cad07c6d755222bab8063e5e649f2/third_party/WebKit/Source/core/workers/DedicatedWorkerThread.cpp
[modify] https://crrev.com/948cc542f74cad07c6d755222bab8063e5e649f2/third_party/WebKit/Source/core/workers/DedicatedWorkerThread.h
[modify] https://crrev.com/948cc542f74cad07c6d755222bab8063e5e649f2/third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp
[modify] https://crrev.com/948cc542f74cad07c6d755222bab8063e5e649f2/third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.h
[rename] https://crrev.com/948cc542f74cad07c6d755222bab8063e5e649f2/third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.cpp
[rename] https://crrev.com/948cc542f74cad07c6d755222bab8063e5e649f2/third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.h
[modify] https://crrev.com/948cc542f74cad07c6d755222bab8063e5e649f2/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp
[modify] https://crrev.com/948cc542f74cad07c6d755222bab8063e5e649f2/third_party/WebKit/Source/core/workers/WorkerThread.cpp
[modify] https://crrev.com/948cc542f74cad07c6d755222bab8063e5e649f2/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerGlobalScope.cpp
[modify] https://crrev.com/948cc542f74cad07c6d755222bab8063e5e649f2/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThread.cpp
[modify] https://crrev.com/948cc542f74cad07c6d755222bab8063e5e649f2/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThread.h
[modify] https://crrev.com/948cc542f74cad07c6d755222bab8063e5e649f2/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp

Comment 3 by nhiroki@chromium.org, Apr 22 2016

Status: Fixed (was: Started)

Comment 4 by nabila...@gmail.com, May 27 2016 

Start for all option
►

Sign in to add a comment