New issue
Advanced search Search tips

Issue 603776 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Network Quality prediction accuracy for Lo-Fi should be recorded X seconds after main frame request

Project Member Reported by tbansal@chromium.org, Apr 15 2016

Issue description

Currently, the Lo-Fi code in data reduction proxy records the accuracy of network quality prediction on every main frame request. For example, when a main frame HTTP request is seen (say at t=0), network quality prediction is stored in a variable.  When the next main frame HTTP request is seen (say at t=t1), the observed network quality during the time period from t=0 to t=t1 is computed, and compared with the stored prediction.

This has 2 problems: (i) User may not load the next web page (or may load a HTTPS web page), and thus the accuracy metric may not be recorded (ii) The interval between t=0 and t=t1 may be too large, and thus comparing the prediction with the observations may be meaningless.

Instead, we should record the accuracy of prediction at t=15, 30 and 60 seconds by posting tasks at t=0.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27cdb3ee8a113505f55cde29bb6a6a115d34a815

commit 27cdb3ee8a113505f55cde29bb6a6a115d34a815
Author: tbansal <tbansal@chromium.org>
Date: Tue Apr 19 23:13:24 2016

Record Lo-Fi NQE prediction accuracy at different intervals

When a main frame request is seen, the predicted network
quality is stored locally in a variable. After t seconds,
observed network quality is computed from all samples taken
in last t seconds. Accuracy is recorded based on comparison
between the predicted quality and the observed quality.
Currently, t is set to 15, 30 and 60 seconds.

The new histogram is of the format
"DataReductionProxy.LoFi.Accuracy.[0-9]*.[ConnectionType]"

The older histogram has been obsoleted.

BUG= 603776 

Review URL: https://codereview.chromium.org/1889873005

Cr-Commit-Position: refs/heads/master@{#388345}

[modify] https://crrev.com/27cdb3ee8a113505f55cde29bb6a6a115d34a815/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc
[modify] https://crrev.com/27cdb3ee8a113505f55cde29bb6a6a115d34a815/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h
[modify] https://crrev.com/27cdb3ee8a113505f55cde29bb6a6a115d34a815/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_test_utils.cc
[modify] https://crrev.com/27cdb3ee8a113505f55cde29bb6a6a115d34a815/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_test_utils.h
[modify] https://crrev.com/27cdb3ee8a113505f55cde29bb6a6a115d34a815/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc
[modify] https://crrev.com/27cdb3ee8a113505f55cde29bb6a6a115d34a815/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate_unittest.cc
[modify] https://crrev.com/27cdb3ee8a113505f55cde29bb6a6a115d34a815/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.cc
[modify] https://crrev.com/27cdb3ee8a113505f55cde29bb6a6a115d34a815/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc
[modify] https://crrev.com/27cdb3ee8a113505f55cde29bb6a6a115d34a815/components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc
[modify] https://crrev.com/27cdb3ee8a113505f55cde29bb6a6a115d34a815/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Started)
Components: Internals>Network>NetworkQuality

Sign in to add a comment