hey Michael,

which suite are you trying to start?

and can you point me to your moblab so I Can dig around?

The issue is that AFE tries to load the suite control file which does not exist in local autotest, as the control file list is loaded from a build, which contains private suite.

We might have to pass the control file content along with the names, not sure if that will make the page content too big too load (or that's something we can cache on the server side?)

@kevcheng, ping-ed you the information you need.

@dshi, I remember somebody mentioned private tests already work with moblab? Or it only works if it is simple client tests? Since for server side tests, the control file is run on the moblab device (inside a drone container), so the moblab device need to have access to control files?

yes, private tests can certainly work in moblab.

This issue is just limited to AFE UI.

+ Aviv to add more details on the work around

To sbasi@ who I believe is in the middle if implementing a way to launch meta-suites from the web afe.

That new interface should be a good workaround for this issue too. You will be able to launch a suite with the attribute string "suite:foo" where foo is the name of your private suite. That method will create a suite purely based on which test control files match that suite, without need a suite control file.

Any workaround and detailed instructions to run the private test suites manually on the moblab devices? 

run_suite command line should just work. You can specify the build/board/pool/suite name in the command line.

Here's an example command:

/usr/local/autotest/site_utils/run_suite.py --run_prod_code --pool=bvt --timeout_mins=90 --suite_name=brillo-bvt --build=git_mnc-brillo-dev/dragonboard-eng/LATEST --board=brillo-dragonboard -c

The '-c' at the end tells the command to return after it has started so you can just track it through afe with the jobid.

Thanks all the info. The command line works.

The job is scheduled but all tests still failed with "... test does not exist". Is it possible to specify "require ssp" on the command line?

@sbasis did a run with "run_suite" command line last night, and most test job is created and the most tests seem to pass now. So we just need to support job creation  via the AFE now.

kk so heres the problem with the UI:

IOError: [Errno 2] No such file or directory: '/usr/local/autotest/test_suites/control.arc-cts'
Traceback (most recent call last):
  File "/usr/local/autotest/frontend/afe/json_rpc/serviceHandler.py", line 114, in dispatchRequest
    results['result'] = self.invokeServiceEndpoint(meth, args)
  File "/usr/local/autotest/frontend/afe/json_rpc/serviceHandler.py", line 154, in invokeServiceEndpoint
    return meth(*args)
  File "/usr/local/autotest/frontend/afe/rpc_handler.py", line 125, in new_fn
    return f(*args, **keyword_args)
  File "/usr/local/autotest/frontend/afe/rpc_interface.py", line 801, in generate_control_file
    upload_kernel_config=upload_kernel_config)
  File "/usr/local/autotest/frontend/afe/control_file.py", line 394, in generate_control
    client_control_file)
  File "/usr/local/autotest/frontend/afe/control_file.py", line 236, in get_tests_stanza
    raw_control_files = [read_control_file(test) for test in tests]
  File "/usr/local/autotest/frontend/afe/control_file.py", line 157, in read_control_file
    control_file = open(os.path.join(AUTOTEST_DIR, test.path))
IOError: [Errno 2] No such file or directory: '/usr/local/autotest/test_suites/control.arc-cts'

Its searching for the control file contents from the local storage.

Here's what we should make it do:
* Update generate_control_file in rpc_interface.py to accept an optional build argument and have the UI pass it from the selected element in "Test source build"
* Refactor site_rpc_interface.py:get_tests_by_build to allow you to specify a control file name and get its contents.
* Have generate_control_file use the refactored code to get the contents and return that.

Michael does that info help unblock you or do you need me to jump in more?

I can follow up on this and try to come up with a fix.

Start to work on the UI fix.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/84a2ecf3422e6b7f52ffd4628e4a8d47dbe53b4e

commit 84a2ecf3422e6b7f52ffd4628e4a8d47dbe53b4e
Author: Michael Tang <ntang@google.com>
Date: Tue Jun 07 22:10:53 2016

Enabled create test job out of private test build.

We now allow user to have a test source build containing tests not
present in the moblab and its database. The user could fetch those tests
and select them to create jobs.

BUG= chromium:603774 
TEST=manually tests and some unit test.

Change-Id: I4aecb922b006a0743ef4cb223f555fac7343c6c0
Reviewed-on: https://chromium-review.googlesource.com/351480
Commit-Ready: Michael Tang <ntang@chromium.org>
Tested-by: Michael Tang <ntang@chromium.org>
Reviewed-by: Michael Tang <ntang@chromium.org>
Reviewed-by: Dan Shi <dshi@google.com>

[modify] https://crrev.com/84a2ecf3422e6b7f52ffd4628e4a8d47dbe53b4e/frontend/afe/rpc_utils.py
[modify] https://crrev.com/84a2ecf3422e6b7f52ffd4628e4a8d47dbe53b4e/frontend/afe/site_rpc_interface.py
[add] https://crrev.com/84a2ecf3422e6b7f52ffd4628e4a8d47dbe53b4e/frontend/afe/rpc_utils_unittest.py
[modify] https://crrev.com/84a2ecf3422e6b7f52ffd4628e4a8d47dbe53b4e/frontend/client/src/autotest/public/AfeClient.html
[modify] https://crrev.com/84a2ecf3422e6b7f52ffd4628e4a8d47dbe53b4e/frontend/client/src/autotest/afe/create/CreateJobViewPresenter.java
[modify] https://crrev.com/84a2ecf3422e6b7f52ffd4628e4a8d47dbe53b4e/frontend/afe/control_file.py
[modify] https://crrev.com/84a2ecf3422e6b7f52ffd4628e4a8d47dbe53b4e/frontend/client/src/autotest/afe/create/CreateJobViewDisplay.java
[modify] https://crrev.com/84a2ecf3422e6b7f52ffd4628e4a8d47dbe53b4e/frontend/afe/rpc_interface.py