New issue
Advanced search Search tips

Issue 603767 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

layout test failure: timeline-auto-record.html

Project Member Reported by rjkroege@chromium.org, Apr 14 2016

Issue description

Summary: layout test failure: timeline-auto-record.html (was: layout test failure)
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd2789fc35981800496a993e864ca0851e7e512c

commit dd2789fc35981800496a993e864ca0851e7e512c
Author: rjkroege <rjkroege@chromium.org>
Date: Fri Apr 15 01:24:06 2016

Mark timeline-auto-record.html as failing.

BUG= 603767 
TBR=pfeldman@chromium.org

Review URL: https://codereview.chromium.org/1888293002

Cr-Commit-Position: refs/heads/master@{#387511}

[modify] https://crrev.com/dd2789fc35981800496a993e864ca0851e7e512c/third_party/WebKit/LayoutTests/TestExpectations

Comment 3 by caseq@chromium.org, Apr 15 2016

Components: Platform>DevTools>Performance
Owner: caseq@chromium.org
Status: Assigned (was: Available)

Comment 4 by caseq@chromium.org, Apr 15 2016

Owner: alph@chromium.org
This is because of https://codereview.chromium.org/1873973002 / https://crrev.com/1c33b9ee4940826b3a972c093cbc3f8e1f1b3f50, we die within TimelinePanel.loadingComplete() with

    at bottomNode (file:///usr/local/google/home/caseq/src/out/Release/resources/inspector/sdk/CPUProfileDataModel.js:285:31)
    at Object._fixMissingSamples (file:///usr/local/google/home/caseq/src/out/Release/resources/inspector/sdk/CPUProfileDataModel.js:272:20)
    at Object.WebInspector.CPUProfileDataModel (file:///usr/local/google/home/caseq/src/out/Release/resources/inspector/sdk/CPUProfileDataModel.js:49:14)
    at Object._processThreadEvents (file:///usr/local/google/home/caseq/src/out/Release/resources/inspector/timeline/TimelineModel.js:730:42)
    at Object.setEvents (file:///usr/local/google/home/caseq/src/out/Release/resources/inspector/timeline/TimelineModel.js:496:22)
    at Object.loadingComplete (file:///usr/local/google/home/caseq/src/out/Release/resources/inspector/timeline/TimelinePanel.js:810:21)

Project Member

Comment 5 by bugdroid1@chromium.org, Apr 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94073b57d00d8ebd7597163b39d90980ae8d176c

commit 94073b57d00d8ebd7597163b39d90980ae8d176c
Author: caseq <caseq@chromium.org>
Date: Fri Apr 15 22:11:25 2016

Revert of DevTools: extract CPU profile independent part of CPUProfileNode. (patchset #3 id:40001 of https://codereview.chromium.org/1873973002/ )

Reason for revert:
This broke at least two timeline tests with Cannot read property 'parent' of null

BUG= 603767 

Original issue's description:
> DevTools: extract CPU profile independent part of CPUProfileNode.
>
> This is a prerequisite to make the profile node class reused for sampling heap profiler.
>
> BUG= 586613 
>
> Committed: https://crrev.com/1c33b9ee4940826b3a972c093cbc3f8e1f1b3f50
> Cr-Commit-Position: refs/heads/master@{#387249}

TBR=alph@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 586613 

Review URL: https://codereview.chromium.org/1889963003

Cr-Commit-Position: refs/heads/master@{#387716}

[modify] https://crrev.com/94073b57d00d8ebd7597163b39d90980ae8d176c/third_party/WebKit/LayoutTests/inspector/profiler/cpu-profiler-bottom-up-times-expected.txt
[modify] https://crrev.com/94073b57d00d8ebd7597163b39d90980ae8d176c/third_party/WebKit/LayoutTests/inspector/profiler/cpu-profiler-bottom-up-times.html
[modify] https://crrev.com/94073b57d00d8ebd7597163b39d90980ae8d176c/third_party/WebKit/LayoutTests/inspector/profiler/cpu-profiler-calculate-time.html
[modify] https://crrev.com/94073b57d00d8ebd7597163b39d90980ae8d176c/third_party/WebKit/LayoutTests/inspector/profiler/cpu-profiler-flame-chart-overview.html
[modify] https://crrev.com/94073b57d00d8ebd7597163b39d90980ae8d176c/third_party/WebKit/LayoutTests/inspector/profiler/cpu-profiler-native-nodes-filter-expected.txt
[modify] https://crrev.com/94073b57d00d8ebd7597163b39d90980ae8d176c/third_party/WebKit/LayoutTests/inspector/profiler/cpu-profiler-native-nodes-filter.html
[modify] https://crrev.com/94073b57d00d8ebd7597163b39d90980ae8d176c/third_party/WebKit/Source/devtools/devtools.gypi
[modify] https://crrev.com/94073b57d00d8ebd7597163b39d90980ae8d176c/third_party/WebKit/Source/devtools/front_end/sdk/CPUProfileDataModel.js
[delete] https://crrev.com/6bb171a404c2e9a951a1c8c980fc316da4b7fd7c/third_party/WebKit/Source/devtools/front_end/sdk/ProfileTreeModel.js
[modify] https://crrev.com/94073b57d00d8ebd7597163b39d90980ae8d176c/third_party/WebKit/Source/devtools/front_end/sdk/module.json

Project Member

Comment 6 by bugdroid1@chromium.org, Apr 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b522a931476861f1256896c56da8958a6111b91

commit 8b522a931476861f1256896c56da8958a6111b91
Author: caseq <caseq@chromium.org>
Date: Fri Apr 15 22:26:24 2016

Revert of Mark timeline-auto-record.html as failing. (patchset #1 id:1 of https://codereview.chromium.org/1888293002/ )

Reason for revert:
The test should work now as the offending CL was reverted.

Original issue's description:
> Mark timeline-auto-record.html as failing.
>
> BUG= 603767 
> TBR=pfeldman@chromium.org
>
> Committed: https://crrev.com/dd2789fc35981800496a993e864ca0851e7e512c
> Cr-Commit-Position: refs/heads/master@{#387511}

TBR=pfeldman@chromium.org,rjkroege@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 603767 

Review URL: https://codereview.chromium.org/1889353003

Cr-Commit-Position: refs/heads/master@{#387725}

[modify] https://crrev.com/8b522a931476861f1256896c56da8958a6111b91/third_party/WebKit/LayoutTests/TestExpectations

Comment 7 by alph@chromium.org, Apr 20 2016

Status: Fixed (was: Assigned)

Comment 8 by sshru...@google.com, May 18 2016

Labels: Test-Layout

Sign in to add a comment