New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 603758 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
cwp



Sign in to add a comment

cc::RollingTimeDeltaHistory::InsertSample has risen from 0.01% to ~0.05% over time

Project Member Reported by sque@chromium.org, Apr 14 2016

Issue description

Seen in periodic CWP data, on both ARM and x86_64.

Need further investigation to see why.
 
cc::RollingTimeDeltaHistory::InsertSample ARM.png
23.5 KB View Download
cc::RollingTimeDeltaHistory::InsertSample x86_64.png
25.2 KB View Download
This is now closer to 0.1% as of Chrome 50. The usages of this have windows of size 10, 60, and 1000. Given the microsecond precision of base::TimeDelta, duplicates are probably rare, so storing the entries in a multiset is unlikely to be beneficial.

Since it is the inserts which are slow, perhaps it would be much simpler to just use a dequeue<int64_t>, and compute percentiles by a copy, sort, index, and return a TimeDelta.
Components: Internals

Sign in to add a comment