New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 603753 link

Starred by 3 users
Status: Fixed
Owner:
█ wkorman@chromium.org
Last visit > 30 days ago
Closed: May 2016
Cc:
█ tansell@chromium.org
wangxianzhu@chromium.org
liber...@chromium.org
esprehn@chromium.org
ojan@chromium.org
e...@chromium.org
█ wkorman@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 0
Type: Bug

Blocking:
issue 601166



Sign in to add a comment

blink auto-rebaseline-bot is down (intentionally)

Project Member Reported by dpranke@chromium.org, Apr 14 2016 
As a result of  bug 601166 , I have stopped the blink-autorebaseline-bot.

This is bad, and we need to turn it back on ASAP to minimize the impact on blink devs, but we need to make sure that when we turn it back on it doesn't make  bug 601166  worse.

To turn this back on we need to either figure out why the bots are getting different baselines, or fix the ARB so that it doesn't rebaseline tests that are marked Failure (or strip lines marked Failure for tests that weren't rebaselined).

An attempt at the latter was made in https://codereview.chromium.org/1412533002 ; we could just pick that up and make it work.

Comment 1 by wkorman@chromium.org, Apr 15 2016

Owner: wkorman@chromium.org
Status: Assigned (was: Available)
I can look at this with  http://crbug.com/601166  tomorrow but I've found working on that script can take a surprising amount of time so ETA uncertain. Fixing the Mac baselines may be faster. Will update as more info available.

Comment 2 by dpranke@chromium.org, Apr 15 2016 

I can almost guarantee that fixing the baselines will not be faster, but feel free to prove me wrong :).
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f6db60551a6cd52e4c0638a1ed669eecf25af3b

commit 5f6db60551a6cd52e4c0638a1ed669eecf25af3b
Author: dpranke <dpranke@chromium.org>
Date: Fri Apr 15 05:24:41 2016

Make NeedsRebaseline illegal in layout_test TestExpectations for now.

In order to keep too many NeedsRebaseline lines from piling up
in the TestExpectations while the auto-rebaseline-bot is down
(and causing us to potentially miss breakages as a result), this
change makes checking in NeedsRebaseline illegal (like Rebaseline currently
is).

Users can still manually rebaseline things if need be.

We should revert this change once the auto-rebaseline-bot is back up.

R=esprehn@chromium.org, ojan@chromium.org, wkorman@chromium.org
BUG= 603753 

Review URL: https://codereview.chromium.org/1888963003

Cr-Commit-Position: refs/heads/master@{#387539}

[modify] https://crrev.com/5f6db60551a6cd52e4c0638a1ed669eecf25af3b/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/5f6db60551a6cd52e4c0638a1ed669eecf25af3b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py
[modify] https://crrev.com/5f6db60551a6cd52e4c0638a1ed669eecf25af3b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py
[modify] https://crrev.com/5f6db60551a6cd52e4c0638a1ed669eecf25af3b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py

Comment 4 by sshru...@google.com, Apr 18 2016

Components: -Blink>ToolsTest Blink>Infra
Blink>ToolsTest renamed to Blink>Infra

Comment 6 by wkorman@chromium.org, Apr 24 2016

Status: Fixed (was: Assigned)

Comment 7 by wkorman@chromium.org, Apr 25 2016

Status: Started (was: Fixed)
Reopening as root issue turns out to not yet be resolved.

Comment 11 by liber...@chromium.org, Apr 26 2016

Cc: liber...@chromium.org

Comment 13 by wkorman@chromium.org, May 3 2016

Status: Fixed (was: Started)
►

Sign in to add a comment