New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 603744 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Dec 27
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"RecentTabsSubMenuModelTest.MaxSessionsAndRecency" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Apr 14 2016

Issue description

"RecentTabsSubMenuModelTest.MaxSessionsAndRecency" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 4 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyOwsSBUZsYWtlIjBSZWNlbnRUYWJzU3ViTWVudU1vZGVsVGVzdC5NYXhTZXNzaW9uc0FuZFJlY2VuY3kM.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Disabling the test.
Labels: -Sheriff-Chromium
Owner: finnur@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/325e1b5f4a227912744dd561163884d734f02de6

commit 325e1b5f4a227912744dd561163884d734f02de6
Author: rjkroege <rjkroege@chromium.org>
Date: Fri Apr 15 01:37:13 2016

Suppress flaky test RecentTabsSubMenuModelTest MaxSessionsAndRecency

BUG= 603744 
TBR=finnur@chromium.org

Review URL: https://codereview.chromium.org/1891663003

Cr-Commit-Position: refs/heads/master@{#387513}

[modify] https://crrev.com/325e1b5f4a227912744dd561163884d734f02de6/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model_unittest.cc

Comment 4 by finnur@chromium.org, Apr 15 2016

Cc: tim@chromium.org
Owner: kuan@chromium.org
Never seen this test before. Think I have been assigned this by mistake. Re-assigning and CC-ing a couple of people modifying this most recently.
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f921fc4349a5fbff31a4e3953f172e3841abdd8b

commit f921fc4349a5fbff31a4e3953f172e3841abdd8b
Author: jam <jam@chromium.org>
Date: Fri Apr 15 18:13:34 2016

Fix suppress flaky test RecentTabsSubMenuModelTest MaxSessionsAndRecency

BUG= 603744 
TBR=rjkroege@chromium.org

Review URL: https://codereview.chromium.org/1891323002

Cr-Commit-Position: refs/heads/master@{#387645}

[modify] https://crrev.com/f921fc4349a5fbff31a4e3953f172e3841abdd8b/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model_unittest.cc

Cc: edwardjung@chromium.org
Status: Assigned (was: Untriaged)
The test non-flakily fails under DrMemory-full since https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28DrMemory%20full%29%20%282%29/builds/10471, if that helps diagnose it.
Project Member

Comment 7 by chromium...@appspot.gserviceaccount.com, Apr 15 2016

Labels: Sheriff-Chromium
Detected 17 new flakes for test/step "RecentTabsSubMenuModelTest.MaxSessionsAndRecency". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyOwsSBUZsYWtlIjBSZWNlbnRUYWJzU3ViTWVudU1vZGVsVGVzdC5NYXhTZXNzaW9uc0FuZFJlY2VuY3kM. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
Project Member

Comment 8 by chromium...@appspot.gserviceaccount.com, Apr 18 2016

Detected 3 new flakes for test/step "RecentTabsSubMenuModelTest.MaxSessionsAndRecency". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyOwsSBUZsYWtlIjBSZWNlbnRUYWJzU3ViTWVudU1vZGVsVGVzdC5NYXhTZXNzaW9uc0FuZFJlY2VuY3kM. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).

Comment 9 by perkj@chromium.org, Apr 18 2016

Labels: -Sheriff-Chromium
Project Member

Comment 10 by bugdroid1@chromium.org, Apr 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8b99e573c4c1c9e5932fc8c76d1c927279b902e

commit c8b99e573c4c1c9e5932fc8c76d1c927279b902e
Author: Per <perkj@chromium.org>
Date: Mon Apr 18 11:21:47 2016

Disable flaky RecentTabsSubMenuModelTest.MaxSessionsAndRecency on OSX Already disabled on linux and win.

BUG= 603744 
TBR=kuan@chromium.org

Review URL: https://codereview.chromium.org/1893303002 .

Cr-Commit-Position: refs/heads/master@{#387890}

[modify] https://crrev.com/c8b99e573c4c1c9e5932fc8c76d1c927279b902e/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model_unittest.cc

Labels: Hotlist-Recharge-BouncingOwner
Owner: ----
Status: Untriaged (was: Assigned)
This owner is not able to receive e-mails, please re-triage.
Status: Fixed (was: Untriaged)
This was fixed and re-enabled in https://codereview.chromium.org/2768633003/ .

Sign in to add a comment