New issue
Advanced search Search tips

Issue 603730 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: ----



Sign in to add a comment

Pdfviewer is no longer getting correct referrer when clicking a pdf link

Project Member Reported by qin...@chromium.org, Apr 14 2016

Issue description

Chrome used to send android-app://com.android.chrome as referrer to pdfviewer.

But we are no longer doing that, instead we are sending the http url referrer
 
Status: Assigned (was: Unconfirmed)
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/30be6d55e09751882232f06ee0db9541d7a201bd

commit 30be6d55e09751882232f06ee0db9541d7a201bd
Author: qinmin <qinmin@chromium.org>
Date: Wed Apr 20 18:22:49 2016

Fix an issue that referrer field is no longer exposed to pdfviewer

New pdfviewer starts to handle http scheme.
As a result, clicking a pdf link will no longer trigger a download.
Instead, the navigation will be intercepted and passed to pdfviewer.
We previously added the referrer extra for analytics purpose for pdfviewer.
But that only happens in the download code.
This CL fixes the referrer field issue for intercepted navigations.

BUG= 603730 

Review URL: https://codereview.chromium.org/1887173003

Cr-Commit-Position: refs/heads/master@{#388535}

[modify] https://crrev.com/30be6d55e09751882232f06ee0db9541d7a201bd/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
[modify] https://crrev.com/30be6d55e09751882232f06ee0db9541d7a201bd/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java

Comment 3 by qin...@chromium.org, Apr 28 2016

Status: Fixed (was: Assigned)

Sign in to add a comment