New issue
Advanced search Search tips

Issue 603709 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 546840
issue 604624



Sign in to add a comment

[Reset] Mocks for showing settings that are being reported.

Project Member Reported by dpa...@chromium.org, Apr 14 2016

Issue description

In the old Options the user can see the settings that are being reported before resetting them (see old_reset_dialog_expanded.png).

Currently in the new settings this section is not styled at all and looks broken (see current_reset_settings_dialog_expanded.png).

There has been discussion on the past about this, but we still have not reached a resolution. Maybe a reasonable UI would be the one shown at suggestion_reset_dialog_expanded.png (ignore obsolete style at the top part of the screenshot).
 
old_reset_dialog_expanded.png
114 KB View Download
current_reset_dialog_expanded.png
160 KB View Download
suggestion_reset_dialog_expanded.png
70.4 KB View Download
Status: Assigned (was: Untriaged)
A few options I can think of:

1) I like the styling in the suggested mock, but I'm worried it's taking up too much space. Maybe we could put it inside a scrollbox so that we can cap its height?

2) Have a "View reported settings" link that takes the user to a new tab containing only the information.

3) A more significant change would be to consider making this dialog into a sub-page. Then these properties could perhaps follow a similar style to About CrOS [1]

[1] https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/preview/cards#%2FPREVIEW-About_ChromeOS.png%3Fz=half

Alan, what do you think?

Comment 2 by dpa...@chromium.org, Apr 15 2016

I'll let Alan speak on what is better UX-wise, I'll just comment on the estimated amount of work required for options 1,2,3 mentioned by @tbuckley.

1) Adding a max height and using a scroll-bar if necessary sounds the easiest option to implement.

2) Alan had mentioned this option in the past along with a similar option of clicking on a button that prompts the user to download the reported settings in a txt file. Either of those seem more complex than solution 1 above.

3) Modifying the dialog to a subpage seems more costly than both 1 and 2, and also might feel a bit odd on ChromeOS, where the "powerwash" functionality will still  be exposed as a dialog but the "reset settings" as a subpage.

Summary: [Reset] Mocks for showing settings that are being reported. (was: Mocks for showing settings that are being reported.)
Labels: -Pri-2 Pri-1

Comment 5 by bettes@chromium.org, Apr 18 2016

Cc: bettes@chromium.org
Owner: dpa...@chromium.org
I prefer option 2, surfacing the data un-styled and in a separate tab

1.) Although technically easier, this is a really bad experience, dedicating a lot of real estate for relatively insignificant information 

3.) Again, don't think this information is worthy of a sub-page.  

Comment 6 by dpa...@chromium.org, Apr 19 2016

Cc: dbeam@chromium.org
Thanks Alan, will move forward with option 2.

@dbeam: I looked up whether extensions can read the contents of "about:blank" and it seems that they can't. Can you verify? Otherwise displaying the reset settings info in a new tab might be exposing such info.

Comment 7 by dbeam@chromium.org, Apr 19 2016

Cc: rdevlin....@chromium.org
dpapad@/#c6: depends on whether chrome://flags/#extensions-on-chrome-urls is enabled, I'd guess
@6 Extensions about:blank access is funny.  In most cases, we try to follow the web model, where an extension can access an about:blank frame if it can access the opener of that frame.  So you'll probably be okay if the opener is a chrome settings page (unless, as dbeam@ points out, extensions are allowed to act on chrome urls).  All that said, it'd probably be nicer to just have some chrome url associated with chrome info, IMO.

Comment 9 by dpa...@chromium.org, Apr 19 2016

Blocking: 604624
Status: Started (was: Assigned)
@bettes: Please verify that this issue is addressed. See screenshots at http://imgur.com/a/LbWBS. Clicking on the question mark icon triggers the new tab to open.
Thanks Demetrios! A couple requests:

1) Replace the (?) icon with a link reading "View reported settings". So it should be "Help make Chromium better by reporting the current settings. [View reported settings]". We're trying to only use the (?) icon for tooltips.

2) Less JSON-y formatting on the page that's opened. Eg:
Locale: en-US
User Agent: ...
Chromium: ...
Startup URLs: md-settings
...
Extensions: Web Store, Bookmark Manager, Settings, ...
@tbuckley: Does http://imgur.com/a/bJgmu look OK?

The only caveat is that some text overflows to the right (which was not happening with the JSON approach), but I think this is not a real issue, this UI is not meant to be styled anyway (per comment#5).
Looks good to me!
Project Member

Comment 16 by bugdroid1@chromium.org, Apr 25 2016

Status: Fixed (was: Started)

Sign in to add a comment