[Reset] Mocks for showing settings that are being reported. |
|||||||||
Issue descriptionIn the old Options the user can see the settings that are being reported before resetting them (see old_reset_dialog_expanded.png). Currently in the new settings this section is not styled at all and looks broken (see current_reset_settings_dialog_expanded.png). There has been discussion on the past about this, but we still have not reached a resolution. Maybe a reasonable UI would be the one shown at suggestion_reset_dialog_expanded.png (ignore obsolete style at the top part of the screenshot).
,
Apr 15 2016
I'll let Alan speak on what is better UX-wise, I'll just comment on the estimated amount of work required for options 1,2,3 mentioned by @tbuckley. 1) Adding a max height and using a scroll-bar if necessary sounds the easiest option to implement. 2) Alan had mentioned this option in the past along with a similar option of clicking on a button that prompts the user to download the reported settings in a txt file. Either of those seem more complex than solution 1 above. 3) Modifying the dialog to a subpage seems more costly than both 1 and 2, and also might feel a bit odd on ChromeOS, where the "powerwash" functionality will still be exposed as a dialog but the "reset settings" as a subpage.
,
Apr 18 2016
,
Apr 18 2016
,
Apr 18 2016
I prefer option 2, surfacing the data un-styled and in a separate tab 1.) Although technically easier, this is a really bad experience, dedicating a lot of real estate for relatively insignificant information 3.) Again, don't think this information is worthy of a sub-page.
,
Apr 19 2016
Thanks Alan, will move forward with option 2. @dbeam: I looked up whether extensions can read the contents of "about:blank" and it seems that they can't. Can you verify? Otherwise displaying the reset settings info in a new tab might be exposing such info.
,
Apr 19 2016
dpapad@/#c6: depends on whether chrome://flags/#extensions-on-chrome-urls is enabled, I'd guess
,
Apr 19 2016
@6 Extensions about:blank access is funny. In most cases, we try to follow the web model, where an extension can access an about:blank frame if it can access the opener of that frame. So you'll probably be okay if the opener is a chrome settings page (unless, as dbeam@ points out, extensions are allowed to act on chrome urls). All that said, it'd probably be nicer to just have some chrome url associated with chrome info, IMO.
,
Apr 19 2016
,
Apr 20 2016
,
Apr 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c740e34d19834b978e7f6cfc91ec1d07b5e64b03 commit c740e34d19834b978e7f6cfc91ec1d07b5e64b03 Author: dpapad <dpapad@chromium.org> Date: Thu Apr 21 18:11:27 2016 MD Settings: Reset profile dialog, display settings in new tab. BUG= 603709 , 604624 Review URL: https://codereview.chromium.org/1911573003 Cr-Commit-Position: refs/heads/master@{#388814} [modify] https://crrev.com/c740e34d19834b978e7f6cfc91ec1d07b5e64b03/chrome/browser/resources/settings/reset_page/reset_browser_proxy.js [modify] https://crrev.com/c740e34d19834b978e7f6cfc91ec1d07b5e64b03/chrome/browser/resources/settings/reset_page/reset_profile_dialog.html [modify] https://crrev.com/c740e34d19834b978e7f6cfc91ec1d07b5e64b03/chrome/browser/resources/settings/reset_page/reset_profile_dialog.js [modify] https://crrev.com/c740e34d19834b978e7f6cfc91ec1d07b5e64b03/chrome/browser/ui/webui/settings/reset_settings_handler.cc [modify] https://crrev.com/c740e34d19834b978e7f6cfc91ec1d07b5e64b03/chrome/browser/ui/webui/settings/reset_settings_handler.h [modify] https://crrev.com/c740e34d19834b978e7f6cfc91ec1d07b5e64b03/chrome/test/data/webui/settings/reset_page_test.js
,
Apr 21 2016
@bettes: Please verify that this issue is addressed. See screenshots at http://imgur.com/a/LbWBS. Clicking on the question mark icon triggers the new tab to open.
,
Apr 21 2016
Thanks Demetrios! A couple requests: 1) Replace the (?) icon with a link reading "View reported settings". So it should be "Help make Chromium better by reporting the current settings. [View reported settings]". We're trying to only use the (?) icon for tooltips. 2) Less JSON-y formatting on the page that's opened. Eg: Locale: en-US User Agent: ... Chromium: ... Startup URLs: md-settings ... Extensions: Web Store, Bookmark Manager, Settings, ...
,
Apr 21 2016
@tbuckley: Does http://imgur.com/a/bJgmu look OK? The only caveat is that some text overflows to the right (which was not happening with the JSON approach), but I think this is not a real issue, this UI is not meant to be styled anyway (per comment#5).
,
Apr 21 2016
Looks good to me!
,
Apr 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cfc480b7040cddca093748c383ea1c3299d9088f commit cfc480b7040cddca093748c383ea1c3299d9088f Author: dpapad <dpapad@chromium.org> Date: Mon Apr 25 22:18:56 2016 MD Settings: Tweak "View reported settings" UI in reset settings profile. BUG= 603709 Review URL: https://codereview.chromium.org/1911943002 Cr-Commit-Position: refs/heads/master@{#389581} [modify] https://crrev.com/cfc480b7040cddca093748c383ea1c3299d9088f/chrome/app/settings_chromium_strings.grdp [modify] https://crrev.com/cfc480b7040cddca093748c383ea1c3299d9088f/chrome/app/settings_google_chrome_strings.grdp [modify] https://crrev.com/cfc480b7040cddca093748c383ea1c3299d9088f/chrome/app/settings_strings.grdp [modify] https://crrev.com/cfc480b7040cddca093748c383ea1c3299d9088f/chrome/browser/resources/settings/reset_page/reset_profile_dialog.html [modify] https://crrev.com/cfc480b7040cddca093748c383ea1c3299d9088f/chrome/browser/resources/settings/reset_page/reset_profile_dialog.js [modify] https://crrev.com/cfc480b7040cddca093748c383ea1c3299d9088f/chrome/browser/resources/settings/search_engines_page/search_engines_page.html [modify] https://crrev.com/cfc480b7040cddca093748c383ea1c3299d9088f/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/cfc480b7040cddca093748c383ea1c3299d9088f/chrome/test/data/webui/settings/reset_page_test.js
,
Apr 25 2016
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by tbuck...@chromium.org
, Apr 15 2016