New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 603695 link

Starred by 1 user
Status: Fixed
Owner:
pav...@chromium.org
Closed: Apr 2016
Cc:
mastiz@chromium.org
█ tschumann@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Sync: DeviceInfoService should format ClientTag in backwards compatible way

Project Member Reported by pav...@chromium.org, Apr 14 2016 
DeviceInfoService uses cache_guid in places where ClientTag is required. It causes DCHECKS when DeviceInfoService receives DeviceInfo entry from directory based client. The reason is client_tag_hash delivered with entry doesn't match with the one calculated by client based on locally generated ClientTag.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76aa5567e3cf4ff5dc664c5d645c65c3a0be6987

commit 76aa5567e3cf4ff5dc664c5d645c65c3a0be6987
Author: pavely <pavely@chromium.org>
Date: Fri Apr 15 23:20:01 2016

[Sync] DeviceInfoService should format ClientTag in backwards compatible way

In order for existing clients to work correctly with entries from
USS based DeviceInfoService it should format ClientTag in the same way
DeviceInfoSyncService does.
In this change:
- In all interactions with sync "DeviceInfo_" prefix is used.
- plain cache_guids are used as local storage keys and keys into all_data_.

BUG= 603695 
R=skym@chromium.org

Review URL: https://codereview.chromium.org/1888923003

Cr-Commit-Position: refs/heads/master@{#387742}

[modify] https://crrev.com/76aa5567e3cf4ff5dc664c5d645c65c3a0be6987/components/sync_driver/device_info_service.cc
[modify] https://crrev.com/76aa5567e3cf4ff5dc664c5d645c65c3a0be6987/components/sync_driver/device_info_service.h
[modify] https://crrev.com/76aa5567e3cf4ff5dc664c5d645c65c3a0be6987/components/sync_driver/device_info_service_unittest.cc

Comment 2 by pav...@chromium.org, Apr 16 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment