Regression: "Video source" on WebRTC peer2peer page is displayed as "V" and "ideo source" |
|||||||||||||
Issue descriptionChrome Version: 51.0.2704.0 / 8172.1.10 dev What steps will reproduce the problem? 1. Browse to https://test.webrtc.org/manual/peer2peer/ 2. Observe "GetUserMedia" section What is the expected output? "Video source" should be displayed as correctly as "Video source" without any breakings What do you see instead? "Video source" is displayed as "V" on one line and "ideo source" on next line : https://screenshot.googleplex.com/Ximm78e9fgH.png Note: This issue is not seen in 51.0.2701.0 / 8165.0.0 dev build https://screenshot.googleplex.com/R3D6Wsu7D9Y.png
,
Apr 14 2016
,
Apr 15 2016
kojii@, can you take a look? The source code for https://test.webrtc.org/manual/peer2peer/ is available at https://github.com/webrtc/testrtc/tree/master/src/manual/peer2peer
,
Apr 16 2016
Confirmed, minimized case attached.
,
Apr 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a4e4eb3b4334905bc874dea2264b450f029fb605 commit a4e4eb3b4334905bc874dea2264b450f029fb605 Author: kojii <kojii@chromium.org> Date: Fri Apr 22 01:23:25 2016 Fix line wrappiing when break-word/break-all and float with 100% width This patch changes the line breaker to rewindToMidWordBreak() after it computes fitBelowFloats(). rewindToMidWordBreak() uses LineWidth::availableWidth(), which fitBelowFloats() may change if floats fill the whole line and the start of the line is pushed down below the floats. BUG= 603679 Review URL: https://codereview.chromium.org/1900393002 Cr-Commit-Position: refs/heads/master@{#388996} [add] https://crrev.com/a4e4eb3b4334905bc874dea2264b450f029fb605/third_party/WebKit/LayoutTests/fast/css3-text/css3-word-break/word-break-all-wrap-with-100percent-floats.html [modify] https://crrev.com/a4e4eb3b4334905bc874dea2264b450f029fb605/third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h
,
Apr 22 2016
,
Apr 26 2016
Verified the fix in M51 Canary 52.0.2717.0 in Mac, Windows. "Video source" is displayed correctly, without breaks in https://test.webrtc.org/manual/peer2peer/ Requesting a merge to M51
,
Apr 26 2016
Apologies for the typo in the above comment - I meant *M52 Canary 52.0.2717.0
,
Apr 26 2016
Your change meets the bar and is auto-approved for M51 (branch: 2704)
,
Apr 26 2016
Please merge your change before 5:00 PM PST today to M51 branch 2704, so we can take it for this week beta. Thank you.
,
Apr 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e583672da5cd5b223702b74e65c823a66c629f6c commit e583672da5cd5b223702b74e65c823a66c629f6c Author: Koji Ishii <kojii@chromium.org> Date: Wed Apr 27 01:05:41 2016 Fix line wrappiing when break-word/break-all and float with 100% width This patch changes the line breaker to rewindToMidWordBreak() after it computes fitBelowFloats(). rewindToMidWordBreak() uses LineWidth::availableWidth(), which fitBelowFloats() may change if floats fill the whole line and the start of the line is pushed down below the floats. BUG= 603679 Review URL: https://codereview.chromium.org/1900393002 Cr-Commit-Position: refs/heads/master@{#388996} (cherry picked from commit a4e4eb3b4334905bc874dea2264b450f029fb605) Review URL: https://codereview.chromium.org/1920293003 . Cr-Commit-Position: refs/branch-heads/2704@{#261} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} [add] https://crrev.com/e583672da5cd5b223702b74e65c823a66c629f6c/third_party/WebKit/LayoutTests/fast/css3-text/css3-word-break/word-break-all-wrap-with-100percent-floats.html [modify] https://crrev.com/e583672da5cd5b223702b74e65c823a66c629f6c/third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h
,
May 4 2016
Verified the merged on the latest M-51(51.0.2704.36) on Windows-7, Mac OS 10.11.4 and Linux Ubuntu 14.04. This is working as intended. Attached is the screenshot of the same.
,
May 4 2016
,
Jul 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d24d249700deef0ed63bf12ebb6af3b28f8225fb commit d24d249700deef0ed63bf12ebb6af3b28f8225fb Author: kojii <kojii@chromium.org> Date: Tue Jul 05 23:24:00 2016 Prevent to measure the whole word when break-all This patch applies the same heuristic fix as break-word to break-all. Since the switch to the complex path, r385693 fixed the performance and correctness issue of break-word and break-all in common cases. However, it also introduced a performance regression when a word is really long, such as minimized JS. This can be fixed by taking over the ShapeResult to the next lines as Gecko does, but it will require larger overhaul of the line breaker and need more time to bake. As an interim fix, r387974 introduced a heuristic fix for break-word. This patch applies the same heuristic to break-all. This patch also revealed that the fix for crbug.com/603679 was not correct. MidWordBreak must be recomputed when floats pushed the line down and available width changed. This patch includes the fix. BUG= 622810 , 603679 Review-Url: https://codereview.chromium.org/2077313002 Cr-Commit-Position: refs/heads/master@{#403830} [modify] https://crrev.com/d24d249700deef0ed63bf12ebb6af3b28f8225fb/third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h
,
Jul 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8b6b39703c17c81d31c03ed8d6b4ee9991a246d3 commit 8b6b39703c17c81d31c03ed8d6b4ee9991a246d3 Author: Koji Ishii <kojii@chromium.org> Date: Fri Jul 08 07:08:17 2016 Prevent to measure the whole word when break-all This patch applies the same heuristic fix as break-word to break-all. Since the switch to the complex path, r385693 fixed the performance and correctness issue of break-word and break-all in common cases. However, it also introduced a performance regression when a word is really long, such as minimized JS. This can be fixed by taking over the ShapeResult to the next lines as Gecko does, but it will require larger overhaul of the line breaker and need more time to bake. As an interim fix, r387974 introduced a heuristic fix for break-word. This patch applies the same heuristic to break-all. This patch also revealed that the fix for crbug.com/603679 was not correct. MidWordBreak must be recomputed when floats pushed the line down and available width changed. This patch includes the fix. BUG= 622810 , 603679 Review-Url: https://codereview.chromium.org/2077313002 Cr-Commit-Position: refs/heads/master@{#403830} (cherry picked from commit d24d249700deef0ed63bf12ebb6af3b28f8225fb) Review URL: https://codereview.chromium.org/2127393002 . Cr-Commit-Position: refs/branch-heads/2785@{#55} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/8b6b39703c17c81d31c03ed8d6b4ee9991a246d3/third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h
,
Jul 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/15a2ac4a185a2ab90a7381791ea10b403bcebf62 commit 15a2ac4a185a2ab90a7381791ea10b403bcebf62 Author: Koji Ishii <kojii@chromium.org> Date: Mon Jul 11 12:49:07 2016 Prevent to measure the whole word when break-all This patch applies the same heuristic fix as break-word to break-all. Since the switch to the complex path, r385693 fixed the performance and correctness issue of break-word and break-all in common cases. However, it also introduced a performance regression when a word is really long, such as minimized JS. This can be fixed by taking over the ShapeResult to the next lines as Gecko does, but it will require larger overhaul of the line breaker and need more time to bake. As an interim fix, r387974 introduced a heuristic fix for break-word. This patch applies the same heuristic to break-all. This patch also revealed that the fix for crbug.com/603679 was not correct. MidWordBreak must be recomputed when floats pushed the line down and available width changed. This patch includes the fix. BUG= 622810 , 603679 Review-Url: https://codereview.chromium.org/2077313002 Cr-Commit-Position: refs/heads/master@{#403830} (cherry picked from commit d24d249700deef0ed63bf12ebb6af3b28f8225fb) Review URL: https://codereview.chromium.org/2136013002 . Cr-Commit-Position: refs/branch-heads/2743@{#607} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/15a2ac4a185a2ab90a7381791ea10b403bcebf62/third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h
,
Jul 12 2016
Tested the issue on Windows 7, Mac 10.11.5, Ubuntu 14.04 using 53.0.2785.14. Observed that 'Video source' displayed correctly without any breaking. Please find attached screenshot. Marking it as TE-Verified-M53.
,
Jul 13 2016
Tested the issue on Windows 7, Mac 10.11.5, Ubuntu 14.04 using 52.0.2743.75. Observed that 'Video source' displayed correctly without any breaking. Please find attached screenshot. Marking it as TE-Verified-M52.
,
Jul 13 2016
|
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by srnarayanan@chromium.org
, Apr 14 2016