New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 603677 link

Starred by 0 users

Issue metadata

Status: Duplicate
Merged: issue 603676
Owner:
Last visit > 30 days ago
Closed: Apr 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

177.5% regression in smoothness.top_25_smooth at 385503:385559

Project Member Reported by rsch...@chromium.org, Apr 14 2016

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=603677

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg6J_qugoM


Bot(s) for this bug's original alert(s):

android-nexus5X
Project Member

Comment 2 by 42576172...@developer.gserviceaccount.com, Apr 14 2016

Mergedinto: 603676
Status: Duplicate (was: Assigned)

===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Browser Side Text Input State Tracking for OOPIF.
Author  : ekaramad
Commit description:
  
Currently, the TextInputStateChanged method is not implemented in RenderWidgetHostViewChildFrame. Conequently, the IME
will not work until this feature is fixed.

This CL implements the text input state tracking through refactoring most of the TextInputStateChanged code to the top-level RenderWidgetHostViewBase. The implementation is
based on FrameTree::GetFocusedFrame() and hence does not apply to non-OOPIF <webview> (RenderWidgetHostViewGuest).

This CL should also fix a previously reported race condition in the palindrome  crbug.com/546645  caused by RenderWidgetHostViewGuest's way of handling TextInputStateChanged.

BUG= 578168 ,  546645 

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review URL: https://codereview.chromium.org/1652483002

Cr-Commit-Position: refs/heads/master@{#385537}
Commit  : 2bd4a2f0c0f114979d47f4498ea1bce9b091591e
Date    : Wed Apr 06 20:14:02 2016


===== TESTED REVISIONS =====
Revision                Mean Value  Std. Dev.   Num Values  Good?
chromium@385502         47.72398    7.41512     5           good
chromium@385531         47.14364    4.687307    5           good
chromium@385535         55.84532    10.377422   5           good
chromium@385536         52.42914    12.99042    5           good
chromium@385537         146.4145    19.224356   5           bad         <-
chromium@385538         152.4436    23.031023   5           bad
chromium@385545         155.8307    15.656817   5           bad
chromium@385559         151.7558    10.475107   5           bad

Bisect job ran on: android_nexus5X_perf_bisect
Bug ID: 603677

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --also-run-disabled-tests smoothness.top_25_smooth
Test Metric: input_event_latency_discrepancy/http___games.yahoo.com
Relative Change: 217.99%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus5X_perf_bisect/builds/80
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9015376272364892960


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=603677

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Sign in to add a comment