Referrer not being set correctly for resumed downloads |
||||||
Issue descriptionReferrer header must be passed through for resumed downloads.
,
Apr 26 2016
,
Apr 26 2016
Is this going to be merged?
,
Apr 26 2016
Yup. There's a couple of changes that need to be merged before this one. I'll start requesting merges for the chain.
,
May 5 2016
Requesting merge to M51. The change has baked on Canary and is low risk.
,
May 5 2016
Your change meets the bar and is auto-approved for M51 (branch: 2704)
,
May 6 2016
Please merge your change to M51 branch 2704 by 5:00 PM PST Monday(05/09) so we can take it for next week beta release.Thank you.
,
May 9 2016
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/69bc08ef5cd48356e6a254ff8366159cdeeefc1a commit 69bc08ef5cd48356e6a254ff8366159cdeeefc1a Author: Asanka Herath <asanka@chromium.org> Date: Tue May 10 03:44:07 2016 [Merge M51][Downloads] Set the Referrer header for resumed requests. During downloads resumption, the newly created URLRequest was not getting the Referrer header set. Now it is. R=jam@chromium.org,svaldez@chromium.org BUG= 603670 Review URL: https://codereview.chromium.org/1891623003 Cr-Commit-Position: refs/heads/master@{#389636} (cherry picked from commit f7ae1f45615bc167f2081079557322eefba02c0b) Review URL: https://codereview.chromium.org/1958383002 . Cr-Commit-Position: refs/branch-heads/2704@{#460} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} [modify] https://crrev.com/69bc08ef5cd48356e6a254ff8366159cdeeefc1a/content/browser/download/download_browsertest.cc [modify] https://crrev.com/69bc08ef5cd48356e6a254ff8366159cdeeefc1a/content/browser/download/download_item_impl.cc [modify] https://crrev.com/69bc08ef5cd48356e6a254ff8366159cdeeefc1a/content/public/test/test_download_request_handler.cc [modify] https://crrev.com/69bc08ef5cd48356e6a254ff8366159cdeeefc1a/content/public/test/test_download_request_handler.h [add] https://crrev.com/69bc08ef5cd48356e6a254ff8366159cdeeefc1a/content/test/data/download/download-link.html [add] https://crrev.com/69bc08ef5cd48356e6a254ff8366159cdeeefc1a/content/test/data/download/download-link.html.mock-http-headers
,
May 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/952e604216835e9d53fc145948a069864ad0372e commit 952e604216835e9d53fc145948a069864ad0372e Author: Asanka Herath <asanka@chromium.org> Date: Tue May 10 04:04:46 2016 [Branch M51] Cleanup unnecessary test. It got picked up while resolving a merge conflict for 69bc08ef5cd48356e6a254ff8366159cdeeefc1a. BUG= 603670 TBR=asanka@chromium.org Review URL: https://codereview.chromium.org/1958283004 . Cr-Commit-Position: refs/branch-heads/2704@{#461} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} [modify] https://crrev.com/952e604216835e9d53fc145948a069864ad0372e/content/browser/download/download_browsertest.cc
,
May 10 2016
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Apr 26 2016