New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 603648 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

MemoryInfra: Track the count of allocations in heap profiler

Project Member Reported by ssid@chromium.org, Apr 14 2016

Issue description

Background context:go/memory-infra: memory profiling in chrome://tracing

We have a general feeling that the number of allocations made will be useful data to display along with the size for each stack frame and type in heap profiler.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1eedc59e16922772a374b00de7546e6c34a30c11

commit 1eedc59e16922772a374b00de7546e6c34a30c11
Author: ssid <ssid@chromium.org>
Date: Fri Apr 15 01:56:44 2016

[tracing] Track number of allocations in heap profiler

This CL adds a count along with size that is tracked for each allocation
context to the trace files.

BUG= 603648 

Review URL: https://codereview.chromium.org/1877313003

Cr-Commit-Position: refs/heads/master@{#387517}

[modify] https://crrev.com/1eedc59e16922772a374b00de7546e6c34a30c11/base/trace_event/heap_profiler_allocation_context.h
[modify] https://crrev.com/1eedc59e16922772a374b00de7546e6c34a30c11/base/trace_event/heap_profiler_heap_dump_writer.cc
[modify] https://crrev.com/1eedc59e16922772a374b00de7546e6c34a30c11/base/trace_event/heap_profiler_heap_dump_writer.h
[modify] https://crrev.com/1eedc59e16922772a374b00de7546e6c34a30c11/base/trace_event/heap_profiler_heap_dump_writer_unittest.cc
[modify] https://crrev.com/1eedc59e16922772a374b00de7546e6c34a30c11/base/trace_event/malloc_dump_provider.cc
[modify] https://crrev.com/1eedc59e16922772a374b00de7546e6c34a30c11/third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.cpp
[modify] https://crrev.com/1eedc59e16922772a374b00de7546e6c34a30c11/third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProvider.cpp
[modify] https://crrev.com/1eedc59e16922772a374b00de7546e6c34a30c11/third_party/WebKit/Source/platform/web_process_memory_dump_impl.cc
[modify] https://crrev.com/1eedc59e16922772a374b00de7546e6c34a30c11/third_party/WebKit/Source/platform/web_process_memory_dump_impl.h
[modify] https://crrev.com/1eedc59e16922772a374b00de7546e6c34a30c11/third_party/WebKit/public/platform/WebProcessMemoryDump.h

Cc: primiano@chromium.org
+cc primiano

Comment 3 by ssid@chromium.org, Apr 15 2016

@petrcermak can I re-assign this bug to you to display the count or can I look into the trace viewer change as well?
Owner: petrcermak@chromium.org
Status: Assigned (was: Untriaged)
I filed a Catapult bug for this and assigned it to myself: https://github.com/catapult-project/catapult/issues/2258
Project Member

Comment 5 by bugdroid1@chromium.org, May 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b1f0a8fa34b9db2e41c9594f98d1e9f0712c3eb3

commit b1f0a8fa34b9db2e41c9594f98d1e9f0712c3eb3
Author: catapult-deps-roller <catapult-deps-roller@chromium.org>
Date: Tue May 03 13:52:10 2016

Roll src/third_party/catapult/ 79eba396c..6ab700569 (1 commit).

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/79eba396c4af..6ab700569be8

$ git log 79eba396c..6ab700569 --date=short --no-merges --format='%ad %ae %s'

BUG= 603648 

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/1945613002
Cr-Commit-Position: refs/heads/master@{#391222}

[modify] https://crrev.com/b1f0a8fa34b9db2e41c9594f98d1e9f0712c3eb3/DEPS

Project Member

Comment 6 by bugdroid1@chromium.org, May 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0dbefdcc5383143894e8e75975b6ed06f4784c5a

commit 0dbefdcc5383143894e8e75975b6ed06f4784c5a
Author: catapult-deps-roller <catapult-deps-roller@chromium.org>
Date: Fri May 06 11:47:16 2016

Roll src/third_party/catapult/ 61f092441..87fcc6ff4 (1 commit).

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/61f092441824..87fcc6ff4789

$ git log 61f092441..87fcc6ff4 --date=short --no-merges --format='%ad %ae %s'

BUG= 603648 

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/1954013002
Cr-Commit-Position: refs/heads/master@{#392038}

[modify] https://crrev.com/0dbefdcc5383143894e8e75975b6ed06f4784c5a/DEPS

Project Member

Comment 7 by bugdroid1@chromium.org, May 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b58bb47b250ac3972fc3925ac453f12298f0fd14

commit b58bb47b250ac3972fc3925ac453f12298f0fd14
Author: catapult-deps-roller <catapult-deps-roller@chromium.org>
Date: Fri May 13 15:02:35 2016

Roll src/third_party/catapult/ d1739687c..0e74607c5 (1 commit).

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/d1739687cdc0..0e74607c5b95

$ git log d1739687c..0e74607c5 --date=short --no-merges --format='%ad %ae %s'

BUG= 603648 

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/1980513002
Cr-Commit-Position: refs/heads/master@{#393525}

[modify] https://crrev.com/b58bb47b250ac3972fc3925ac453f12298f0fd14/DEPS

Status: Fixed (was: Assigned)
This is now done: https://github.com/catapult-project/catapult/issues/2258
Components: Internals>Instrumentation>Memory

Sign in to add a comment