New issue
Advanced search Search tips

Issue 603640 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Set basic information for new profiles and credit cards.

Project Member Reported by se...@chromium.org, Apr 14 2016

Issue description

The use count of new autofill data models is 0, the use date and modification date are set to the default Time value.

The use count should instead be set to 1 and the dates be set to "now".

 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43391bda1708665a069ca796e59c60b15720b37c

commit 43391bda1708665a069ca796e59c60b15720b37c
Author: sebsg <sebsg@chromium.org>
Date: Mon Apr 25 19:50:09 2016

Set the use count to one and the use date and modification date to "now".

Changed AutofillProfileSyncableService::MergeProfile to MergeSimilarProfiles. It now compared the merge_into before and after the merge to determine if the merge had any effect. It fixes  bug 248440 .

Also changed AutofillProfile::PrimaryValue(). Its comment said it included the name but it did not. The name was added because a profile otherwise two people living at the same address could have the profile overwrite one another instead of creating two distinct profiles.

BUG= 603640 ,  248440 
TEST=PersonalDataManagerTest, AutofillProfileSyncableServiceTest, ProfileSyncServiceAutofillTest

Review URL: https://codereview.chromium.org/1891903002

Cr-Commit-Position: refs/heads/master@{#389545}

[modify] https://crrev.com/43391bda1708665a069ca796e59c60b15720b37c/components/autofill/core/browser/autofill_data_model.cc
[modify] https://crrev.com/43391bda1708665a069ca796e59c60b15720b37c/components/autofill/core/browser/autofill_manager_unittest.cc
[modify] https://crrev.com/43391bda1708665a069ca796e59c60b15720b37c/components/autofill/core/browser/autofill_profile.cc
[modify] https://crrev.com/43391bda1708665a069ca796e59c60b15720b37c/components/autofill/core/browser/autofill_profile.h
[modify] https://crrev.com/43391bda1708665a069ca796e59c60b15720b37c/components/autofill/core/browser/personal_data_manager_unittest.cc
[modify] https://crrev.com/43391bda1708665a069ca796e59c60b15720b37c/components/autofill/core/browser/webdata/autofill_profile_syncable_service.cc
[modify] https://crrev.com/43391bda1708665a069ca796e59c60b15720b37c/components/autofill/core/browser/webdata/autofill_profile_syncable_service.h
[modify] https://crrev.com/43391bda1708665a069ca796e59c60b15720b37c/components/autofill/core/browser/webdata/autofill_profile_syncable_service_unittest.cc
[modify] https://crrev.com/43391bda1708665a069ca796e59c60b15720b37c/components/autofill/core/browser/webdata/autofill_table_unittest.cc
[modify] https://crrev.com/43391bda1708665a069ca796e59c60b15720b37c/components/browser_sync/browser/profile_sync_service_autofill_unittest.cc

Comment 2 by se...@chromium.org, Apr 26 2016

Status: Fixed (was: Started)

Sign in to add a comment