New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 603636 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove unused QUIC histograms

Project Member Reported by zhongyi@chromium.org, Apr 14 2016

Issue description

Remove those obsolete histograms:

Net.QuicEphemeralPortsSuggested
Net.QuicSession.21*
Net.QuicSession.6*
Net.QuicSession.ConnectSelectPort*
Net.QuicSession.PacketLossRate*
Net.QuicSession.PacketReceived*
Net.QuicSession.TruncatedAcksSent - Truncated acks are going away anyway.
Net.QuicSession.TruncatedAcksReceived

Ones with no data because they're for insecure QUIC, which doesn't exist anymore:
Net.QuicSession.ConnectRandomPort
Net.QuicSession.ConnectRandomPortRequiringConfirmation
 
Owner: zhongyi@chromium.org
Status: Assigned (was: Available)
Labels: Hotlist-HistogramEraser
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 25 2016

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 26 2016

Comment 5 by jar@chromium.org, Apr 26 2016

Several of the listed histograms are probably reasonable to delete, but several are probably still quite useful.  Here are some comments:

Net.QuicEphemeralPortsSuggested: Feature no longer used... delete
Net.QuicSession.21*  Still very valuable for FEC design
Net.QuicSession.6*   Still very valuable for FEC design
Net.QuicSession.ConnectSelectPort*  Feature no longer used... delete
Net.QuicSession.PacketLossRate*   Probably valuable to congestion avoidance work.
Net.QuicSession.PacketReceived*   Still valuable for congestion avoidance.
Net.QuicSession.TruncatedAcksSent - Truncated acks are going away anyway.
Net.QuicSession.TruncatedAcksReceived
Thanks for the update here.

Did found out that Net.QuicSession.21* and Net.QuicSession.6* are really good data we wanna keep. I will verify the usage one by one and remove them safely. 
FYI, for any histograms that provide good data, but are not necessarily checked very regularly, you might want to add Chirp subscriptions for those histograms.
The following commit has already removed for Net.QuicSession.ConnectRandomPort
Net.QuicSession.ConnectRandomPortRequiringConfirmation:

https://chromium.googlesource.com/chromium/src/+/5830b56292abdae9c4f93c89a00edc4ad6585c41
Status: Fixed (was: Assigned)

Sign in to add a comment