New issue
Advanced search Search tips

Issue 603625 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug

Blocking:
issue 425627
issue 614588



Sign in to add a comment

[About Chrome] Add About Chrome page

Project Member Reported by tbuck...@chromium.org, Apr 14 2016

Issue description

Project Member

Comment 2 by bugdroid1@chromium.org, May 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45ab5fa295d517c842053780bed69ee5d88f382b

commit 45ab5fa295d517c842053780bed69ee5d88f382b
Author: dpapad <dpapad@chromium.org>
Date: Fri May 06 21:30:17 2016

MD Settings: Adding "About" page basic structure.

BUG= 603625 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/1950423003
Cr-Commit-Position: refs/heads/master@{#392162}

[add] https://crrev.com/45ab5fa295d517c842053780bed69ee5d88f382b/chrome/browser/resources/settings/about_page/about_page.html
[add] https://crrev.com/45ab5fa295d517c842053780bed69ee5d88f382b/chrome/browser/resources/settings/about_page/about_page.js
[add] https://crrev.com/45ab5fa295d517c842053780bed69ee5d88f382b/chrome/browser/resources/settings/about_page/compiled_resources2.gyp
[modify] https://crrev.com/45ab5fa295d517c842053780bed69ee5d88f382b/chrome/browser/resources/settings/compiled_resources2.gyp
[modify] https://crrev.com/45ab5fa295d517c842053780bed69ee5d88f382b/chrome/browser/resources/settings/settings_main/settings_main.html
[modify] https://crrev.com/45ab5fa295d517c842053780bed69ee5d88f382b/chrome/browser/resources/settings/settings_page.css
[modify] https://crrev.com/45ab5fa295d517c842053780bed69ee5d88f382b/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/45ab5fa295d517c842053780bed69ee5d88f382b/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Project Member

Comment 3 by bugdroid1@chromium.org, May 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/30d3baf9782b1967e6b658e25c7059cb2e03f196

commit 30d3baf9782b1967e6b658e25c7059cb2e03f196
Author: dpapad <dpapad@chromium.org>
Date: Wed May 11 02:14:28 2016

MD Settings: About page, porting C++ handler and adding browser proxy.

BUG= 546841 , 603625 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/1971483002
Cr-Commit-Position: refs/heads/master@{#392824}

[add] https://crrev.com/30d3baf9782b1967e6b658e25c7059cb2e03f196/chrome/browser/resources/settings/about_page/about_page_browser_proxy.html
[add] https://crrev.com/30d3baf9782b1967e6b658e25c7059cb2e03f196/chrome/browser/resources/settings/about_page/about_page_browser_proxy.js
[modify] https://crrev.com/30d3baf9782b1967e6b658e25c7059cb2e03f196/chrome/browser/resources/settings/about_page/compiled_resources2.gyp
[modify] https://crrev.com/30d3baf9782b1967e6b658e25c7059cb2e03f196/chrome/browser/resources/settings/settings_resources.grd
[add] https://crrev.com/30d3baf9782b1967e6b658e25c7059cb2e03f196/chrome/browser/ui/webui/settings/about_handler.cc
[add] https://crrev.com/30d3baf9782b1967e6b658e25c7059cb2e03f196/chrome/browser/ui/webui/settings/about_handler.h
[modify] https://crrev.com/30d3baf9782b1967e6b658e25c7059cb2e03f196/chrome/browser/ui/webui/settings/md_settings_ui.cc
[modify] https://crrev.com/30d3baf9782b1967e6b658e25c7059cb2e03f196/chrome/chrome_browser_ui.gypi

Comment 4 by dpa...@chromium.org, May 13 2016

Owner: dpa...@chromium.org
Status: Started (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, May 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b52de52a794f126220c2a671334279f9fc3b65fe

commit b52de52a794f126220c2a671334279f9fc3b65fe
Author: dpapad <dpapad@chromium.org>
Date: Tue May 17 03:13:12 2016

MD Settings: About page, implement help and feedback.

BUG= 603625 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/1981033003
Cr-Commit-Position: refs/heads/master@{#394039}

[modify] https://crrev.com/b52de52a794f126220c2a671334279f9fc3b65fe/chrome/app/settings_chromium_strings.grdp
[modify] https://crrev.com/b52de52a794f126220c2a671334279f9fc3b65fe/chrome/app/settings_google_chrome_strings.grdp
[modify] https://crrev.com/b52de52a794f126220c2a671334279f9fc3b65fe/chrome/app/settings_strings.grdp
[modify] https://crrev.com/b52de52a794f126220c2a671334279f9fc3b65fe/chrome/browser/resources/settings/about_page/about_page.html
[modify] https://crrev.com/b52de52a794f126220c2a671334279f9fc3b65fe/chrome/browser/resources/settings/about_page/about_page.js
[modify] https://crrev.com/b52de52a794f126220c2a671334279f9fc3b65fe/chrome/browser/resources/settings/about_page/compiled_resources2.gyp
[modify] https://crrev.com/b52de52a794f126220c2a671334279f9fc3b65fe/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/b52de52a794f126220c2a671334279f9fc3b65fe/chrome/test/data/webui/settings/about_page_tests.js
[modify] https://crrev.com/b52de52a794f126220c2a671334279f9fc3b65fe/chrome/test/data/webui/settings/cr_settings_browsertest.js

Project Member

Comment 8 by bugdroid1@chromium.org, May 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19cd3d2e33edd3bacdc7acff4f758f3fc3e2a589

commit 19cd3d2e33edd3bacdc7acff4f758f3fc3e2a589
Author: dpapad <dpapad@chromium.org>
Date: Fri May 20 18:18:30 2016

MD Settings: About page, implementing update status.

Specifically updating the status icon and status message according
to incoming events from the browser. The various buttons
(restart/relaunch/check-for-updates) will be handled in follow up CL.

BUG= 603625 , 546841 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/1987813004
Cr-Commit-Position: refs/heads/master@{#395118}

[modify] https://crrev.com/19cd3d2e33edd3bacdc7acff4f758f3fc3e2a589/chrome/browser/resources/settings/about_page/about_page.html
[modify] https://crrev.com/19cd3d2e33edd3bacdc7acff4f758f3fc3e2a589/chrome/browser/resources/settings/about_page/about_page.js
[modify] https://crrev.com/19cd3d2e33edd3bacdc7acff4f758f3fc3e2a589/chrome/browser/resources/settings/about_page/about_page_browser_proxy.js
[modify] https://crrev.com/19cd3d2e33edd3bacdc7acff4f758f3fc3e2a589/chrome/browser/resources/settings/about_page/compiled_resources2.gyp
[modify] https://crrev.com/19cd3d2e33edd3bacdc7acff4f758f3fc3e2a589/chrome/browser/resources/settings/about_page/detailed_build_info.js
[modify] https://crrev.com/19cd3d2e33edd3bacdc7acff4f758f3fc3e2a589/chrome/browser/resources/settings/icons.html
[modify] https://crrev.com/19cd3d2e33edd3bacdc7acff4f758f3fc3e2a589/chrome/test/data/webui/settings/about_page_tests.js

Project Member

Comment 9 by bugdroid1@chromium.org, May 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c82e33281c61d660697a56bb337c598e487ef0a

commit 2c82e33281c61d660697a56bb337c598e487ef0a
Author: dpapad <dpapad@chromium.org>
Date: Mon May 23 20:10:01 2016

MD Settings: About page, updating buttons based on current update status.

 - For ChromeOS there are three buttons, "Check for updates", "Restart"
   and "Restart and Powerwash".
 - For non-Chrome OS there is only one "Relaunch" button.

BUG= 546841 , 603625 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/1997453006
Cr-Commit-Position: refs/heads/master@{#395398}

[modify] https://crrev.com/2c82e33281c61d660697a56bb337c598e487ef0a/chrome/app/settings_strings.grdp
[modify] https://crrev.com/2c82e33281c61d660697a56bb337c598e487ef0a/chrome/browser/resources/settings/about_page/about_page.html
[modify] https://crrev.com/2c82e33281c61d660697a56bb337c598e487ef0a/chrome/browser/resources/settings/about_page/about_page.js
[modify] https://crrev.com/2c82e33281c61d660697a56bb337c598e487ef0a/chrome/browser/resources/settings/about_page/about_page_browser_proxy.js
[modify] https://crrev.com/2c82e33281c61d660697a56bb337c598e487ef0a/chrome/browser/resources/settings/about_page/compiled_resources2.gyp
[modify] https://crrev.com/2c82e33281c61d660697a56bb337c598e487ef0a/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/2c82e33281c61d660697a56bb337c598e487ef0a/chrome/test/data/webui/settings/about_page_tests.js

Labels: Hotlist-MD-Settings-About
Project Member

Comment 11 by bugdroid1@chromium.org, May 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/579707b053f21e5d018284238b512d13658290fb

commit 579707b053f21e5d018284238b512d13658290fb
Author: dpapad <dpapad@chromium.org>
Date: Tue May 24 03:45:22 2016

MD Settings: About page, display product info.

BUG= 546841 , 603625 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2007733002
Cr-Commit-Position: refs/heads/master@{#395527}

[modify] https://crrev.com/579707b053f21e5d018284238b512d13658290fb/chrome/browser/resources/settings/about_page/about_page.html
[modify] https://crrev.com/579707b053f21e5d018284238b512d13658290fb/chrome/browser/ui/webui/settings/about_handler.cc

Labels: OS-Linux OS-Mac OS-Windows
Labels: Hotlist-MD-DevBlocker
Blocking: 614588
Labels: -Hotlist-MD-DevBlocker
@bettes: I am not seeing any assets for Chromium and Chromium OS (see attachments for the assets used by the old Options).
chromium_os_logo.png
20.4 KB View Download
chromium_logo.png
14.7 KB View Download
Also note that the old Options code (and current MD Settings "About" code), receives the product name as a string from the browser, it is not part of the image being displayed. The assets provided at comment 16 have the product name as part of the image. Is this change intentional?
Project Member

Comment 21 by bugdroid1@chromium.org, Jun 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d7c62a79b8d747b5cdcdd163abff3839aceca8f

commit 2d7c62a79b8d747b5cdcdd163abff3839aceca8f
Author: dpapad <dpapad@chromium.org>
Date: Thu Jun 09 20:56:55 2016

MD Settings: About page, fix bug causing update status message to not update.

The bug was twofold
 1) Non ChromeOS data binding should not depend on targetChannel_, since
    targetChannel_ is only defined for ChromeOS.
 2) There was a typo in the HTML data binding, s/targetChannel/targetChannel_.

Previous test was only checking that the update status icon was updated, without
making assertions about the update status message.

BUG= 546841 , 603625 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2050903002
Cr-Commit-Position: refs/heads/master@{#399011}

[modify] https://crrev.com/2d7c62a79b8d747b5cdcdd163abff3839aceca8f/chrome/browser/resources/settings/about_page/about_page.html
[modify] https://crrev.com/2d7c62a79b8d747b5cdcdd163abff3839aceca8f/chrome/test/data/webui/settings/about_page_tests.js

Per 19, that change is intentional. The product name is now part of the logo. 

Per 18, links to chromium assets below. There is no notion of an OS in the branding of chromebooks anymore so use "Chromium" for both browser and OS. 

https://drive.google.com/a/google.com/file/d/0BxMIIGI80eU-eGdoQnlTS0FyVUE/view?usp=sharing
https://drive.google.com/a/google.com/file/d/0BxMIIGI80eU-aWdxS19xMjc2b1E/view?usp=sharing


Screen Shot 2016-06-09 at 3.48.46 PM.png
14.2 KB View Download
Blockedon: 619120
Project Member

Comment 24 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d7c62a79b8d747b5cdcdd163abff3839aceca8f

commit 2d7c62a79b8d747b5cdcdd163abff3839aceca8f
Author: dpapad <dpapad@chromium.org>
Date: Thu Jun 09 20:56:55 2016

MD Settings: About page, fix bug causing update status message to not update.

The bug was twofold
 1) Non ChromeOS data binding should not depend on targetChannel_, since
    targetChannel_ is only defined for ChromeOS.
 2) There was a typo in the HTML data binding, s/targetChannel/targetChannel_.

Previous test was only checking that the update status icon was updated, without
making assertions about the update status message.

BUG= 546841 , 603625 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2050903002
Cr-Commit-Position: refs/heads/master@{#399011}

[modify] https://crrev.com/2d7c62a79b8d747b5cdcdd163abff3839aceca8f/chrome/browser/resources/settings/about_page/about_page.html
[modify] https://crrev.com/2d7c62a79b8d747b5cdcdd163abff3839aceca8f/chrome/test/data/webui/settings/about_page_tests.js

Blockedon: -619120
Status: Fixed (was: Started)
Removing the 619120 from the blocker's list of this bug, per offline discussion with Tom. Not aware of any other pending items for the Chrome About page, feel free to file new bugs if anything is missing. 

Sign in to add a comment